ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

JIT: revert cmpXX optimization 

It seems like this wasn't correct in 100% of cases.
This commit is contained in:
Fiora 2014-11-03 17:50:13 -08:00
parent 8c981aad04
commit 768273f59b
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Source/Core/Core/PowerPC/Jit64/Jit_Integer.cpp
View File

@ -556,16 +556,7 @@ void Jit64::cmpXX(UGeckoInstruction inst)
MOV(64, PPCSTATE(cr_val[crf]), R(input)); MOV(64, PPCSTATE(cr_val[crf]), R(input));
// Place the comparison next to the branch for macro-op fusion // Place the comparison next to the branch for macro-op fusion
if (merge_branch) if (merge_branch)
{ TEST(64, R(input), R(input));
// We only need to do a 32-bit compare, since the flags set will be the same as a sign-extended
// result.
// We should also test against gpr.R(a) if it's bound, since that's one less cycle of latency
// (the CPU doesn't have to wait for the movsxd to finish to resolve the branch).
if (gpr.R(a).IsSimpleReg())
TEST(32, gpr.R(a), gpr.R(a));
else
TEST(32, R(input), R(input));
}
} }
else else
{ {