ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ControllerInterface: Fix uninitialized variables in DualShockUDPClient 

Strangely, this case did not trigger a C26495 warning in Visual Studio's analyzer; instead, I spotted this when using Valgrind.
This commit is contained in:
Pokechu22 2023-02-15 19:23:47 -08:00
parent 67381cdb8b
commit 74a14c7d1f
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Source/Core/InputCommon/ControllerInterface/DualShockUDPClient/DualShockUDPClient.cpp
View File

@ -153,10 +153,10 @@ private:
const std::string m_server_address; const std::string m_server_address;
const u16 m_server_port; const u16 m_server_port;
s16 m_touch_x_min; s16 m_touch_x_min = 0;
s16 m_touch_y_min; s16 m_touch_y_min = 0;
s16 m_touch_x_max; s16 m_touch_x_max = 0;
s16 m_touch_y_max; s16 m_touch_y_max = 0;
const u32 m_client_uid; const u32 m_client_uid;
}; };
@ -192,7 +192,7 @@ struct Server
std::string m_description; std::string m_description;
std::string m_address; std::string m_address;
u16 m_port; u16 m_port = 0;
std::array<Proto::MessageType::PortInfo, Proto::PORT_COUNT> m_port_info{}; std::array<Proto::MessageType::PortInfo, Proto::PORT_COUNT> m_port_info{};
sf::UdpSocket m_socket; sf::UdpSocket m_socket;
SteadyClock::time_point m_disconnect_time = SteadyClock::now(); SteadyClock::time_point m_disconnect_time = SteadyClock::now();
@ -213,9 +213,9 @@ private:
void StartHotplugThread(); void StartHotplugThread();
void StopHotplugThread(); void StopHotplugThread();
bool m_servers_enabled; bool m_servers_enabled = false;
std::vector<Server> m_servers; std::vector<Server> m_servers;
u32 m_client_uid; u32 m_client_uid = 0;
SteadyClock::time_point m_next_listports_time; SteadyClock::time_point m_next_listports_time;
std::thread m_hotplug_thread; std::thread m_hotplug_thread;
Common::Flag m_hotplug_thread_running; Common::Flag m_hotplug_thread_running;