From 72e1131123a1900815b9984396a720eae20fe9f0 Mon Sep 17 00:00:00 2001 From: Thomas May Date: Tue, 27 Oct 2020 11:05:53 +0000 Subject: [PATCH] Common: Fix logger related crash when HTTP response is empty --- Source/Core/Common/HttpRequest.cpp | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Source/Core/Common/HttpRequest.cpp b/Source/Core/Common/HttpRequest.cpp index 1cbf2aebc4..a60b33abbd 100644 --- a/Source/Core/Common/HttpRequest.cpp +++ b/Source/Core/Common/HttpRequest.cpp @@ -221,8 +221,16 @@ HttpRequest::Response HttpRequest::Impl::Fetch(const std::string& url, Method me curl_easy_getinfo(m_curl.get(), CURLINFO_RESPONSE_CODE, &response_code); if (response_code != 200) { - ERROR_LOG_FMT(COMMON, "Failed to {} {}: server replied with code {} and body\n\x1b[0m{:.{}}", - type, url, response_code, buffer.data(), static_cast(buffer.size())); + if (buffer.empty()) + { + ERROR_LOG_FMT(COMMON, "Failed to {} {}: server replied with code {}", type, url, + response_code); + } + else + { + ERROR_LOG_FMT(COMMON, "Failed to {} {}: server replied with code {} and body\n\x1b[0m{:.{}}", + type, url, response_code, buffer.data(), static_cast(buffer.size())); + } return {}; }