From 6a2ec825a225d07208d61aeeaf62c3c5525745f0 Mon Sep 17 00:00:00 2001 From: Pokechu22 Date: Mon, 13 Jun 2022 19:00:15 -0700 Subject: [PATCH] UnitTests: Fail DSPAssemblyTest if the assembled code doesn't match the expected result This reveals that both HermesText and HermesBinary fail. HermesBinary would have failed on master, too, if this had been implemented. --- Source/UnitTests/Core/DSP/DSPAssemblyTest.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Source/UnitTests/Core/DSP/DSPAssemblyTest.cpp b/Source/UnitTests/Core/DSP/DSPAssemblyTest.cpp index c9d21bb9a0..17e4d70b3d 100644 --- a/Source/UnitTests/Core/DSP/DSPAssemblyTest.cpp +++ b/Source/UnitTests/Core/DSP/DSPAssemblyTest.cpp @@ -46,8 +46,8 @@ static bool RoundTrip(const std::vector& code1) } if (!DSP::Compare(code1, code2)) { - DSP::Disassemble(code1, true, text); - fmt::print("{}", text); + fmt::print("RoundTrip: Assembled code does not match input code\n"); + return false; } return true; } @@ -81,6 +81,12 @@ static bool SuperTrip(const char* asm_code) fmt::print("SuperTrip: Second assembly failed\n"); return false; } + + if (!DSP::Compare(code1, code2)) + { + fmt::print("SuperTrip: Assembled code does not match between passes\n"); + return false; + } return true; }