From dd5e0c6e153015e428d2ce246ae77c2e20aed678 Mon Sep 17 00:00:00 2001 From: OatmealDome Date: Wed, 30 Jun 2021 02:16:37 -0400 Subject: [PATCH] UpdaterCommon: Move the updated file instead of copying This prevents macOS from reading an old (cached) code signature on Mach-O executables. --- Source/Core/UpdaterCommon/UpdaterCommon.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/UpdaterCommon/UpdaterCommon.cpp b/Source/Core/UpdaterCommon/UpdaterCommon.cpp index f52755aeb5..99dd62a0d9 100644 --- a/Source/Core/UpdaterCommon/UpdaterCommon.cpp +++ b/Source/Core/UpdaterCommon/UpdaterCommon.cpp @@ -460,7 +460,7 @@ bool UpdateFiles(const std::vector& to_update, std::string content_filename = HexEncode(op.new_hash.data(), op.new_hash.size()); fprintf(log_fp, "Updating file %s from content %s...\n", op.filename.c_str(), content_filename.c_str()); - if (!File::Copy(temp_path + DIR_SEP + content_filename, path)) + if (!File::Rename(temp_path + DIR_SEP + content_filename, path)) { fprintf(log_fp, "Could not update file %s.\n", op.filename.c_str()); return false;