diff --git a/Source/Core/Core/Movie.cpp b/Source/Core/Core/Movie.cpp index bcd777357c..9e4ef23607 100644 --- a/Source/Core/Core/Movie.cpp +++ b/Source/Core/Core/Movie.cpp @@ -93,8 +93,8 @@ static bool s_bPolled = false; static std::mutex s_input_display_lock; static std::string s_InputDisplay[8]; -static GCManipFunction gcmfunc; -static WiiManipFunction wiimfunc; +static GCManipFunction s_gc_manip_func; +static WiiManipFunction s_wii_manip_func; // NOTE: Host / CPU Thread static void EnsureTmpInputSize(size_t bound) @@ -1442,25 +1442,25 @@ void SaveRecording(const std::string& filename) void SetGCInputManip(GCManipFunction func) { - gcmfunc = std::move(func); + s_gc_manip_func = std::move(func); } void SetWiiInputManip(WiiManipFunction func) { - wiimfunc = std::move(func); + s_wii_manip_func = std::move(func); } // NOTE: CPU Thread void CallGCInputManip(GCPadStatus* PadStatus, int controllerID) { - if (gcmfunc) - gcmfunc(PadStatus, controllerID); + if (s_gc_manip_func) + s_gc_manip_func(PadStatus, controllerID); } // NOTE: CPU Thread void CallWiiInputManip(u8* data, WiimoteEmu::ReportFeatures rptf, int controllerID, int ext, const wiimote_key key) { - if (wiimfunc) - wiimfunc(data, rptf, controllerID, ext, key); + if (s_wii_manip_func) + s_wii_manip_func(data, rptf, controllerID, ext, key); } // NOTE: GPU Thread diff --git a/Source/Core/DolphinWX/Frame.cpp b/Source/Core/DolphinWX/Frame.cpp index 830003e6c5..73d4c497bd 100644 --- a/Source/Core/DolphinWX/Frame.cpp +++ b/Source/Core/DolphinWX/Frame.cpp @@ -502,15 +502,15 @@ void CFrame::BindEvents() void CFrame::InitializeTASDialogs() { for (int i = 0; i < 8; ++i) - g_TASInputDlg[i] = new TASInputDlg(this); + m_tas_input_dialogs[i] = new TASInputDlg(this); Movie::SetGCInputManip([this](GCPadStatus* pad_status, int controller_id) { - g_TASInputDlg[controller_id]->GetValues(pad_status); + m_tas_input_dialogs[controller_id]->GetValues(pad_status); }); Movie::SetWiiInputManip([this](u8* data, WiimoteEmu::ReportFeatures rptf, int controller_id, int ext, wiimote_key key) { - g_TASInputDlg[controller_id + 4]->GetValues(data, rptf, ext, key); + m_tas_input_dialogs[controller_id + 4]->GetValues(data, rptf, ext, key); }); } diff --git a/Source/Core/DolphinWX/Frame.h b/Source/Core/DolphinWX/Frame.h index b839512440..eec1ee0ab8 100644 --- a/Source/Core/DolphinWX/Frame.h +++ b/Source/Core/DolphinWX/Frame.h @@ -137,7 +137,7 @@ private: CLogWindow* m_LogWindow = nullptr; LogConfigWindow* m_LogConfigWindow = nullptr; FifoPlayerDlg* m_FifoPlayerDlg = nullptr; - TASInputDlg* g_TASInputDlg[8]; + TASInputDlg* m_tas_input_dialogs[8]; bool UseDebugger = false; bool m_bBatchMode = false; bool m_bEdit = false; diff --git a/Source/Core/DolphinWX/FrameTools.cpp b/Source/Core/DolphinWX/FrameTools.cpp index 58986f4fe0..218556d739 100644 --- a/Source/Core/DolphinWX/FrameTools.cpp +++ b/Source/Core/DolphinWX/FrameTools.cpp @@ -369,17 +369,18 @@ void CFrame::OnTASInput(wxCommandEvent& event) if (SConfig::GetInstance().m_SIDevice[i] != SerialInterface::SIDEVICE_NONE && SConfig::GetInstance().m_SIDevice[i] != SerialInterface::SIDEVICE_GC_GBA) { - g_TASInputDlg[i]->CreateGCLayout(); - g_TASInputDlg[i]->Show(); - g_TASInputDlg[i]->SetTitle(wxString::Format(_("TAS Input - GameCube Controller %d"), i + 1)); + m_tas_input_dialogs[i]->CreateGCLayout(); + m_tas_input_dialogs[i]->Show(); + m_tas_input_dialogs[i]->SetTitle( + wxString::Format(_("TAS Input - GameCube Controller %d"), i + 1)); } if (g_wiimote_sources[i] == WIIMOTE_SRC_EMU && !(Core::IsRunning() && !SConfig::GetInstance().bWii)) { - g_TASInputDlg[i + 4]->CreateWiiLayout(i); - g_TASInputDlg[i + 4]->Show(); - g_TASInputDlg[i + 4]->SetTitle(wxString::Format(_("TAS Input - Wii Remote %d"), i + 1)); + m_tas_input_dialogs[i + 4]->CreateWiiLayout(i); + m_tas_input_dialogs[i + 4]->Show(); + m_tas_input_dialogs[i + 4]->SetTitle(wxString::Format(_("TAS Input - Wii Remote %d"), i + 1)); } } }