ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

IOS/ES: Drop unnecessary memset for vectors 

IOS doesn't do it, and we don't need it anyway, so let's not do it.
This commit is contained in:
Léo Lam 2017-04-27 00:00:44 +02:00
parent 9fc394f9c7
commit 65d37ee2dc
3 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/Core/IOS/Device.cpp
View File

@ -72,12 +72,6 @@ IOCtlVRequest::IOCtlVRequest(const u32 address_) : Request(address_)
} }
} }
bool IOCtlVRequest::HasInputVectorWithAddress(const u32 vector_address) const
{
return std::any_of(in_vectors.begin(), in_vectors.end(),
[&](const auto& in_vector) { return in_vector.address == vector_address; });
}
bool IOCtlVRequest::HasNumberOfValidVectors(const size_t in_count, const size_t io_count) const bool IOCtlVRequest::HasNumberOfValidVectors(const size_t in_count, const size_t io_count) const
{ {
if (in_vectors.size() != in_count || io_vectors.size() != io_count) if (in_vectors.size() != in_count || io_vectors.size() != io_count)

1
Source/Core/Core/IOS/Device.h
View File

@ -153,7 +153,6 @@ struct IOCtlVRequest final : Request
std::vector<IOVector> in_vectors; std::vector<IOVector> in_vectors;
std::vector<IOVector> io_vectors; std::vector<IOVector> io_vectors;
explicit IOCtlVRequest(u32 address); explicit IOCtlVRequest(u32 address);
bool HasInputVectorWithAddress(u32 vector_address) const;
bool HasNumberOfValidVectors(size_t in_count, size_t io_count) const; bool HasNumberOfValidVectors(size_t in_count, size_t io_count) const;
void Dump(const std::string& description, LogTypes::LOG_TYPE type = LogTypes::IOS, void Dump(const std::string& description, LogTypes::LOG_TYPE type = LogTypes::IOS,
LogTypes::LOG_LEVELS level = LogTypes::LINFO) const; LogTypes::LOG_LEVELS level = LogTypes::LINFO) const;

7
Source/Core/Core/IOS/ES/ES.cpp
View File

@ -345,13 +345,6 @@ IPCCommandResult ES::IOCtlV(const IOCtlVRequest& request)
{ {
DEBUG_LOG(IOS_ES, "%s (0x%x)", GetDeviceName().c_str(), request.request); DEBUG_LOG(IOS_ES, "%s (0x%x)", GetDeviceName().c_str(), request.request);
// Clear the IO buffers. Note that this is unsafe for other ioctlvs.
for (const auto& io_vector : request.io_vectors)
{
if (!request.HasInputVectorWithAddress(io_vector.address))
Memory::Memset(io_vector.address, 0, io_vector.size);
}
switch (request.request) switch (request.request)
{ {
case IOCTL_ES_ADDTICKET: case IOCTL_ES_ADDTICKET: