From ec5d2a4f414cb78a6216145b6d8c151ebc6d1209 Mon Sep 17 00:00:00 2001 From: riidefi <34194588+riidefi@users.noreply.github.com> Date: Wed, 26 Jul 2023 13:01:10 -0600 Subject: [PATCH] [Core] Prevent SD data loss from silent resync failure --- Source/Core/Core/Core.cpp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Source/Core/Core/Core.cpp b/Source/Core/Core/Core.cpp index e8e738854e..2865c81a9d 100644 --- a/Source/Core/Core/Core.cpp +++ b/Source/Core/Core/Core.cpp @@ -535,7 +535,16 @@ static void EmuThread(std::unique_ptr boot, WindowSystemInfo wsi Common::ScopeGuard sd_folder_sync_guard{[sync_sd_folder] { if (sync_sd_folder && Config::Get(Config::MAIN_ALLOW_SD_WRITES)) - Common::SyncSDImageToSDFolder([]() { return false; }); + { + const bool sync_ok = Common::SyncSDImageToSDFolder([]() { return false; }); + if (!sync_ok) + { + PanicAlertFmtT( + "Failed to sync SD card with folder. All changes made this session will be " + "discarded on next boot if you do not manually re-issue a resync in Config > " + "Wii > SD Card Settings > Convert File to Folder Now!"); + } + } }}; // Load Wiimotes - only if we are booting in Wii mode