ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8012 from stenzek/bounding-box-shaders 

PixelShaderGen: Don't emit bounding box shader code for old UIDs when disabled
This commit is contained in:
Connor McLaughlin 2019-04-21 13:27:05 +10:00 committed by GitHub
parent 18589e50ab c6b45c5ca9
commit 5b4ebccf6b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/VideoCommon/PixelShaderGen.cpp
View File

@ -347,6 +347,10 @@ void ClearUnusedPixelShaderUidBits(APIType ApiType, const ShaderHostConfig& host
// uint output when logic op is not supported (i.e. driver/device does not support D3D11.1). // uint output when logic op is not supported (i.e. driver/device does not support D3D11.1).
if (ApiType != APIType::D3D || !host_config.backend_logic_op) if (ApiType != APIType::D3D || !host_config.backend_logic_op)
uid_data->uint_output = 0; uid_data->uint_output = 0;
// If bounding box is enabled when a UID cache is created, then later disabled, we shouldn't
// emit the bounding box portion of the shader.
uid_data->bounding_box &= host_config.bounding_box;
} }
void WritePixelShaderCommonHeader(ShaderCode& out, APIType ApiType, u32 num_texgens, void WritePixelShaderCommonHeader(ShaderCode& out, APIType ApiType, u32 num_texgens,

36
Source/Core/VideoCommon/ShaderCache.cpp
View File

@ -641,17 +641,19 @@ const AbstractPipeline* ShaderCache::InsertGXPipeline(const GXPipelineUid& confi
auto& entry = m_gx_pipeline_cache[config]; auto& entry = m_gx_pipeline_cache[config];
entry.second = false; entry.second = false;
if (!entry.first && pipeline) if (!entry.first && pipeline)
{
entry.first = std::move(pipeline); entry.first = std::move(pipeline);
if (g_ActiveConfig.bShaderCache) if (g_ActiveConfig.bShaderCache)
{
auto cache_data = entry.first->GetCacheData();
if (!cache_data.empty())
{ {
SerializedGXPipelineUid disk_uid; auto cache_data = entry.first->GetCacheData();
SerializePipelineUid(config, disk_uid); if (!cache_data.empty())
m_gx_pipeline_disk_cache.Append(disk_uid, cache_data.data(), {
static_cast<u32>(cache_data.size())); SerializedGXPipelineUid disk_uid;
SerializePipelineUid(config, disk_uid);
m_gx_pipeline_disk_cache.Append(disk_uid, cache_data.data(),
static_cast<u32>(cache_data.size()));
}
} }
} }
@ -665,17 +667,19 @@ ShaderCache::InsertGXUberPipeline(const GXUberPipelineUid& config,
auto& entry = m_gx_uber_pipeline_cache[config]; auto& entry = m_gx_uber_pipeline_cache[config];
entry.second = false; entry.second = false;
if (!entry.first && pipeline) if (!entry.first && pipeline)
{
entry.first = std::move(pipeline); entry.first = std::move(pipeline);
if (g_ActiveConfig.bShaderCache) if (g_ActiveConfig.bShaderCache)
{
auto cache_data = entry.first->GetCacheData();
if (!cache_data.empty())
{ {
SerializedGXUberPipelineUid disk_uid; auto cache_data = entry.first->GetCacheData();
SerializePipelineUid(config, disk_uid); if (!cache_data.empty())
m_gx_uber_pipeline_disk_cache.Append(disk_uid, cache_data.data(), {
static_cast<u32>(cache_data.size())); SerializedGXUberPipelineUid disk_uid;
SerializePipelineUid(config, disk_uid);
m_gx_uber_pipeline_disk_cache.Append(disk_uid, cache_data.data(),
static_cast<u32>(cache_data.size()));
}
} }
} }