ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Common: Fix AsciiToHex returning true on overflow values 

We should be checking errno against ERANGE.
This commit is contained in:
Lioncash 2014-08-12 02:48:52 -04:00
parent 36af1b518d
commit 5afb9cc5c4
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/Common/StringUtil.cpp
View File

@ -28,12 +28,18 @@
// faster than sscanf // faster than sscanf
bool AsciiToHex(const std::string& _szValue, u32& result) bool AsciiToHex(const std::string& _szValue, u32& result)
{ {
// Set errno to a good state.
errno = 0;
char *endptr = nullptr; char *endptr = nullptr;
const u32 value = strtoul(_szValue.c_str(), &endptr, 16); const u32 value = strtoul(_szValue.c_str(), &endptr, 16);
if (!endptr || *endptr) if (!endptr || *endptr)
return false; return false;
if (errno == ERANGE)
return false;
result = value; result = value;
return true; return true;
} }