ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1161 from rohit-n/ogl-vector 

OGL: Use unique_ptr instead of pointer when taking screenshot.
This commit is contained in:
skidau 2014-11-02 14:19:00 +11:00
parent b241b6eadd 2a878d7726
commit 59c673aec6
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Source/Core/VideoBackends/OGL/Render.cpp
View File

@ -1845,17 +1845,15 @@ bool Renderer::SaveScreenshot(const std::string &filename, const TargetRectangle
{ {
u32 W = back_rc.GetWidth(); u32 W = back_rc.GetWidth();
u32 H = back_rc.GetHeight(); u32 H = back_rc.GetHeight();
u8 *data = new u8[W * 4 * H]; std::unique_ptr<u8[]> data(new u8[W * 4 * H]);
glPixelStorei(GL_PACK_ALIGNMENT, 1); glPixelStorei(GL_PACK_ALIGNMENT, 1);
glReadPixels(back_rc.left, back_rc.bottom, W, H, GL_RGBA, GL_UNSIGNED_BYTE, data); glReadPixels(back_rc.left, back_rc.bottom, W, H, GL_RGBA, GL_UNSIGNED_BYTE, data.get());
// Turn image upside down // Turn image upside down
FlipImageData(data, W, H, 4); FlipImageData(data.get(), W, H, 4);
bool success = TextureToPng(data, W*4, filename, W, H, false);
delete[] data;
return success; return TextureToPng(data.get(), W * 4, filename, W, H, false);
} }