diff --git a/Source/Core/DiscIO/VolumeDirectory.cpp b/Source/Core/DiscIO/VolumeDirectory.cpp index e0ab8acd4f..3a9e75f1d2 100644 --- a/Source/Core/DiscIO/VolumeDirectory.cpp +++ b/Source/Core/DiscIO/VolumeDirectory.cpp @@ -152,7 +152,7 @@ std::string CVolumeDirectory::GetUniqueID() const return std::string(m_diskHeader.begin(), m_diskHeader.begin() + ID_LENGTH); } -void CVolumeDirectory::SetUniqueID(std::string id) +void CVolumeDirectory::SetUniqueID(const std::string& id) { size_t length = id.length(); if (length > 6) @@ -178,7 +178,7 @@ std::vector CVolumeDirectory::GetNames() const return std::vector(1, (char*)(&m_diskHeader[0x20])); } -void CVolumeDirectory::SetName(std::string name) +void CVolumeDirectory::SetName(const std::string& name) { size_t length = name.length(); if (length > MAX_NAME_LENGTH) diff --git a/Source/Core/DiscIO/VolumeDirectory.h b/Source/Core/DiscIO/VolumeDirectory.h index f32d628e58..6cfcd90004 100644 --- a/Source/Core/DiscIO/VolumeDirectory.h +++ b/Source/Core/DiscIO/VolumeDirectory.h @@ -36,12 +36,12 @@ public: bool RAWRead(u64 _Offset, u64 _Length, u8* _pBuffer) const override; std::string GetUniqueID() const override; - void SetUniqueID(std::string _ID); + void SetUniqueID(const std::string& _ID); std::string GetMakerID() const override; std::vector GetNames() const override; - void SetName(std::string); + void SetName(const std::string&); u32 GetFSTSize() const override;