From eccec3c6d394aa17ce4faa055458dcecddff6f36 Mon Sep 17 00:00:00 2001 From: EmptyChaos Date: Sat, 10 Sep 2016 04:38:04 +0000 Subject: [PATCH] DiscIO: Fix NAND Memory Leak CNANDContentData is a base class with a non-virtual destructor so derived classes don't get destroyed causing them to leak resources. --- Source/Core/DiscIO/NANDContentLoader.cpp | 2 ++ Source/Core/DiscIO/NANDContentLoader.h | 1 + 2 files changed, 3 insertions(+) diff --git a/Source/Core/DiscIO/NANDContentLoader.cpp b/Source/Core/DiscIO/NANDContentLoader.cpp index 7e108f98e2..98978d98b0 100644 --- a/Source/Core/DiscIO/NANDContentLoader.cpp +++ b/Source/Core/DiscIO/NANDContentLoader.cpp @@ -29,6 +29,8 @@ namespace DiscIO { +CNANDContentData::~CNANDContentData() = default; + CSharedContent::CSharedContent() { UpdateLocation(); diff --git a/Source/Core/DiscIO/NANDContentLoader.h b/Source/Core/DiscIO/NANDContentLoader.h index 50c0eea1e0..71afc4ce39 100644 --- a/Source/Core/DiscIO/NANDContentLoader.h +++ b/Source/Core/DiscIO/NANDContentLoader.h @@ -25,6 +25,7 @@ bool AddTicket(u64 title_id, const std::vector& ticket); class CNANDContentData { public: + virtual ~CNANDContentData() = 0; virtual void Open(){}; virtual const std::vector Get() = 0; virtual bool GetRange(u32 start, u32 size, u8* buffer) = 0;