From 530ea7528e6a43ece73b48d7aa298000b6629002 Mon Sep 17 00:00:00 2001 From: Dentomologist Date: Sat, 2 Aug 2025 15:03:55 -0700 Subject: [PATCH] Host: Remove unnecessary functions Remove Host_RefreshDSPDebuggerWindow (which hasn't done anything since DolphinWX was removed in 44b22c90) and DSP::Host::UpdateDebugger (which only called Host_RefreshDSPDebuggerWindow). --- Source/Android/jni/MainAndroid.cpp | 4 ---- Source/Core/Core/DSP/DSPCore.cpp | 4 ---- Source/Core/Core/DSP/DSPHost.h | 1 - Source/Core/Core/HW/DSPLLE/DSPHost.cpp | 7 ------- Source/Core/Core/HW/DSPLLE/DSPLLE.cpp | 1 - Source/Core/Core/Host.h | 1 - Source/Core/DolphinNoGUI/MainNoGUI.cpp | 4 ---- Source/Core/DolphinQt/Host.cpp | 4 ---- Source/Core/DolphinTool/ToolHeadlessPlatform.cpp | 4 ---- Source/DSPTool/DSPTool.cpp | 3 --- Source/DSPTool/StubHost.cpp | 3 --- Source/UnitTests/StubHost.cpp | 3 --- 12 files changed, 39 deletions(-) diff --git a/Source/Android/jni/MainAndroid.cpp b/Source/Android/jni/MainAndroid.cpp index 0380ade0b8..646f745a13 100644 --- a/Source/Android/jni/MainAndroid.cpp +++ b/Source/Android/jni/MainAndroid.cpp @@ -110,10 +110,6 @@ void Host_PPCBreakpointsChanged() { } -void Host_RefreshDSPDebuggerWindow() -{ -} - bool Host_UIBlocksControllerState() { return false; diff --git a/Source/Core/Core/DSP/DSPCore.cpp b/Source/Core/Core/DSP/DSPCore.cpp index 41c10b2428..861c0cac23 100644 --- a/Source/Core/Core/DSP/DSPCore.cpp +++ b/Source/Core/Core/DSP/DSPCore.cpp @@ -482,8 +482,6 @@ int DSPCore::RunCycles(int cycles) m_dsp_interpreter->Step(); cycles--; - - Host::UpdateDebugger(); break; case State::Stopped: break; @@ -519,8 +517,6 @@ void DSPCore::SetState(State new_state) // kick the event, in case we are waiting if (new_state == State::Running) m_step_event.Set(); - - Host::UpdateDebugger(); } State DSPCore::GetState() const diff --git a/Source/Core/Core/DSP/DSPHost.h b/Source/Core/Core/DSP/DSPHost.h index 431e24d15a..346feb0d95 100644 --- a/Source/Core/Core/DSP/DSPHost.h +++ b/Source/Core/Core/DSP/DSPHost.h @@ -29,5 +29,4 @@ bool IsWiiHost(); void InterruptRequest(); void CodeLoaded(DSPCore& dsp, u32 addr, size_t size); void CodeLoaded(DSPCore& dsp, const u8* ptr, size_t size); -void UpdateDebugger(); } // namespace DSP::Host diff --git a/Source/Core/Core/HW/DSPLLE/DSPHost.cpp b/Source/Core/Core/HW/DSPLLE/DSPHost.cpp index 39507c98fe..75f321518f 100644 --- a/Source/Core/Core/HW/DSPLLE/DSPHost.cpp +++ b/Source/Core/Core/HW/DSPLLE/DSPHost.cpp @@ -96,14 +96,7 @@ void CodeLoaded(DSPCore& dsp, const u8* ptr, size_t size) Symbols::AutoDisassembly(state, 0x0, 0x1000); Symbols::AutoDisassembly(state, 0x8000, 0x9000); - UpdateDebugger(); - dsp.ClearIRAM(); state.GetAnalyzer().Analyze(state); } - -void UpdateDebugger() -{ - Host_RefreshDSPDebuggerWindow(); -} } // namespace DSP::Host diff --git a/Source/Core/Core/HW/DSPLLE/DSPLLE.cpp b/Source/Core/Core/HW/DSPLLE/DSPLLE.cpp index 7b3abdb14e..9925dd5354 100644 --- a/Source/Core/Core/HW/DSPLLE/DSPLLE.cpp +++ b/Source/Core/Core/HW/DSPLLE/DSPLLE.cpp @@ -161,7 +161,6 @@ bool DSPLLE::Initialize(bool wii, bool dsp_thread) m_dsp_thread = std::thread(DSPThread, this); } - Host_RefreshDSPDebuggerWindow(); return true; } diff --git a/Source/Core/Core/Host.h b/Source/Core/Core/Host.h index 8ddbbbaefb..a05508bae2 100644 --- a/Source/Core/Core/Host.h +++ b/Source/Core/Core/Host.h @@ -58,7 +58,6 @@ bool Host_TASInputHasFocus(); void Host_Message(HostMessageID id); void Host_PPCSymbolsChanged(); void Host_PPCBreakpointsChanged(); -void Host_RefreshDSPDebuggerWindow(); void Host_RequestRenderWindowSize(int width, int height); void Host_UpdateDisasmDialog(); void Host_JitCacheInvalidation(); diff --git a/Source/Core/DolphinNoGUI/MainNoGUI.cpp b/Source/Core/DolphinNoGUI/MainNoGUI.cpp index a09a2060fd..6132085b15 100644 --- a/Source/Core/DolphinNoGUI/MainNoGUI.cpp +++ b/Source/Core/DolphinNoGUI/MainNoGUI.cpp @@ -61,10 +61,6 @@ void Host_PPCBreakpointsChanged() { } -void Host_RefreshDSPDebuggerWindow() -{ -} - bool Host_UIBlocksControllerState() { return false; diff --git a/Source/Core/DolphinQt/Host.cpp b/Source/Core/DolphinQt/Host.cpp index 0dcc9b3b2c..49612b1cda 100644 --- a/Source/Core/DolphinQt/Host.cpp +++ b/Source/Core/DolphinQt/Host.cpp @@ -293,10 +293,6 @@ bool Host_UIBlocksControllerState() Core::GetState(Core::System::GetInstance()) != Core::State::Paused; } -void Host_RefreshDSPDebuggerWindow() -{ -} - void Host_TitleChanged() { #ifdef USE_DISCORD_PRESENCE diff --git a/Source/Core/DolphinTool/ToolHeadlessPlatform.cpp b/Source/Core/DolphinTool/ToolHeadlessPlatform.cpp index 83cc16d805..787209bd3e 100644 --- a/Source/Core/DolphinTool/ToolHeadlessPlatform.cpp +++ b/Source/Core/DolphinTool/ToolHeadlessPlatform.cpp @@ -29,10 +29,6 @@ void Host_PPCBreakpointsChanged() { } -void Host_RefreshDSPDebuggerWindow() -{ -} - bool Host_UIBlocksControllerState() { return false; diff --git a/Source/DSPTool/DSPTool.cpp b/Source/DSPTool/DSPTool.cpp index 2f99d56522..9deaa2920f 100644 --- a/Source/DSPTool/DSPTool.cpp +++ b/Source/DSPTool/DSPTool.cpp @@ -49,9 +49,6 @@ void DSP::Host::CodeLoaded(DSPCore& dsp, const u8* ptr, size_t size) void DSP::Host::InterruptRequest() { } -void DSP::Host::UpdateDebugger() -{ -} static std::string CodeToHeader(const std::vector& code, const std::string& filename) { diff --git a/Source/DSPTool/StubHost.cpp b/Source/DSPTool/StubHost.cpp index 12fa967516..df4ac59d2b 100644 --- a/Source/DSPTool/StubHost.cpp +++ b/Source/DSPTool/StubHost.cpp @@ -19,9 +19,6 @@ void Host_PPCSymbolsChanged() void Host_PPCBreakpointsChanged() { } -void Host_RefreshDSPDebuggerWindow() -{ -} void Host_Message(HostMessageID) { } diff --git a/Source/UnitTests/StubHost.cpp b/Source/UnitTests/StubHost.cpp index 3d980ee302..bd87bba095 100644 --- a/Source/UnitTests/StubHost.cpp +++ b/Source/UnitTests/StubHost.cpp @@ -19,9 +19,6 @@ void Host_PPCSymbolsChanged() void Host_PPCBreakpointsChanged() { } -void Host_RefreshDSPDebuggerWindow() -{ -} void Host_Message(HostMessageID) { }