diff --git a/Source/Core/Common/IniFile.cpp b/Source/Core/Common/IniFile.cpp index ab20ff58fd..a7ce26976b 100644 --- a/Source/Core/Common/IniFile.cpp +++ b/Source/Core/Common/IniFile.cpp @@ -130,7 +130,7 @@ const IniFile::Section* IniFile::GetSection(std::string_view section_name) const { for (const Section& sect : sections) { - if (CaseInsensitiveStringCompare::IsEqual(sect.name, section_name)) + if (CaseInsensitiveEquals(sect.name, section_name)) return § } @@ -141,7 +141,7 @@ IniFile::Section* IniFile::GetSection(std::string_view section_name) { for (Section& sect : sections) { - if (CaseInsensitiveStringCompare::IsEqual(sect.name, section_name)) + if (CaseInsensitiveEquals(sect.name, section_name)) return § } diff --git a/Source/Core/Common/IniFile.h b/Source/Core/Common/IniFile.h index c37be55f43..31a7ee0e6b 100644 --- a/Source/Core/Common/IniFile.h +++ b/Source/Core/Common/IniFile.h @@ -15,29 +15,6 @@ namespace Common { -struct CaseInsensitiveStringCompare -{ - // Allow heterogenous lookup. - using is_transparent = void; - - bool operator()(std::string_view a, std::string_view b) const - { - return std::lexicographical_compare( - a.begin(), a.end(), b.begin(), b.end(), - [](char lhs, char rhs) { return Common::ToLower(lhs) < Common::ToLower(rhs); }); - } - - static bool IsEqual(std::string_view a, std::string_view b) - { - if (a.size() != b.size()) - return false; - - return std::equal(a.begin(), a.end(), b.begin(), b.end(), [](char lhs, char rhs) { - return Common::ToLower(lhs) == Common::ToLower(rhs); - }); - } -}; - class IniFile { public: @@ -86,7 +63,7 @@ public: bool GetLines(std::vector* lines, const bool remove_comments = true) const; bool operator<(const Section& other) const { return name < other.name; } - using SectionMap = std::map; + using SectionMap = std::map; const std::string& GetName() const { return name; } const SectionMap& GetValues() const { return values; } diff --git a/Source/Core/Common/StringUtil.cpp b/Source/Core/Common/StringUtil.cpp index 513a880cd7..41ed8e11fc 100644 --- a/Source/Core/Common/StringUtil.cpp +++ b/Source/Core/Common/StringUtil.cpp @@ -681,10 +681,14 @@ void ToUpper(std::string* str) bool CaseInsensitiveEquals(std::string_view a, std::string_view b) { - if (a.size() != b.size()) - return false; - return std::equal(a.begin(), a.end(), b.begin(), - [](char ca, char cb) { return Common::ToLower(ca) == Common::ToLower(cb); }); + return std::ranges::equal( + a, b, [](char ca, char cb) { return Common::ToLower(ca) == Common::ToLower(cb); }); +} + +bool CaseInsensitiveLess::operator()(std::string_view a, std::string_view b) const +{ + return std::ranges::lexicographical_compare( + a, b, [](char ca, char cb) { return Common::ToLower(ca) < Common::ToLower(cb); }); } std::string BytesToHexString(std::span bytes) diff --git a/Source/Core/Common/StringUtil.h b/Source/Core/Common/StringUtil.h index c1eaf94ad4..ef7597a1e5 100644 --- a/Source/Core/Common/StringUtil.h +++ b/Source/Core/Common/StringUtil.h @@ -314,5 +314,13 @@ std::string GetEscapedHtml(std::string html); void ToLower(std::string* str); void ToUpper(std::string* str); bool CaseInsensitiveEquals(std::string_view a, std::string_view b); + +// 'std::less'-like comparison function object type for case-insensitive strings. +struct CaseInsensitiveLess +{ + using is_transparent = void; // Allow heterogenous lookup. + bool operator()(std::string_view a, std::string_view b) const; +}; + std::string BytesToHexString(std::span bytes); } // namespace Common