ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BPMemory: Clean up and rename some variables and comments 

This is about the register number, not the opcode.
This commit is contained in:
Jasper St. Pierre 2014-05-03 14:55:13 -04:00
parent e81b62aad1
commit 4f4e3fad85
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Source/Core/VideoCommon/BPMemory.cpp
View File

@ -15,16 +15,15 @@ void BPWritten(const BPCmd& bp);
// Call browser: OpcodeDecoding.cpp ExecuteDisplayList > Decode() > LoadBPReg() // Call browser: OpcodeDecoding.cpp ExecuteDisplayList > Decode() > LoadBPReg()
void LoadBPReg(u32 value0) void LoadBPReg(u32 value0)
{ {
//handle the mask register int regNum = value0 >> 24;
int opcode = value0 >> 24; int oldval = ((u32*)&bpmem)[regNum];
int oldval = ((u32*)&bpmem)[opcode];
int newval = (oldval & ~bpmem.bpMask) | (value0 & bpmem.bpMask); int newval = (oldval & ~bpmem.bpMask) | (value0 & bpmem.bpMask);
int changes = (oldval ^ newval) & 0xFFFFFF; int changes = (oldval ^ newval) & 0xFFFFFF;
BPCmd bp = {opcode, changes, newval}; BPCmd bp = {regNum, changes, newval};
//reset the mask register // Reset the mask register if we're not trying to set it ourselves.
if (opcode != 0xFE) if (regNum != BPMEM_BP_MASK)
bpmem.bpMask = 0xFFFFFF; bpmem.bpMask = 0xFFFFFF;
BPWritten(bp); BPWritten(bp);