From 84808d2e358e08b4da78363a38abb37ad96fc835 Mon Sep 17 00:00:00 2001 From: Michael Maltese Date: Thu, 15 Jun 2017 17:09:17 -0700 Subject: [PATCH 1/3] DSPCore: update free DSP ROM message for GBA ucode support The GBA ucode is supported as of #5524 / d51be94. --- Source/Core/Core/DSP/DSPCore.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Source/Core/Core/DSP/DSPCore.cpp b/Source/Core/Core/DSP/DSPCore.cpp index a4ae8254f6..0d06a26661 100644 --- a/Source/Core/Core/DSP/DSPCore.cpp +++ b/Source/Core/Core/DSP/DSPCore.cpp @@ -88,6 +88,12 @@ static bool VerifyRoms() Host::OSD_AddMessage("All Wii games will work correctly, and most GC games should ", 8000); Host::OSD_AddMessage("also work fine, but the GBA/IPL/CARD UCodes will not work.", 8000); } + else if (rom_idx == 4) + { + Host::OSD_AddMessage("You are using a free DSP ROM made by the Dolphin Team.", 8000); + Host::OSD_AddMessage("All Wii games will work correctly, and most GC games should ", 8000); + Host::OSD_AddMessage("also work fine, but the IPL and CARD UCodes will not work.", 8000); + } return true; } From 9de2934aae058cb30d8de7394f44c20a66274f90 Mon Sep 17 00:00:00 2001 From: Michael Maltese Date: Sun, 18 Jun 2017 15:36:55 -0700 Subject: [PATCH 2/3] DSPCore: remove message that the free ROM doesn't work with IPL The GameCube IPL sounds the same when using the free ROM as it does when using the official ROM (and in Audacity, I couldn't visually distinguish between the waveforms). It has a reference to an unimplemented function at 0x8644 which seems to only be used in an inlined version of the CARD ucode. --- Source/Core/Core/DSP/DSPCore.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Core/Core/DSP/DSPCore.cpp b/Source/Core/Core/DSP/DSPCore.cpp index 0d06a26661..3e80856f26 100644 --- a/Source/Core/Core/DSP/DSPCore.cpp +++ b/Source/Core/Core/DSP/DSPCore.cpp @@ -86,13 +86,13 @@ static bool VerifyRoms() { Host::OSD_AddMessage("You are using a free DSP ROM made by the Dolphin Team.", 8000); Host::OSD_AddMessage("All Wii games will work correctly, and most GC games should ", 8000); - Host::OSD_AddMessage("also work fine, but the GBA/IPL/CARD UCodes will not work.", 8000); + Host::OSD_AddMessage("also work fine, but the GBA/CARD UCodes will not work.", 8000); } else if (rom_idx == 4) { Host::OSD_AddMessage("You are using a free DSP ROM made by the Dolphin Team.", 8000); Host::OSD_AddMessage("All Wii games will work correctly, and most GC games should ", 8000); - Host::OSD_AddMessage("also work fine, but the IPL and CARD UCodes will not work.", 8000); + Host::OSD_AddMessage("also work fine, but the CARD UCode will not work.", 8000); } return true; From f7e2b8dab75bcd514d3e0c0c54b0f86981bbc949 Mon Sep 17 00:00:00 2001 From: Michael Maltese Date: Sun, 18 Jun 2017 15:41:38 -0700 Subject: [PATCH 3/3] DSPCore: replace 'GC' with 'GameCube' in messages --- Source/Core/Core/DSP/DSPCore.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Source/Core/Core/DSP/DSPCore.cpp b/Source/Core/Core/DSP/DSPCore.cpp index 3e80856f26..befda9fcda 100644 --- a/Source/Core/Core/DSP/DSPCore.cpp +++ b/Source/Core/Core/DSP/DSPCore.cpp @@ -85,14 +85,14 @@ static bool VerifyRoms() else if (rom_idx == 2 || rom_idx == 3) { Host::OSD_AddMessage("You are using a free DSP ROM made by the Dolphin Team.", 8000); - Host::OSD_AddMessage("All Wii games will work correctly, and most GC games should ", 8000); - Host::OSD_AddMessage("also work fine, but the GBA/CARD UCodes will not work.", 8000); + Host::OSD_AddMessage("All Wii games will work correctly, and most GameCube games", 8000); + Host::OSD_AddMessage("should also work fine, but the GBA/CARD UCodes will not work.", 8000); } else if (rom_idx == 4) { Host::OSD_AddMessage("You are using a free DSP ROM made by the Dolphin Team.", 8000); - Host::OSD_AddMessage("All Wii games will work correctly, and most GC games should ", 8000); - Host::OSD_AddMessage("also work fine, but the CARD UCode will not work.", 8000); + Host::OSD_AddMessage("All Wii games will work correctly, and most GameCube games", 8000); + Host::OSD_AddMessage("should also work fine, but the CARD UCode will not work.", 8000); } return true;