From 1ed41672f50c9cfe7aa4ab5aa3b73f7e41029124 Mon Sep 17 00:00:00 2001 From: degasus Date: Sun, 28 Dec 2014 21:46:00 +0100 Subject: [PATCH] OGL: disable driver warnings fetch This did give a decent slowdown on some drivers. --- Source/Core/Common/Logging/LogManager.h | 4 +-- Source/Core/VideoBackends/OGL/Render.cpp | 35 +++++++++++++++++------- Source/Core/VideoBackends/OGL/Render.h | 1 + 3 files changed, 28 insertions(+), 12 deletions(-) diff --git a/Source/Core/Common/Logging/LogManager.h b/Source/Core/Common/Logging/LogManager.h index 0809fec759..fda5f16865 100644 --- a/Source/Core/Common/Logging/LogManager.h +++ b/Source/Core/Common/Logging/LogManager.h @@ -111,9 +111,9 @@ public: m_Log[type]->SetEnable(enable); } - bool IsEnabled(LogTypes::LOG_TYPE type) const + bool IsEnabled(LogTypes::LOG_TYPE type, LogTypes::LOG_LEVELS level = LogTypes::LNOTICE) const { - return m_Log[type]->IsEnabled(); + return m_Log[type]->IsEnabled() && m_Log[type]->GetLevel() >= level; } std::string GetShortName(LogTypes::LOG_TYPE type) const diff --git a/Source/Core/VideoBackends/OGL/Render.cpp b/Source/Core/VideoBackends/OGL/Render.cpp index 2def435a11..e4dcca32ff 100644 --- a/Source/Core/VideoBackends/OGL/Render.cpp +++ b/Source/Core/VideoBackends/OGL/Render.cpp @@ -15,6 +15,7 @@ #include "Common/StringUtil.h" #include "Common/Thread.h" #include "Common/Timer.h" +#include "Common/Logging/LogManager.h" #include "Core/ConfigManager.h" #include "Core/Core.h" @@ -479,6 +480,7 @@ Renderer::Renderer() g_ogl_config.bSupportSampleShading = GLExtensions::Supports("GL_ARB_sample_shading"); g_ogl_config.bSupportOGL31 = GLExtensions::Version() >= 310; g_ogl_config.bSupportViewportFloat = GLExtensions::Supports("GL_ARB_viewport_array"); + g_ogl_config.bSupportsDebug = GLExtensions::Supports("GL_KHR_debug") || GLExtensions::Supports("GL_ARB_debug_output"); if (GLInterface->GetMode() == GLInterfaceMode::MODE_OPENGLES3) { @@ -527,17 +529,22 @@ Renderer::Renderer() g_ogl_config.bSupportsAEP = false; } - if (GLExtensions::Supports("GL_KHR_debug")) + if (g_ogl_config.bSupportsDebug) { - glDebugMessageControl(GL_DONT_CARE, GL_DONT_CARE, GL_DONT_CARE, 0, nullptr, true); - glDebugMessageCallback( ErrorCallback, nullptr ); - glEnable( GL_DEBUG_OUTPUT ); - } - else if (GLExtensions::Supports("GL_ARB_debug_output")) - { - glDebugMessageControlARB(GL_DONT_CARE, GL_DONT_CARE, GL_DONT_CARE, 0, nullptr, true); - glDebugMessageCallbackARB( ErrorCallback, nullptr ); - glEnable( GL_DEBUG_OUTPUT ); + if (GLExtensions::Supports("GL_KHR_debug")) + { + glDebugMessageControl(GL_DONT_CARE, GL_DONT_CARE, GL_DONT_CARE, 0, nullptr, true); + glDebugMessageCallback(ErrorCallback, nullptr); + } + else + { + glDebugMessageControlARB(GL_DONT_CARE, GL_DONT_CARE, GL_DONT_CARE, 0, nullptr, true); + glDebugMessageCallbackARB(ErrorCallback, nullptr); + } + if (LogManager::GetInstance()->IsEnabled(LogTypes::VIDEO, LogTypes::LERROR)) + glEnable(GL_DEBUG_OUTPUT); + else + glDisable(GL_DEBUG_OUTPUT); } int samples; @@ -1416,6 +1423,14 @@ static void DumpFrame(const std::vector& data, int w, int h) // This function has the final picture. We adjust the aspect ratio here. void Renderer::SwapImpl(u32 xfbAddr, u32 fbWidth, u32 fbStride, u32 fbHeight, const EFBRectangle& rc, float Gamma) { + if (g_ogl_config.bSupportsDebug) + { + if (LogManager::GetInstance()->IsEnabled(LogTypes::VIDEO, LogTypes::LERROR)) + glEnable(GL_DEBUG_OUTPUT); + else + glDisable(GL_DEBUG_OUTPUT); + } + static int w = 0, h = 0; if (g_bSkipCurrentFrame || (!XFBWrited && !g_ActiveConfig.RealXFBEnabled()) || !fbWidth || !fbHeight) { diff --git a/Source/Core/VideoBackends/OGL/Render.h b/Source/Core/VideoBackends/OGL/Render.h index cfa01a2e6f..c3f7e59ae4 100644 --- a/Source/Core/VideoBackends/OGL/Render.h +++ b/Source/Core/VideoBackends/OGL/Render.h @@ -31,6 +31,7 @@ struct VideoConfig bool bSupportOGL31; bool bSupportViewportFloat; bool bSupportsAEP; + bool bSupportsDebug; const char* gl_vendor; const char* gl_renderer;