FloatUtils: Remove using namespace std in ApproximateReciprocal()

This was made quite a long time ago when we supported 32-bit ARM targets
This commit is contained in:
Lioncash 2018-05-09 09:36:17 -04:00
parent 5cd02f0853
commit 46a4243d9a
1 changed files with 4 additions and 10 deletions

View File

@ -167,12 +167,6 @@ const std::array<BaseAndDec, 32> fres_expected = {{
// Used by fres and ps_res. // Used by fres and ps_res.
double ApproximateReciprocal(double val) double ApproximateReciprocal(double val)
{ {
// We are using namespace std scoped here because the Android NDK is complete trash as usual
// For 32bit targets(mips, ARMv7, x86) it doesn't provide an implementation of std::copysign
// but instead provides just global namespace copysign implementations.
// The workaround for this is to just use namespace std within this function's scope
// That way on real toolchains it will use the std:: variant like normal.
using namespace std;
union union
{ {
double valf; double valf;
@ -186,23 +180,23 @@ double ApproximateReciprocal(double val)
// Special case 0 // Special case 0
if (mantissa == 0 && exponent == 0) if (mantissa == 0 && exponent == 0)
return copysign(std::numeric_limits<double>::infinity(), valf); return std::copysign(std::numeric_limits<double>::infinity(), valf);
// Special case NaN-ish numbers // Special case NaN-ish numbers
if (exponent == (0x7FFLL << 52)) if (exponent == (0x7FFLL << 52))
{ {
if (mantissa == 0) if (mantissa == 0)
return copysign(0.0, valf); return std::copysign(0.0, valf);
return 0.0 + valf; return 0.0 + valf;
} }
// Special case small inputs // Special case small inputs
if (exponent < (895LL << 52)) if (exponent < (895LL << 52))
return copysign(std::numeric_limits<float>::max(), valf); return std::copysign(std::numeric_limits<float>::max(), valf);
// Special case large inputs // Special case large inputs
if (exponent >= (1149LL << 52)) if (exponent >= (1149LL << 52))
return copysign(0.0, valf); return std::copysign(0.0, valf);
exponent = (0x7FDLL << 52) - exponent; exponent = (0x7FDLL << 52) - exponent;