ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request from AdmiralCurtiss/getstringt 

VolumeVerifier: Add missing assignment to summary_text, and prevent such errors in the future by adding [[nodiscard]] to GetStringT().
This commit is contained in:
JosJuice 2022-09-23 17:42:27 +02:00 committed by GitHub
parent b314e2a313 9860b68b9c
commit 3ee4c6a33b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Source/Core
Common
MsgHandler.h
DiscIO
VolumeVerifier.cpp

2
Source/Core/Common/MsgHandler.h
View File

@ -29,7 +29,7 @@ using StringTranslator = std::string (*)(const char* text);
void RegisterMsgAlertHandler(MsgAlertHandler handler); void RegisterMsgAlertHandler(MsgAlertHandler handler);
void RegisterStringTranslator(StringTranslator translator); void RegisterStringTranslator(StringTranslator translator);
std::string GetStringT(const char* string); [[nodiscard]] std::string GetStringT(const char* string);
bool MsgAlertFmtImpl(bool yes_no, MsgType style, Common::Log::LogType log_type, const char* file, bool MsgAlertFmtImpl(bool yes_no, MsgType style, Common::Log::LogType log_type, const char* file,
int line, fmt::string_view format, const fmt::format_args& args); int line, fmt::string_view format, const fmt::format_args& args);

5
Source/Core/DiscIO/VolumeVerifier.cpp
View File

@ -1432,8 +1432,9 @@ void VolumeVerifier::Finish()
} }
else else
{ {
Common::GetStringT("Problems with low severity were found. They will most " m_result.summary_text =
"likely not prevent the game from running."); Common::GetStringT("Problems with low severity were found. They will most "
"likely not prevent the game from running.");
} }
break; break;
case Severity::Medium: case Severity::Medium: