From 3a66f2c008296e5b68926591d95a643ff44b0e6c Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 29 Jan 2017 22:32:04 -0500 Subject: [PATCH] ControllerEmu: Move into its own directory ControllerEmu is a massive class with a lot of nested public classes. The only reason these are nested is because the outer class acts as a namespace. There's no reason to keep these classes nested just for that. Keeping these classes nested makes it impossible to forward declare them, which leads to quite a few includes in other headers, making compilation take longer. This moves the source files to their own directory so classes can be separated as necessary to their own source files, and be namespaced under the ControllerEmu namespace. --- Source/Core/Core/Analytics.cpp | 2 +- Source/Core/Core/HW/GCKeyboard.h | 2 +- Source/Core/Core/HW/GCKeyboardEmu.cpp | 2 +- Source/Core/Core/HW/GCKeyboardEmu.h | 2 +- Source/Core/Core/HW/GCPad.h | 2 +- Source/Core/Core/HW/GCPadEmu.h | 2 +- Source/Core/Core/HW/Wiimote.h | 2 +- .../Core/Core/HW/WiimoteEmu/Attachment/Attachment.h | 2 +- Source/Core/Core/HW/WiimoteEmu/WiimoteEmu.h | 2 +- Source/Core/Core/HotkeyManager.h | 2 +- Source/Core/DolphinWX/Input/InputConfigDiag.cpp | 2 +- Source/Core/DolphinWX/Input/InputConfigDiag.h | 2 +- .../Core/DolphinWX/Input/InputConfigDiagBitmaps.cpp | 2 +- Source/Core/InputCommon/CMakeLists.txt | 4 ++-- .../{ => ControllerEmu}/ControllerEmu.cpp | 2 +- .../InputCommon/{ => ControllerEmu}/ControllerEmu.h | 0 Source/Core/InputCommon/InputCommon.vcxproj | 4 ++-- Source/Core/InputCommon/InputCommon.vcxproj.filters | 13 ++++++++++--- Source/Core/InputCommon/InputConfig.cpp | 2 +- 19 files changed, 29 insertions(+), 22 deletions(-) rename Source/Core/InputCommon/{ => ControllerEmu}/ControllerEmu.cpp (99%) rename Source/Core/InputCommon/{ => ControllerEmu}/ControllerEmu.h (100%) diff --git a/Source/Core/Core/Analytics.cpp b/Source/Core/Core/Analytics.cpp index 4d2dcd8e41..6d628cd582 100644 --- a/Source/Core/Core/Analytics.cpp +++ b/Source/Core/Core/Analytics.cpp @@ -21,7 +21,7 @@ #include "Core/HW/GCPad.h" #include "Core/Movie.h" #include "Core/NetPlayProto.h" -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" #include "InputCommon/GCAdapter.h" #include "InputCommon/InputConfig.h" #include "VideoCommon/VideoBackendBase.h" diff --git a/Source/Core/Core/HW/GCKeyboard.h b/Source/Core/Core/HW/GCKeyboard.h index 6f254a9a85..c968e2bae2 100644 --- a/Source/Core/Core/HW/GCKeyboard.h +++ b/Source/Core/Core/HW/GCKeyboard.h @@ -5,7 +5,7 @@ #pragma once #include "Common/CommonTypes.h" -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" class InputConfig; enum class KeyboardGroup; diff --git a/Source/Core/Core/HW/GCKeyboardEmu.cpp b/Source/Core/Core/HW/GCKeyboardEmu.cpp index f31dca91ca..067cd996d3 100644 --- a/Source/Core/Core/HW/GCKeyboardEmu.cpp +++ b/Source/Core/Core/HW/GCKeyboardEmu.cpp @@ -4,7 +4,7 @@ #include "Core/HW/GCKeyboardEmu.h" #include "Common/Common.h" -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" #include "InputCommon/KeyboardStatus.h" static const u16 keys0_bitmasks[] = {KEYMASK_HOME, KEYMASK_END, KEYMASK_PGUP, KEYMASK_PGDN, diff --git a/Source/Core/Core/HW/GCKeyboardEmu.h b/Source/Core/Core/HW/GCKeyboardEmu.h index d1729e6a9b..cf6cfd7e9d 100644 --- a/Source/Core/Core/HW/GCKeyboardEmu.h +++ b/Source/Core/Core/HW/GCKeyboardEmu.h @@ -6,7 +6,7 @@ #include -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" struct KeyboardStatus; diff --git a/Source/Core/Core/HW/GCPad.h b/Source/Core/Core/HW/GCPad.h index b330f44170..28917da35e 100644 --- a/Source/Core/Core/HW/GCPad.h +++ b/Source/Core/Core/HW/GCPad.h @@ -5,7 +5,7 @@ #pragma once #include "Common/CommonTypes.h" -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" #include "InputCommon/ControllerInterface/Device.h" class InputConfig; diff --git a/Source/Core/Core/HW/GCPadEmu.h b/Source/Core/Core/HW/GCPadEmu.h index a239c299b5..cc51d60db0 100644 --- a/Source/Core/Core/HW/GCPadEmu.h +++ b/Source/Core/Core/HW/GCPadEmu.h @@ -6,7 +6,7 @@ #include -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" class ControlGroup; diff --git a/Source/Core/Core/HW/Wiimote.h b/Source/Core/Core/HW/Wiimote.h index 3f1dd1db06..668096265d 100644 --- a/Source/Core/Core/HW/Wiimote.h +++ b/Source/Core/Core/HW/Wiimote.h @@ -6,7 +6,7 @@ #include "Common/Common.h" #include "Common/CommonTypes.h" -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" class InputConfig; class PointerWrap; diff --git a/Source/Core/Core/HW/WiimoteEmu/Attachment/Attachment.h b/Source/Core/Core/HW/WiimoteEmu/Attachment/Attachment.h index 7d5361795a..caec32754a 100644 --- a/Source/Core/Core/HW/WiimoteEmu/Attachment/Attachment.h +++ b/Source/Core/Core/HW/WiimoteEmu/Attachment/Attachment.h @@ -7,7 +7,7 @@ #include #include #include "Common/CommonTypes.h" -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" namespace WiimoteEmu { diff --git a/Source/Core/Core/HW/WiimoteEmu/WiimoteEmu.h b/Source/Core/Core/HW/WiimoteEmu/WiimoteEmu.h index 11719ad1ee..a32433ec44 100644 --- a/Source/Core/Core/HW/WiimoteEmu/WiimoteEmu.h +++ b/Source/Core/Core/HW/WiimoteEmu/WiimoteEmu.h @@ -9,7 +9,7 @@ #include "Core/HW/WiimoteEmu/Encryption.h" #include "Core/HW/WiimoteEmu/WiimoteHid.h" -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" // Registry sizes #define WIIMOTE_EEPROM_SIZE (16 * 1024) diff --git a/Source/Core/Core/HotkeyManager.h b/Source/Core/Core/HotkeyManager.h index 629d033e5b..e002c48d54 100644 --- a/Source/Core/Core/HotkeyManager.h +++ b/Source/Core/Core/HotkeyManager.h @@ -7,7 +7,7 @@ #include #include -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" #include "InputCommon/InputConfig.h" enum Hotkey diff --git a/Source/Core/DolphinWX/Input/InputConfigDiag.cpp b/Source/Core/DolphinWX/Input/InputConfigDiag.cpp index ed71fd1b3f..b9e93553b3 100644 --- a/Source/Core/DolphinWX/Input/InputConfigDiag.cpp +++ b/Source/Core/DolphinWX/Input/InputConfigDiag.cpp @@ -52,7 +52,7 @@ #include "DolphinWX/Input/NunchukInputConfigDiag.h" #include "DolphinWX/Input/TurntableInputConfigDiag.h" #include "DolphinWX/WxUtils.h" -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" #include "InputCommon/ControllerInterface/ControllerInterface.h" #include "InputCommon/ControllerInterface/Device.h" #include "InputCommon/ControllerInterface/ExpressionParser.h" diff --git a/Source/Core/DolphinWX/Input/InputConfigDiag.h b/Source/Core/DolphinWX/Input/InputConfigDiag.h index 74d22065cf..09c2a011d1 100644 --- a/Source/Core/DolphinWX/Input/InputConfigDiag.h +++ b/Source/Core/DolphinWX/Input/InputConfigDiag.h @@ -23,7 +23,7 @@ #include #include -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" #include "InputCommon/ControllerInterface/ControllerInterface.h" #include "InputCommon/ControllerInterface/Device.h" diff --git a/Source/Core/DolphinWX/Input/InputConfigDiagBitmaps.cpp b/Source/Core/DolphinWX/Input/InputConfigDiagBitmaps.cpp index f531e8c1a0..57f2d892a2 100644 --- a/Source/Core/DolphinWX/Input/InputConfigDiagBitmaps.cpp +++ b/Source/Core/DolphinWX/Input/InputConfigDiagBitmaps.cpp @@ -22,7 +22,7 @@ #include "DolphinWX/Input/InputConfigDiag.h" #include "DolphinWX/WxUtils.h" -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" #include "InputCommon/ControllerInterface/ControllerInterface.h" #include "InputCommon/ControllerInterface/Device.h" diff --git a/Source/Core/InputCommon/CMakeLists.txt b/Source/Core/InputCommon/CMakeLists.txt index bc56dbe4f7..24559b9e30 100644 --- a/Source/Core/InputCommon/CMakeLists.txt +++ b/Source/Core/InputCommon/CMakeLists.txt @@ -1,5 +1,5 @@ -set(SRCS ControllerEmu.cpp - InputConfig.cpp +set(SRCS InputConfig.cpp + ControllerEmu/ControllerEmu.cpp ControllerInterface/ControllerInterface.cpp ControllerInterface/Device.cpp ControllerInterface/ExpressionParser.cpp) diff --git a/Source/Core/InputCommon/ControllerEmu.cpp b/Source/Core/InputCommon/ControllerEmu/ControllerEmu.cpp similarity index 99% rename from Source/Core/InputCommon/ControllerEmu.cpp rename to Source/Core/InputCommon/ControllerEmu/ControllerEmu.cpp index 678ae02259..e66e682e48 100644 --- a/Source/Core/InputCommon/ControllerEmu.cpp +++ b/Source/Core/InputCommon/ControllerEmu/ControllerEmu.cpp @@ -2,7 +2,7 @@ // Licensed under GPLv2+ // Refer to the license.txt file included. -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" #include #include "Common/Common.h" #include "VideoCommon/OnScreenDisplay.h" diff --git a/Source/Core/InputCommon/ControllerEmu.h b/Source/Core/InputCommon/ControllerEmu/ControllerEmu.h similarity index 100% rename from Source/Core/InputCommon/ControllerEmu.h rename to Source/Core/InputCommon/ControllerEmu/ControllerEmu.h diff --git a/Source/Core/InputCommon/InputCommon.vcxproj b/Source/Core/InputCommon/InputCommon.vcxproj index 3ffd5c8397..96e0bad04e 100644 --- a/Source/Core/InputCommon/InputCommon.vcxproj +++ b/Source/Core/InputCommon/InputCommon.vcxproj @@ -35,7 +35,7 @@ - + @@ -55,7 +55,7 @@ - + diff --git a/Source/Core/InputCommon/InputCommon.vcxproj.filters b/Source/Core/InputCommon/InputCommon.vcxproj.filters index 6a63852303..046e66f571 100644 --- a/Source/Core/InputCommon/InputCommon.vcxproj.filters +++ b/Source/Core/InputCommon/InputCommon.vcxproj.filters @@ -13,11 +13,16 @@ {e10ce316-283c-4be0-848d-578dec2b6404} + + {4c839215-4085-4e34-a960-7960986ad015} + - + + ControllerEmu + ControllerInterface\DInput @@ -47,10 +52,12 @@ - - + + + ControllerEmu + ControllerInterface\DInput diff --git a/Source/Core/InputCommon/InputConfig.cpp b/Source/Core/InputCommon/InputConfig.cpp index cb4ea376bd..1a723c5fbb 100644 --- a/Source/Core/InputCommon/InputConfig.cpp +++ b/Source/Core/InputCommon/InputConfig.cpp @@ -9,7 +9,7 @@ #include "Common/MsgHandler.h" #include "Core/ConfigManager.h" #include "Core/HW/Wiimote.h" -#include "InputCommon/ControllerEmu.h" +#include "InputCommon/ControllerEmu/ControllerEmu.h" #include "InputCommon/ControllerInterface/ControllerInterface.h" #include "InputCommon/InputConfig.h"