From 37ef5a54c906ae697c76e2724f85f0beab4a3435 Mon Sep 17 00:00:00 2001 From: Silent Date: Mon, 26 Aug 2019 19:31:29 +0200 Subject: [PATCH] Core: Use move semantics for Renderer::SaveScreenshot --- Source/Core/VideoCommon/RenderBase.cpp | 4 ++-- Source/Core/VideoCommon/RenderBase.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/Core/VideoCommon/RenderBase.cpp b/Source/Core/VideoCommon/RenderBase.cpp index 972b0e15fc..31d3192933 100644 --- a/Source/Core/VideoCommon/RenderBase.cpp +++ b/Source/Core/VideoCommon/RenderBase.cpp @@ -369,12 +369,12 @@ Renderer::ConvertStereoRectangle(const MathUtil::Rectangle& rc) const return std::make_tuple(left_rc, right_rc); } -void Renderer::SaveScreenshot(const std::string& filename, bool wait_for_completion) +void Renderer::SaveScreenshot(std::string filename, bool wait_for_completion) { // We must not hold the lock while waiting for the screenshot to complete. { std::lock_guard lk(m_screenshot_lock); - m_screenshot_name = filename; + m_screenshot_name = std::move(filename); m_screenshot_request.Set(); } diff --git a/Source/Core/VideoCommon/RenderBase.h b/Source/Core/VideoCommon/RenderBase.h index 6ff7f410dd..16ce52aaa4 100644 --- a/Source/Core/VideoCommon/RenderBase.h +++ b/Source/Core/VideoCommon/RenderBase.h @@ -196,7 +196,7 @@ public: float EFBToScaledYf(float y) const; // Random utilities - void SaveScreenshot(const std::string& filename, bool wait_for_completion); + void SaveScreenshot(std::string filename, bool wait_for_completion); void DrawDebugText(); // ImGui initialization depends on being able to create textures and pipelines, so do it last.