From 374629ef3069aa92e53fd033d0cb6e7f0fa386c5 Mon Sep 17 00:00:00 2001 From: Silent Date: Fri, 16 Aug 2019 20:36:50 +0200 Subject: [PATCH] AudioCommon: Make HandleWinAPI handle all success return values properly, not just S_OK --- Source/Core/AudioCommon/WASAPIStream.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Core/AudioCommon/WASAPIStream.cpp b/Source/Core/AudioCommon/WASAPIStream.cpp index 6e6cd1950a..d1f3e788b1 100644 --- a/Source/Core/AudioCommon/WASAPIStream.cpp +++ b/Source/Core/AudioCommon/WASAPIStream.cpp @@ -62,7 +62,7 @@ bool WASAPIStream::isValid() static bool HandleWinAPI(std::string_view message, HRESULT result) { - if (result != S_OK) + if (FAILED(result)) { _com_error err(result); std::string error = TStrToUTF8(err.ErrorMessage()); @@ -77,7 +77,7 @@ static bool HandleWinAPI(std::string_view message, HRESULT result) ERROR_LOG_FMT(AUDIO, "WASAPI: {}: {}", message, error); } - return result == S_OK; + return SUCCEEDED(result); } std::vector WASAPIStream::GetAvailableDevices()