From 3611045a6c0f999a369f630f284d17848bf1d798 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Sat, 26 Nov 2022 22:58:46 +0100 Subject: [PATCH] DolphinQt: Add more i18n comments --- .../Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp | 1 + Source/Core/DolphinQt/Debugger/BreakpointDialog.cpp | 8 ++++++++ Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp | 3 +++ Source/Core/DolphinQt/Debugger/MemoryWidget.cpp | 11 ++++++----- 4 files changed, 18 insertions(+), 5 deletions(-) diff --git a/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp b/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp index ebc08a9345..dc104944f1 100644 --- a/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp +++ b/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp @@ -156,6 +156,7 @@ void AdvancedWidget::CreateWidgets() m_backend_multithreading = new GraphicsBool(tr("Backend Multithreading"), Config::GFX_BACKEND_MULTITHREADING); m_prefer_vs_for_point_line_expansion = new GraphicsBool( + // i18n: VS is short for vertex shaders. tr("Prefer VS for Point/Line Expansion"), Config::GFX_PREFER_VS_FOR_LINE_POINT_EXPANSION); misc_layout->addWidget(m_enable_cropping, 0, 0); diff --git a/Source/Core/DolphinQt/Debugger/BreakpointDialog.cpp b/Source/Core/DolphinQt/Debugger/BreakpointDialog.cpp index 29f879a482..f3472beeee 100644 --- a/Source/Core/DolphinQt/Debugger/BreakpointDialog.cpp +++ b/Source/Core/DolphinQt/Debugger/BreakpointDialog.cpp @@ -154,6 +154,8 @@ void BreakpointDialog::CreateWidgets() memory_data_layout->addWidget(m_memory_address_to_label, 1, 2); memory_data_layout->addWidget(m_memory_address_to, 1, 3); + // i18n: If a condition is set for a breakpoint, the condition becoming true is a prerequisite for + // triggering the breakpoint. QGroupBox* condition_box = new QGroupBox(tr("Condition")); auto* condition_layout = new QHBoxLayout; condition_box->setLayout(condition_layout); @@ -171,6 +173,8 @@ void BreakpointDialog::CreateWidgets() QHBoxLayout* conditional_layout = new QHBoxLayout; m_conditional = new QLineEdit(); + // i18n: If a condition is set for a breakpoint, the condition becoming true is a prerequisite for + // triggering the breakpoint. conditional_layout->addWidget(new QLabel(tr("Condition:"))); conditional_layout->addWidget(m_conditional); @@ -269,6 +273,8 @@ void BreakpointDialog::accept() if (!condition.isEmpty() && !Expression::TryParse(condition.toUtf8().constData())) { + // i18n: If a condition is set for a breakpoint, the condition becoming true is a prerequisite + // for triggering the breakpoint. invalid_input(tr("Condition")); return; } @@ -356,5 +362,7 @@ void BreakpointDialog::ShowConditionHelp() "Note: All values are internally converted to Doubles for calculations. It's possible for " "them to go out of range or to become NaN. A warning will be given if NaN is returned, and " "the var that became NaN will be logged."); + // i18n: The title for a dialog that shows help for how to use conditions. If a condition is set + // for a breakpoint, the condition becoming true is a prerequisite for triggering the breakpoint. ModalMessageBox::information(this, tr("Conditional help"), message); } diff --git a/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp b/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp index ae606d04fa..af24232406 100644 --- a/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp @@ -579,10 +579,13 @@ void CodeViewWidget::OnContextMenu() } auto* run_until_menu = menu->addMenu(tr("Run until (ignoring breakpoints)")); + // i18n: One of the options shown below "Run until (ignoring breakpoints)" run_until_menu->addAction(tr("%1's value is hit").arg(target), this, [this] { AutoStep(CodeTrace::AutoStop::Always); }); + // i18n: One of the options shown below "Run until (ignoring breakpoints)" run_until_menu->addAction(tr("%1's value is used").arg(target), this, [this] { AutoStep(CodeTrace::AutoStop::Used); }); + // i18n: One of the options shown below "Run until (ignoring breakpoints)" run_until_menu->addAction(tr("%1's value is changed").arg(target), [this] { AutoStep(CodeTrace::AutoStop::Changed); }); diff --git a/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp b/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp index fa4fd057f8..fc6ced4743 100644 --- a/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp @@ -162,13 +162,14 @@ void MemoryWidget::CreateWidgets() auto* address_space_layout = new QVBoxLayout; address_space_group->setLayout(address_space_layout); - // i18n: "Effective" addresses are the addresses used directly by the CPU and may be subject to - // translation via the MMU to physical addresses. + // i18n: One of the options shown below "Address Space". "Effective" addresses are the addresses + // used directly by the CPU and may be subject to translation via the MMU to physical addresses. m_address_space_effective = new QRadioButton(tr("Effective")); - // i18n: The "Auxiliary" address space is the address space of ARAM (Auxiliary RAM). + // i18n: One of the options shown below "Address Space". "Auxiliary" is the address space of ARAM + // (Auxiliary RAM). m_address_space_auxiliary = new QRadioButton(tr("Auxiliary")); - // i18n: The "Physical" address space is the address space that reflects how devices (e.g. RAM) is - // physically wired up. + // i18n: One of the options shown below "Address Space". "Physical" is the address space that + // reflects how devices (e.g. RAM) is physically wired up. m_address_space_physical = new QRadioButton(tr("Physical")); address_space_layout->addWidget(m_address_space_effective);