ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DolphinQt: Fix crash on right-clicking multiple games 

GetSelectedGames() constructs a new list each time you call it.
This commit is contained in:
JosJuice 2020-06-16 10:29:52 +02:00
parent f9f4734237
commit 349cdd5136
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/DolphinQt/GameList/GameList.cpp
View File

@ -256,7 +256,9 @@ void GameList::ShowContextMenu(const QPoint&)
if (HasMultipleSelected()) if (HasMultipleSelected())
{ {
if (std::all_of(GetSelectedGames().begin(), GetSelectedGames().end(), [](const auto& game) { const auto selected_games = GetSelectedGames();
if (std::all_of(selected_games.begin(), selected_games.end(), [](const auto& game) {
// Converting from TGC is temporarily disabled because PR #8738 was merged prematurely. // Converting from TGC is temporarily disabled because PR #8738 was merged prematurely.
// The TGC check will be removed by PR #8644. // The TGC check will be removed by PR #8644.
return DiscIO::IsDisc(game->GetPlatform()) && game->IsVolumeSizeAccurate() && return DiscIO::IsDisc(game->GetPlatform()) && game->IsVolumeSizeAccurate() &&
@ -267,7 +269,7 @@ void GameList::ShowContextMenu(const QPoint&)
menu->addSeparator(); menu->addSeparator();
} }
if (std::all_of(GetSelectedGames().begin(), GetSelectedGames().end(), if (std::all_of(selected_games.begin(), selected_games.end(),
[](const auto& game) { return DiscIO::IsWii(game->GetPlatform()); })) [](const auto& game) { return DiscIO::IsWii(game->GetPlatform()); }))
{ {
menu->addAction(tr("Export Wii Saves"), this, &GameList::ExportWiiSave); menu->addAction(tr("Export Wii Saves"), this, &GameList::ExportWiiSave);