ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Movie: replace magic number 8 with sizeof(ControllerState) 

(Bonus points for rhyming commit message)
This commit is contained in:
Michael Maltese 2017-02-08 21:32:43 -08:00
parent 657639899f
commit 31e3424367
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Source/Core/Core/Movie.cpp
View File

@ -854,9 +854,9 @@ void RecordInput(GCPadStatus* PadStatus, int controllerID)
CheckPadStatus(PadStatus, controllerID); CheckPadStatus(PadStatus, controllerID);
EnsureTmpInputSize((size_t)(s_currentByte + 8)); EnsureTmpInputSize((size_t)(s_currentByte + sizeof(ControllerState)));
memcpy(&(tmpInput[s_currentByte]), &s_padState, 8); memcpy(&tmpInput[s_currentByte], &s_padState, sizeof(ControllerState));
s_currentByte += 8; s_currentByte += sizeof(ControllerState);
s_totalBytes = s_currentByte; s_totalBytes = s_currentByte;
} }
@ -1091,11 +1091,11 @@ void LoadInput(const std::string& filename)
} }
else else
{ {
const ptrdiff_t frame = mismatch_index / 8; const ptrdiff_t frame = mismatch_index / sizeof(ControllerState);
ControllerState curPadState; ControllerState curPadState;
memcpy(&curPadState, &tmpInput[frame * 8], 8); memcpy(&curPadState, &tmpInput[frame * sizeof(ControllerState)], sizeof(ControllerState));
ControllerState movPadState; ControllerState movPadState;
memcpy(&movPadState, &movInput[frame * 8], 8); memcpy(&movPadState, &movInput[frame * sizeof(ControllerState)], sizeof(ControllerState));
PanicAlertT( PanicAlertT(
"Warning: You loaded a save whose movie mismatches on frame %td. You should load " "Warning: You loaded a save whose movie mismatches on frame %td. You should load "
"another save before continuing, or load this state with read-only mode off. " "another save before continuing, or load this state with read-only mode off. "
@ -1175,10 +1175,10 @@ void PlayController(GCPadStatus* PadStatus, int controllerID)
if (!IsPlayingInput() || !IsUsingPad(controllerID) || tmpInput == nullptr) if (!IsPlayingInput() || !IsUsingPad(controllerID) || tmpInput == nullptr)
return; return;
if (s_currentByte + 8 > s_totalBytes) if (s_currentByte + sizeof(ControllerState) > s_totalBytes)
{ {
PanicAlertT("Premature movie end in PlayController. %u + 8 > %u", (u32)s_currentByte, PanicAlertT("Premature movie end in PlayController. %u + %zu > %u", (u32)s_currentByte,
(u32)s_totalBytes); sizeof(ControllerState), (u32)s_totalBytes);
EndPlayInput(!s_bReadOnly); EndPlayInput(!s_bReadOnly);
return; return;
} }
@ -1189,8 +1189,8 @@ void PlayController(GCPadStatus* PadStatus, int controllerID)
memset(PadStatus, 0, sizeof(GCPadStatus)); memset(PadStatus, 0, sizeof(GCPadStatus));
PadStatus->err = e; PadStatus->err = e;
memcpy(&s_padState, &(tmpInput[s_currentByte]), 8); memcpy(&s_padState, &tmpInput[s_currentByte], sizeof(ControllerState));
s_currentByte += 8; s_currentByte += sizeof(ControllerState);
PadStatus->triggerLeft = s_padState.TriggerL; PadStatus->triggerLeft = s_padState.TriggerL;
PadStatus->triggerRight = s_padState.TriggerR; PadStatus->triggerRight = s_padState.TriggerR;