ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DolphinQt/MemoryWidget: Fix dead condition in FindValue() 

This condition is already checked earlier in the function and exits out
if it's satisfied, meaning it'll never reach this check further down.
This commit is contained in:
Lioncash 2018-05-05 20:44:35 -04:00
parent 58b96eeb9d
commit 31389bab0a
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Source/Core/DolphinQt2/Debugger/MemoryWidget.cpp
View File

@ -507,7 +507,10 @@ void MemoryWidget::FindValue(bool next)
std::vector<u8> search_for = GetValueData(); std::vector<u8> search_for = GetValueData();
if (search_for.empty()) if (search_for.empty())
{
m_result_label->setText(tr("No Value Given"));
return; return;
}
const u8* ram_ptr = nullptr; const u8* ram_ptr = nullptr;
std::size_t ram_size = 0; std::size_t ram_size = 0;
@ -531,12 +534,6 @@ void MemoryWidget::FindValue(bool next)
return; return;
} }
if (search_for.empty())
{
m_result_label->setText(tr("No Value Given"));
return;
}
u32 addr = 0; u32 addr = 0;
if (!m_search_address->text().isEmpty()) if (!m_search_address->text().isEmpty())