ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove the restriction to apply efb copies only once as partial update 

I'm not entirely sure what is happening, but this optimisation is causing an issue in Sonic Riders: Zero Gravity. Apparently the issue would also be fixed by PR#3747, but this PR should also fix similar issues.

Games that use partial updates might get slower with this, so some performance regression testing would be nice. Games like New Super Mario Bros, RS2, Zelda TP and Silent Hill. Testing with high graphics settings makes sense, since this would mostly end up in more work for the GPU.
This commit is contained in:
mimimi085181 2016-03-27 04:13:20 +02:00
parent 06047c1a4a
commit 2dd9e6bfe2
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Core/VideoCommon/TextureCacheBase.cpp
View File

@ -308,7 +308,6 @@ TextureCacheBase::TCacheEntryBase* TextureCacheBase::DoPartialTextureUpdates(Tex
if (entry != entry_to_update if (entry != entry_to_update
&& entry->IsEfbCopy() && entry->IsEfbCopy()
&& entry->OverlapsMemoryRange(entry_to_update->addr, entry_to_update->size_in_bytes) && entry->OverlapsMemoryRange(entry_to_update->addr, entry_to_update->size_in_bytes)
&& entry->frameCount == FRAMECOUNT_INVALID
&& entry->memory_stride == numBlocksX * block_size) && entry->memory_stride == numBlocksX * block_size)
{ {
if (entry->hash == entry->CalculateHash()) if (entry->hash == entry->CalculateHash())
@ -367,8 +366,8 @@ TextureCacheBase::TCacheEntryBase* TextureCacheBase::DoPartialTextureUpdates(Tex
dstrect.right = (dst_x + copy_width); dstrect.right = (dst_x + copy_width);
dstrect.bottom = (dst_y + copy_height); dstrect.bottom = (dst_y + copy_height);
entry_to_update->CopyRectangleFromTexture(entry, srcrect, dstrect); entry_to_update->CopyRectangleFromTexture(entry, srcrect, dstrect);
// Mark the texture update as used, so it isn't applied more than once // Mark the texture update as used, as if it was loaded directly
entry->frameCount = frameCount; entry->frameCount = FRAMECOUNT_INVALID;
} }
else else
{ {