From 2b9c65967e0f7477aaf2cc64169157b2328d4815 Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Wed, 15 Sep 2021 11:28:04 -0400
Subject: [PATCH] NetPlayClient: Change return value of OnData() to void

In all usage cases, the return value isn't utilized.
---
 Source/Core/Core/NetPlayClient.cpp | 4 +---
 Source/Core/Core/NetPlayClient.h   | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/Source/Core/Core/NetPlayClient.cpp b/Source/Core/Core/NetPlayClient.cpp
index 2cd3748dc5..570c2e7c2e 100644
--- a/Source/Core/Core/NetPlayClient.cpp
+++ b/Source/Core/Core/NetPlayClient.cpp
@@ -311,7 +311,7 @@ static void ReceiveSyncIdentifier(sf::Packet& spac, SyncIdentifier& sync_identif
 }
 
 // called from ---NETPLAY--- thread
-u32 NetPlayClient::OnData(sf::Packet& packet)
+void NetPlayClient::OnData(sf::Packet& packet)
 {
   MessageId mid;
   packet >> mid;
@@ -457,8 +457,6 @@ u32 NetPlayClient::OnData(sf::Packet& packet)
     PanicAlertFmtT("Unknown message received with id : {0}", mid);
     break;
   }
-
-  return 0;
 }
 
 void NetPlayClient::OnPlayerJoin(sf::Packet& packet)
diff --git a/Source/Core/Core/NetPlayClient.h b/Source/Core/Core/NetPlayClient.h
index d9ca1d1798..3257ac17cd 100644
--- a/Source/Core/Core/NetPlayClient.h
+++ b/Source/Core/Core/NetPlayClient.h
@@ -240,7 +240,7 @@ private:
   void DisplayPlayersPing();
   u32 GetPlayersMaxPing() const;
 
-  u32 OnData(sf::Packet& packet);
+  void OnData(sf::Packet& packet);
   void OnPlayerJoin(sf::Packet& packet);
   void OnPlayerLeave(sf::Packet& packet);
   void OnChatMessage(sf::Packet& packet);