Android: Remove finish from ConfirmRunnableViewHolder

This commit is contained in:
JosJuice 2020-10-11 10:34:12 +02:00
parent dcaf2b9625
commit 28b640fb0d
2 changed files with 2 additions and 3 deletions

View File

@ -331,6 +331,7 @@ public final class SettingsAdapter extends RecyclerView.Adapter<SettingViewHolde
StringSetting.MAIN_RESOURCEPACK_PATH.delete(settings); StringSetting.MAIN_RESOURCEPACK_PATH.delete(settings);
StringSetting.MAIN_SD_PATH.delete(settings); StringSetting.MAIN_SD_PATH.delete(settings);
notifyItemRangeChanged(0, getItemCount());
mView.onSettingChanged(); mView.onSettingChanged();
} }
@ -344,6 +345,7 @@ public final class SettingsAdapter extends RecyclerView.Adapter<SettingViewHolde
false).setBoolean(settings, value); false).setBoolean(settings, value);
} }
notifyItemRangeChanged(0, getItemCount());
mView.onSettingChanged(); mView.onSettingChanged();
} }

View File

@ -73,9 +73,6 @@ public final class ConfirmRunnableViewHolder extends SettingViewHolder
Toast.makeText(mContext, confirmationText, Toast.LENGTH_SHORT).show(); Toast.makeText(mContext, confirmationText, Toast.LENGTH_SHORT).show();
} }
dialog.dismiss(); dialog.dismiss();
// TODO: Remove finish and properly update dynamic settings descriptions.
mView.getActivity().finish();
}) })
.setNegativeButton("No", (dialog, whichButton) -> .setNegativeButton("No", (dialog, whichButton) ->
dialog.dismiss()); dialog.dismiss());