ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UICommon/NetPlayIndex: Take NetPlaySession by const reference for Add() 

This isn't std::moved wholesale into a member variable or further
std::moved into another function, so it's better to take it by const
reference here to avoid unnecessary reallocations of contained
std::string instances.
This commit is contained in:
Lioncash 2019-08-04 12:29:15 -04:00
parent 0a67a40e7c
commit 2830fe820d
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/UICommon/NetPlayIndex.cpp
View File

@ -159,7 +159,7 @@ void NetPlayIndex::NotificationLoop()
} }
} }
bool NetPlayIndex::Add(NetPlaySession session) bool NetPlayIndex::Add(const NetPlaySession& session)
{ {
Common::HttpRequest request; Common::HttpRequest request;
auto response = request.Get( auto response = request.Get(

2
Source/Core/UICommon/NetPlayIndex.h
View File

@ -44,7 +44,7 @@ public:
static std::vector<std::pair<std::string, std::string>> GetRegions(); static std::vector<std::pair<std::string, std::string>> GetRegions();
bool Add(NetPlaySession session); bool Add(const NetPlaySession& session);
void Remove(); void Remove();
bool HasActiveSession() const; bool HasActiveSession() const;