ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ControllerInterface/Device: Take vector by const reference in DetectInput() 

The vector is only ever queryied and it's contents aren't modified, so
there's no reason to take the vector by value. We can take a constant
reference to it to avoid unnecessary allocating.
This commit is contained in:
Lioncash 2019-05-29 19:10:50 -04:00
parent 246e2a77ce
commit 27346fee8a
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/InputCommon/ControllerInterface/Device.cpp
View File

@ -256,7 +256,7 @@ bool DeviceContainer::HasConnectedDevice(const DeviceQualifier& qualifier) const
// and also properly handles detection when using "FullAnalogSurface" inputs.
// Upon input, return the detected Device and Input, else return nullptrs
std::pair<std::shared_ptr<Device>, Device::Input*>
DeviceContainer::DetectInput(u32 wait_ms, std::vector<std::string> device_strings)
DeviceContainer::DetectInput(u32 wait_ms, const std::vector<std::string>& device_strings)
{
struct InputState
{
@ -273,7 +273,7 @@ DeviceContainer::DetectInput(u32 wait_ms, std::vector<std::string> device_string
// Acquire devices and initial input states.
std::vector<DeviceState> device_states;
for (auto& device_string : device_strings)
for (const auto& device_string : device_strings)
{
DeviceQualifier dq;
dq.FromString(device_string);

2
Source/Core/InputCommon/ControllerInterface/Device.h
View File

@ -188,7 +188,7 @@ public:
bool HasConnectedDevice(const DeviceQualifier& qualifier) const;
std::pair<std::shared_ptr<Device>, Device::Input*>
DetectInput(u32 wait_ms, std::vector<std::string> device_strings);
DetectInput(u32 wait_ms, const std::vector<std::string>& device_strings);
protected:
mutable std::mutex m_devices_mutex;