ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

VolumeGC: Set m_banner_loaded when banner loading fails 

If banner loading fails once, it will very likely fail again.
Setting m_banner_loaded to true when banner loading fails
prevents LoadBannerFile from wasting time if it's called again.
Banner loading requires loading the file system, which takes a
noticeable amount of time, so this matters.
This commit is contained in:
JosJuice 2016-06-28 18:05:44 +02:00
parent 10682dbf58
commit 202c9d58cd
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Source/Core/DiscIO/VolumeGC.cpp
View File

@ -205,6 +205,8 @@ void CVolumeGC::LoadBannerFile() const
if (m_banner_loaded) if (m_banner_loaded)
return; return;
m_banner_loaded = true;
GCBanner banner_file; GCBanner banner_file;
std::unique_ptr<IFileSystem> file_system(CreateFileSystem(this)); std::unique_ptr<IFileSystem> file_system(CreateFileSystem(this));
size_t file_size = (size_t)file_system->GetFileSize("opening.bnr"); size_t file_size = (size_t)file_system->GetFileSize("opening.bnr");
@ -235,7 +237,6 @@ void CVolumeGC::LoadBannerFile() const
} }
ExtractBannerInformation(banner_file, is_bnr1); ExtractBannerInformation(banner_file, is_bnr1);
m_banner_loaded = true;
} }
void CVolumeGC::ExtractBannerInformation(const GCBanner& banner_file, bool is_bnr1) const void CVolumeGC::ExtractBannerInformation(const GCBanner& banner_file, bool is_bnr1) const