ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NetPlayServer: Possible out-of-bounds access on invalid input 

if a pad or wiimote number was outside bounds (e.g. 42353543232),
it would still have been read from the array, which could lead to
inappropriate consequences, like a segfault.
This commit is contained in:
mathieui 2016-01-26 21:03:35 +01:00
parent 8e1be37feb
commit 1c808a2835
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/Core/NetPlayServer.cpp
View File

@ -504,8 +504,10 @@ unsigned int NetPlayServer::OnData(sf::Packet& packet, Client& player)
// If the data is not from the correct player,
// then disconnect them.
if (m_pad_map[map] != player.pid)
if (m_pad_map.at(map) != player.pid)
{
return 1;
}
// Relay to clients
sf::Packet spac;
@ -531,7 +533,7 @@ unsigned int NetPlayServer::OnData(sf::Packet& packet, Client& player)
// If the data is not from the correct player,
// then disconnect them.
if (m_wiimote_map[map] != player.pid)
if (m_wiimote_map.at(map) != player.pid)
{
return 1;
}