ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GameList: Work around Qt bug regarding clicking in the background not setting the position used by page down/end

This commit is contained in:
Pokechu22 2022-05-21 18:10:28 -07:00
parent 2d50ba0ca2
commit 1c4a5d9fc9
1 changed files with 23 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
Source/Core/DolphinQt/GameList/GameList.cpp
View File

@ -166,12 +166,6 @@ void GameList::MakeListView()
// Have 1 pixel of padding above and below the 32 pixel banners. // Have 1 pixel of padding above and below the 32 pixel banners.
m_list->verticalHeader()->setDefaultSectionSize(32 + 2); m_list->verticalHeader()->setDefaultSectionSize(32 + 2);
connect(m_list, &QTableView::customContextMenuRequested, this, &GameList::ShowContextMenu);
connect(m_list->selectionModel(), &QItemSelectionModel::selectionChanged,
[this](const QItemSelection&, const QItemSelection&) {
emit SelectionChanged(GetSelectedGame());
});
QHeaderView* hor_header = m_list->horizontalHeader(); QHeaderView* hor_header = m_list->horizontalHeader();
hor_header->restoreState( hor_header->restoreState(
@ -230,6 +224,20 @@ void GameList::MakeListView()
hor_header->setSectionsMovable(true); hor_header->setSectionsMovable(true);
hor_header->setHighlightSections(false); hor_header->setHighlightSections(false);
// Work around a Qt bug where clicking in the background (below the last game) as the first
// action and then pressing a key (e.g. page down or end) selects the first entry in the list
// instead of performing that key's action. This workaround does not work if there are no games
// when the view first appears, but then games are added (e.g. due to no game folders being
// present, and then the user adding one), but that is an infrequent situation.
m_list->selectRow(0);
m_list->clearSelection();
connect(m_list, &QTableView::customContextMenuRequested, this, &GameList::ShowContextMenu);
connect(m_list->selectionModel(), &QItemSelectionModel::selectionChanged,
[this](const QItemSelection&, const QItemSelection&) {
emit SelectionChanged(GetSelectedGame());
});
} }
GameList::~GameList() GameList::~GameList()
@ -323,6 +331,15 @@ void GameList::MakeGridView()
m_grid->setUniformItemSizes(true); m_grid->setUniformItemSizes(true);
m_grid->setContextMenuPolicy(Qt::CustomContextMenu); m_grid->setContextMenuPolicy(Qt::CustomContextMenu);
m_grid->setFrameStyle(QFrame::NoFrame); m_grid->setFrameStyle(QFrame::NoFrame);
// Work around a Qt bug where clicking in the background (below the last game) as the first action
// and then pressing a key (e.g. page down or end) selects the first entry in the list instead of
// performing that key's action. This workaround does not work if there are no games when the
// view first appears, but then games are added (e.g. due to no game folders being present,
// and then the user adding one), but that is an infrequent situation.
m_grid->setCurrentIndex(m_grid->indexAt(QPoint(0, 0)));
m_grid->clearSelection();
connect(m_grid, &QTableView::customContextMenuRequested, this, &GameList::ShowContextMenu); connect(m_grid, &QTableView::customContextMenuRequested, this, &GameList::ShowContextMenu);
connect(m_grid->selectionModel(), &QItemSelectionModel::selectionChanged, connect(m_grid->selectionModel(), &QItemSelectionModel::selectionChanged,
[this](const QItemSelection&, const QItemSelection&) { [this](const QItemSelection&, const QItemSelection&) {