From e8ee4e835e4bbc518406a5037036c43687e3ec27 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 27 Jan 2020 15:25:01 -0500 Subject: [PATCH 1/4] DolphinQt/NetPlayDialog: Remove unimplemented SetGame() prototype This isn't implemented anywhere, so the prototype can be removed. --- Source/Core/DolphinQt/NetPlay/NetPlayDialog.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/Source/Core/DolphinQt/NetPlay/NetPlayDialog.h b/Source/Core/DolphinQt/NetPlay/NetPlayDialog.h index 825bf72443..dd0774174e 100644 --- a/Source/Core/DolphinQt/NetPlay/NetPlayDialog.h +++ b/Source/Core/DolphinQt/NetPlay/NetPlayDialog.h @@ -99,8 +99,6 @@ private: void GameStatusChanged(bool running); void SetOptionsEnabled(bool enabled); - void SetGame(const QString& game_path); - void SendMessage(const std::string& message); // Chat From c69cbceb597bd01cf5bc49beaf8a6696616942d1 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 27 Jan 2020 15:26:39 -0500 Subject: [PATCH 2/4] DolphinQt/MainWindow: Surround prototype of OnSignal() with relevant ifdef This is only used on Apple and Unix-like machines, so we can enclose the prototype with an ifdef like the implementation is. This prevents false-positives about an unimplemented function prototype. --- Source/Core/DolphinQt/MainWindow.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Source/Core/DolphinQt/MainWindow.h b/Source/Core/DolphinQt/MainWindow.h index 5c1ae69f72..acc93df540 100644 --- a/Source/Core/DolphinQt/MainWindow.h +++ b/Source/Core/DolphinQt/MainWindow.h @@ -162,7 +162,10 @@ private: void OnBootGameCubeIPL(DiscIO::Region region); void OnImportNANDBackup(); void OnConnectWiiRemote(int id); + +#if defined(__unix__) || defined(__unix) || defined(__APPLE__) void OnSignal(); +#endif void OnUpdateProgressDialog(QString label, int progress, int total); From 2fd628d0171c435a38b128cd93f5398f2540817f Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 27 Jan 2020 15:44:50 -0500 Subject: [PATCH 3/4] DolphinQt/GameConfigEdit: Remove unimplemented SetReadOnly() member function This isn't implemented anywhere, so we can remove this prototype. --- Source/Core/DolphinQt/Config/GameConfigEdit.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/Source/Core/DolphinQt/Config/GameConfigEdit.h b/Source/Core/DolphinQt/Config/GameConfigEdit.h index 203762c66d..72847f73e2 100644 --- a/Source/Core/DolphinQt/Config/GameConfigEdit.h +++ b/Source/Core/DolphinQt/Config/GameConfigEdit.h @@ -34,8 +34,6 @@ private: void OnAutoComplete(const QString& completion); void OpenExternalEditor(); - void SetReadOnly(bool read_only); - QString GetTextUnderCursor(); void AddBoolOption(QMenu* menu, const QString& name, const QString& section, const QString& key); From dca201d5f33fb9c17b7669e38906722e27d2a3e6 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 27 Jan 2020 15:46:50 -0500 Subject: [PATCH 4/4] DolphinQt/GameConfigWidget: Remove unimplemented EditUserConfig() member function This isn't implemented anywhere, so we can remove the member function prototype. --- Source/Core/DolphinQt/Config/GameConfigWidget.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/Source/Core/DolphinQt/Config/GameConfigWidget.h b/Source/Core/DolphinQt/Config/GameConfigWidget.h index a8fba742cc..1212bfd386 100644 --- a/Source/Core/DolphinQt/Config/GameConfigWidget.h +++ b/Source/Core/DolphinQt/Config/GameConfigWidget.h @@ -36,8 +36,6 @@ private: void LoadSettings(); void SaveSettings(); - void EditUserConfig(); - void SaveCheckBox(QCheckBox* checkbox, const std::string& section, const std::string& key); void LoadCheckBox(QCheckBox* checkbox, const std::string& section, const std::string& key);