ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Debugger: Fix memory leaks related to grid tables 

Incrementing the reference count here isn't necessary, as they construct with a count of 1. Incrementing again results in the attributes not being freed.
This commit is contained in:
Lioncash 2015-04-07 23:16:26 -04:00
parent 717b326214
commit 180854c617
3 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Source/Core/DolphinWX/Debugger/DSPRegisterView.cpp
View File

@ -70,7 +70,6 @@ wxGridCellAttr *CDSPRegTable::GetAttr(int row, int col, wxGridCellAttr::wxAttrKi
if (col == 1) if (col == 1)
attr->SetTextColour(m_CachedRegHasChanged[row] ? *wxRED : *wxBLACK); attr->SetTextColour(m_CachedRegHasChanged[row] ? *wxRED : *wxBLACK);
attr->IncRef();
return attr; return attr;
} }

1
Source/Core/DolphinWX/Debugger/RegisterView.cpp
View File

@ -241,7 +241,6 @@ wxGridCellAttr *CRegTable::GetAttr(int row, int col, wxGridCellAttr::wxAttrKind)
} }
attr->SetTextColour(red ? *wxRED : *wxBLACK); attr->SetTextColour(red ? *wxRED : *wxBLACK);
attr->IncRef();
return attr; return attr;
} }

2
Source/Core/DolphinWX/Debugger/WatchView.cpp
View File

@ -208,7 +208,7 @@ wxGridCellAttr* CWatchTable::GetAttr(int row, int col, wxGridCellAttr::wxAttrKin
attr->SetBackgroundColour(*wxLIGHT_GREY); attr->SetBackgroundColour(*wxLIGHT_GREY);
} }
} }
attr->IncRef();
return attr; return attr;
} }