From 44423a3656ebdc7b7cad335532cd67798d54d285 Mon Sep 17 00:00:00 2001 From: Jordan Woyak Date: Mon, 10 Mar 2025 18:15:59 -0500 Subject: [PATCH] Movie: Eliminate MovieManager::SetGraphicsConfig. --- Source/Core/Core/Movie.cpp | 11 ----------- Source/Core/Core/Movie.h | 1 - Source/Core/VideoCommon/VideoConfig.cpp | 3 --- 3 files changed, 15 deletions(-) diff --git a/Source/Core/Core/Movie.cpp b/Source/Core/Core/Movie.cpp index d4264d52d3..679e5f3600 100644 --- a/Source/Core/Core/Movie.cpp +++ b/Source/Core/Core/Movie.cpp @@ -67,7 +67,6 @@ #include "InputCommon/GCPadStatus.h" #include "VideoCommon/VideoBackendBase.h" -#include "VideoCommon/VideoConfig.h" namespace Movie { @@ -1408,16 +1407,6 @@ void MovieManager::SaveRecording(const std::string& filename) Core::DisplayMessage(fmt::format("Failed to save {}", filename), 2000); } -// NOTE: GPU Thread -void MovieManager::SetGraphicsConfig() -{ - g_Config.bEFBAccessEnable = m_temp_header.bEFBAccessEnable; - g_Config.bSkipEFBCopyToRam = m_temp_header.bSkipEFBCopyToRam; - g_Config.bEFBEmulateFormatChanges = m_temp_header.bEFBEmulateFormatChanges; - g_Config.bImmediateXFB = m_temp_header.bImmediateXFB; - g_Config.bSkipXFBCopyToRam = m_temp_header.bSkipXFBCopyToRam; -} - // NOTE: EmuThread / Host Thread void MovieManager::GetSettings() { diff --git a/Source/Core/Core/Movie.h b/Source/Core/Core/Movie.h index ea709e1d74..e842ec9d7b 100644 --- a/Source/Core/Core/Movie.h +++ b/Source/Core/Core/Movie.h @@ -192,7 +192,6 @@ public: bool IsConfigSaved() const; bool IsStartingFromClearSave() const; bool IsUsingMemcard(ExpansionInterface::Slot slot) const; - void SetGraphicsConfig(); bool IsNetPlayRecording() const; bool IsUsingPad(int controller) const; diff --git a/Source/Core/VideoCommon/VideoConfig.cpp b/Source/Core/VideoCommon/VideoConfig.cpp index 0dec193b7a..0684c78db3 100644 --- a/Source/Core/VideoCommon/VideoConfig.cpp +++ b/Source/Core/VideoCommon/VideoConfig.cpp @@ -44,9 +44,6 @@ static bool IsVSyncActive(bool enabled) void UpdateActiveConfig() { - auto& movie = Core::System::GetInstance().GetMovie(); - if (movie.IsPlayingInput() && movie.IsConfigSaved()) - movie.SetGraphicsConfig(); g_ActiveConfig = g_Config; g_ActiveConfig.bVSyncActive = IsVSyncActive(g_ActiveConfig.bVSync); }