Revert "Added optimizations to ClassifyFloat/Double functions in Mathutil.cpp and to PPCCache.cpp"

This reverts commit 7aae9ccbc0.

Reasons:
- no test results have been provided to prove the usefulness of the patch
- broken coding style
- the author hasn't replied to any criticism

Source/Core/Common/Src/MathUtil.cpp

@@ -15,15 +15,19 @@ namespace MathUtil
 u32 ClassifyDouble(double dvalue)
 {
 	// TODO: Optimize the below to be as fast as possible.
-        u64 exp  = *(u64*)(&dvalue) & DOUBLE_EXP;
+	IntDouble value;
-        if (exp != DOUBLE_ZERO && exp != DOUBLE_EXP)
+	value.d = dvalue;
+	u64 sign = value.i & DOUBLE_SIGN;
+	u64 exp  = value.i & DOUBLE_EXP;
+	if (exp > DOUBLE_ZERO && exp < DOUBLE_EXP) 
 	{
 		// Nice normalized number.
-            return *(u64*)(&dvalue)&DOUBLE_SIGN ? PPC_FPCLASS_NN : PPC_FPCLASS_PN;
+		return sign ? PPC_FPCLASS_NN : PPC_FPCLASS_PN;
 	}
 	else
 	{
-            if (*(u64*)(&dvalue) & DOUBLE_FRAC)
+		u64 mantissa = value.i & DOUBLE_FRAC;
+		if (mantissa)
 		{
 			if (exp)
 			{
@@ -32,35 +36,38 @@ u32 ClassifyDouble(double dvalue)
 			else
 			{
 				// Denormalized number.
-                    return *(u64*)(&dvalue)&DOUBLE_SIGN ? PPC_FPCLASS_ND : PPC_FPCLASS_PD;
+				return sign ? PPC_FPCLASS_ND : PPC_FPCLASS_PD;
 			}
 		}
 		else if (exp)
 		{
 			//Infinite
-                return *(u64*)(&dvalue)&DOUBLE_SIGN ? PPC_FPCLASS_NINF : PPC_FPCLASS_PINF;
+			return sign ? PPC_FPCLASS_NINF : PPC_FPCLASS_PINF;
 		}
 		else
 		{
 			//Zero
-                return *(u64*)(&dvalue)&DOUBLE_SIGN ? PPC_FPCLASS_NZ : PPC_FPCLASS_PZ;
+			return sign ? PPC_FPCLASS_NZ : PPC_FPCLASS_PZ;
 		}
 	}
 }
 
-
 u32 ClassifyFloat(float fvalue)
 {
 	// TODO: Optimize the below to be as fast as possible.
-	u32 exp  = *(u32*)(&fvalue) & FLOAT_EXP;
+	IntFloat value;
+	value.f = fvalue;
+	u32 sign = value.i & FLOAT_SIGN;
+	u32 exp  = value.i & FLOAT_EXP;
 	if (exp > FLOAT_ZERO && exp < FLOAT_EXP) 
 	{
 		// Nice normalized number.
-		return *(u32*)(&fvalue) & FLOAT_SIGN ? PPC_FPCLASS_NN : PPC_FPCLASS_PN;
+		return sign ? PPC_FPCLASS_NN : PPC_FPCLASS_PN;
 	}
 	else
 	{
-		if (*(u32*)(&fvalue) & FLOAT_FRAC)
+		u32 mantissa = value.i & FLOAT_FRAC;
+		if (mantissa)
 		{
 			if (exp)
 			{
@@ -69,18 +76,18 @@ u32 ClassifyFloat(float fvalue)
 			else
 			{
 				// Denormalized number.
-				return *(u32*)(&fvalue) & FLOAT_SIGN ? PPC_FPCLASS_ND : PPC_FPCLASS_PD;
+				return sign ? PPC_FPCLASS_ND : PPC_FPCLASS_PD;
 			}
 		} 
 		else if (exp) 
 		{
 			// Infinite
-			return *(u32*)(&fvalue) & FLOAT_SIGN ? PPC_FPCLASS_NINF : PPC_FPCLASS_PINF;
+			return sign ? PPC_FPCLASS_NINF : PPC_FPCLASS_PINF;
 		} 
 		else 
 		{
 			//Zero
-			return *(u32*)(&fvalue) & FLOAT_SIGN ? PPC_FPCLASS_NZ : PPC_FPCLASS_PZ;
+			return sign ? PPC_FPCLASS_NZ : PPC_FPCLASS_PZ;
 		}
 	}
 }

Source/Core/Core/Src/PowerPC/PPCCache.cpp

@@ -26,26 +26,28 @@ namespace PowerPC
 
 		for (u32 m = 0; m < 128; m++)
 		{
+			u32 b[7];
+			for (int i = 0; i < 7; i++) b[i] = m & (1<<i);
 			u32 w;
-            if(m & (1<<0))
+			if (b[0])
-                if(m & (1<<2))
+				if (b[2])
-                    if(m & (1<<6))
+					if (b[6])
 						w = 7;
 					else
 						w = 6;
 				else
-                        if(m & (1<<5))
+					if (b[5])
 						w = 5;
 					else
 						w = 4;
 			else
-                            if(m & (1<<1))
+				if (b[1])
-                                if(m & (1<<4))
+					if (b[4])
 						w = 3;
 					else
 						w = 2;
 				else
-                                    if(m & (1<<3))
+					if (b[3])
 						w = 1;
 					else
 						w = 0;