diff --git a/Source/Core/DiscIO/FileSystemGCWii.cpp b/Source/Core/DiscIO/FileSystemGCWii.cpp index 8c3ce41b5b..62e29b2b5c 100644 --- a/Source/Core/DiscIO/FileSystemGCWii.cpp +++ b/Source/Core/DiscIO/FileSystemGCWii.cpp @@ -185,19 +185,19 @@ bool FileInfoGCWii::IsValid(u64 fst_size, const FileInfoGCWii& parent_directory) return true; } -FileSystemGCWii::FileSystemGCWii(const Volume* _rVolume, const Partition& partition) - : FileSystem(_rVolume, partition), m_Valid(false), m_offset_shift(0), m_root(nullptr, 0, 0, 0) +FileSystemGCWii::FileSystemGCWii(const Volume* volume, const Partition& partition) + : FileSystem(volume, partition), m_valid(false), m_offset_shift(0), m_root(nullptr, 0, 0, 0) { // Check if this is a GameCube or Wii disc - if (m_rVolume->ReadSwapped(0x18, m_partition) == u32(0x5D1C9EA3)) + if (m_volume->ReadSwapped(0x18, m_partition) == u32(0x5D1C9EA3)) m_offset_shift = 2; // Wii file system - else if (m_rVolume->ReadSwapped(0x1c, m_partition) == u32(0xC2339F3D)) + else if (m_volume->ReadSwapped(0x1c, m_partition) == u32(0xC2339F3D)) m_offset_shift = 0; // GameCube file system else return; - const std::optional fst_offset_unshifted = m_rVolume->ReadSwapped(0x424, m_partition); - const std::optional fst_size_unshifted = m_rVolume->ReadSwapped(0x428, m_partition); + const std::optional fst_offset_unshifted = m_volume->ReadSwapped(0x424, m_partition); + const std::optional fst_size_unshifted = m_volume->ReadSwapped(0x428, m_partition); if (!fst_offset_unshifted || !fst_size_unshifted) return; const u64 fst_offset = static_cast(*fst_offset_unshifted) << m_offset_shift; @@ -222,7 +222,7 @@ FileSystemGCWii::FileSystemGCWii(const Volume* _rVolume, const Partition& partit // Read the whole FST m_file_system_table.resize(fst_size); - if (!m_rVolume->Read(fst_offset, fst_size, m_file_system_table.data(), m_partition)) + if (!m_volume->Read(fst_offset, fst_size, m_file_system_table.data(), m_partition)) { ERROR_LOG(DISCIO, "Couldn't read file system table"); return; @@ -249,7 +249,7 @@ FileSystemGCWii::FileSystemGCWii(const Volume* _rVolume, const Partition& partit return; } - m_Valid = m_root.IsValid(fst_size, m_root); + m_valid = m_root.IsValid(fst_size, m_root); } FileSystemGCWii::~FileSystemGCWii() @@ -334,66 +334,66 @@ std::unique_ptr FileSystemGCWii::FindFileInfo(u64 disc_offset) const return nullptr; } -u64 FileSystemGCWii::ReadFile(const FileInfo* file_info, u8* _pBuffer, u64 _MaxBufferSize, - u64 _OffsetInFile) const +u64 FileSystemGCWii::ReadFile(const FileInfo* file_info, u8* buffer, u64 max_buffer_size, + u64 offset_in_file) const { if (!file_info || file_info->IsDirectory()) return 0; - if (_OffsetInFile >= file_info->GetSize()) + if (offset_in_file >= file_info->GetSize()) return 0; - u64 read_length = std::min(_MaxBufferSize, file_info->GetSize() - _OffsetInFile); + u64 read_length = std::min(max_buffer_size, file_info->GetSize() - offset_in_file); DEBUG_LOG(DISCIO, "Reading %" PRIx64 " bytes at %" PRIx64 " from file %s. Offset: %" PRIx64 " Size: %" PRIx32, - read_length, _OffsetInFile, file_info->GetPath().c_str(), file_info->GetOffset(), + read_length, offset_in_file, file_info->GetPath().c_str(), file_info->GetOffset(), file_info->GetSize()); - m_rVolume->Read(file_info->GetOffset() + _OffsetInFile, read_length, _pBuffer, m_partition); + m_volume->Read(file_info->GetOffset() + offset_in_file, read_length, buffer, m_partition); return read_length; } bool FileSystemGCWii::ExportFile(const FileInfo* file_info, - const std::string& _rExportFilename) const + const std::string& export_filename) const { if (!file_info || file_info->IsDirectory()) return false; - u64 remainingSize = file_info->GetSize(); - u64 fileOffset = file_info->GetOffset(); + u64 remaining_size = file_info->GetSize(); + u64 file_offset = file_info->GetOffset(); - File::IOFile f(_rExportFilename, "wb"); + File::IOFile f(export_filename, "wb"); if (!f) return false; bool result = true; - while (remainingSize) + while (remaining_size) { // Limit read size to 128 MB - size_t readSize = (size_t)std::min(remainingSize, (u64)0x08000000); + size_t read_size = (size_t)std::min(remaining_size, (u64)0x08000000); - std::vector buffer(readSize); + std::vector buffer(read_size); - result = m_rVolume->Read(fileOffset, readSize, &buffer[0], m_partition); + result = m_volume->Read(file_offset, read_size, &buffer[0], m_partition); if (!result) break; - f.WriteBytes(&buffer[0], readSize); + f.WriteBytes(&buffer[0], read_size); - remainingSize -= readSize; - fileOffset += readSize; + remaining_size -= read_size; + file_offset += read_size; } return result; } -bool FileSystemGCWii::ExportApploader(const std::string& _rExportFolder) const +bool FileSystemGCWii::ExportApploader(const std::string& export_folder) const { - std::optional apploader_size = m_rVolume->ReadSwapped(0x2440 + 0x14, m_partition); - const std::optional trailer_size = m_rVolume->ReadSwapped(0x2440 + 0x18, m_partition); + std::optional apploader_size = m_volume->ReadSwapped(0x2440 + 0x14, m_partition); + const std::optional trailer_size = m_volume->ReadSwapped(0x2440 + 0x18, m_partition); constexpr u32 header_size = 0x20; if (!apploader_size || !trailer_size) return false; @@ -401,14 +401,14 @@ bool FileSystemGCWii::ExportApploader(const std::string& _rExportFolder) const DEBUG_LOG(DISCIO, "Apploader size -> %x", *apploader_size); std::vector buffer(*apploader_size); - if (m_rVolume->Read(0x2440, *apploader_size, buffer.data(), m_partition)) + if (m_volume->Read(0x2440, *apploader_size, buffer.data(), m_partition)) { - std::string exportName(_rExportFolder + "/apploader.img"); + std::string export_name(export_folder + "/apploader.img"); - File::IOFile AppFile(exportName, "wb"); - if (AppFile) + File::IOFile apploader_file(export_name, "wb"); + if (apploader_file) { - AppFile.WriteBytes(buffer.data(), *apploader_size); + apploader_file.WriteBytes(buffer.data(), *apploader_size); return true; } } @@ -418,7 +418,7 @@ bool FileSystemGCWii::ExportApploader(const std::string& _rExportFolder) const std::optional FileSystemGCWii::GetBootDOLOffset() const { - std::optional offset = m_rVolume->ReadSwapped(0x420, m_partition); + std::optional offset = m_volume->ReadSwapped(0x420, m_partition); return offset ? static_cast(*offset) << m_offset_shift : std::optional(); } @@ -430,9 +430,9 @@ std::optional FileSystemGCWii::GetBootDOLSize(u64 dol_offset) const for (u8 i = 0; i < 7; i++) { const std::optional offset = - m_rVolume->ReadSwapped(dol_offset + 0x00 + i * 4, m_partition); + m_volume->ReadSwapped(dol_offset + 0x00 + i * 4, m_partition); const std::optional size = - m_rVolume->ReadSwapped(dol_offset + 0x90 + i * 4, m_partition); + m_volume->ReadSwapped(dol_offset + 0x90 + i * 4, m_partition); if (!offset || !size) return {}; dol_size = std::max(*offset + *size, dol_size); @@ -442,9 +442,9 @@ std::optional FileSystemGCWii::GetBootDOLSize(u64 dol_offset) const for (u8 i = 0; i < 11; i++) { const std::optional offset = - m_rVolume->ReadSwapped(dol_offset + 0x1c + i * 4, m_partition); + m_volume->ReadSwapped(dol_offset + 0x1c + i * 4, m_partition); const std::optional size = - m_rVolume->ReadSwapped(dol_offset + 0xac + i * 4, m_partition); + m_volume->ReadSwapped(dol_offset + 0xac + i * 4, m_partition); if (!offset || !size) return {}; dol_size = std::max(*offset + *size, dol_size); @@ -453,7 +453,7 @@ std::optional FileSystemGCWii::GetBootDOLSize(u64 dol_offset) const return dol_size; } -bool FileSystemGCWii::ExportDOL(const std::string& _rExportFolder) const +bool FileSystemGCWii::ExportDOL(const std::string& export_folder) const { std::optional dol_offset = GetBootDOLOffset(); if (!dol_offset) @@ -463,14 +463,14 @@ bool FileSystemGCWii::ExportDOL(const std::string& _rExportFolder) const return false; std::vector buffer(*dol_size); - if (m_rVolume->Read(*dol_offset, *dol_size, &buffer[0], m_partition)) + if (m_volume->Read(*dol_offset, *dol_size, buffer.data(), m_partition)) { - std::string exportName(_rExportFolder + "/boot.dol"); + std::string export_name(export_folder + "/boot.dol"); - File::IOFile DolFile(exportName, "wb"); - if (DolFile) + File::IOFile dol_file(export_name, "wb"); + if (dol_file) { - DolFile.WriteBytes(&buffer[0], *dol_size); + dol_file.WriteBytes(&buffer[0], *dol_size); return true; } } diff --git a/Source/Core/DiscIO/FileSystemGCWii.h b/Source/Core/DiscIO/FileSystemGCWii.h index 52013277b7..ee69bfed94 100644 --- a/Source/Core/DiscIO/FileSystemGCWii.h +++ b/Source/Core/DiscIO/FileSystemGCWii.h @@ -85,24 +85,24 @@ private: class FileSystemGCWii : public FileSystem { public: - FileSystemGCWii(const Volume* _rVolume, const Partition& partition); + FileSystemGCWii(const Volume* volume, const Partition& partition); ~FileSystemGCWii() override; - bool IsValid() const override { return m_Valid; } + bool IsValid() const override { return m_valid; } const FileInfo& GetRoot() const override; std::unique_ptr FindFileInfo(const std::string& path) const override; std::unique_ptr FindFileInfo(u64 disc_offset) const override; - u64 ReadFile(const FileInfo* file_info, u8* _pBuffer, u64 _MaxBufferSize, - u64 _OffsetInFile) const override; - bool ExportFile(const FileInfo* file_info, const std::string& _rExportFilename) const override; - bool ExportApploader(const std::string& _rExportFolder) const override; - bool ExportDOL(const std::string& _rExportFolder) const override; + u64 ReadFile(const FileInfo* file_info, u8* buffer, u64 max_buffer_size, + u64 offset_in_file) const override; + bool ExportFile(const FileInfo* file_info, const std::string& export_filename) const override; + bool ExportApploader(const std::string& export_folder) const override; + bool ExportDOL(const std::string& export_folder) const override; std::optional GetBootDOLOffset() const override; std::optional GetBootDOLSize(u64 dol_offset) const override; private: - bool m_Valid; + bool m_valid; u32 m_offset_shift; std::vector m_file_system_table; FileInfoGCWii m_root; diff --git a/Source/Core/DiscIO/Filesystem.cpp b/Source/Core/DiscIO/Filesystem.cpp index 94127e5e90..807fb6c3eb 100644 --- a/Source/Core/DiscIO/Filesystem.cpp +++ b/Source/Core/DiscIO/Filesystem.cpp @@ -13,8 +13,8 @@ FileInfo::~FileInfo() { } -FileSystem::FileSystem(const Volume* _rVolume, const Partition& partition) - : m_rVolume(_rVolume), m_partition(partition) +FileSystem::FileSystem(const Volume* volume, const Partition& partition) + : m_volume(volume), m_partition(partition) { } diff --git a/Source/Core/DiscIO/Filesystem.h b/Source/Core/DiscIO/Filesystem.h index 363a57b385..30f524281d 100644 --- a/Source/Core/DiscIO/Filesystem.h +++ b/Source/Core/DiscIO/Filesystem.h @@ -106,7 +106,7 @@ protected: class FileSystem { public: - FileSystem(const Volume* _rVolume, const Partition& partition); + FileSystem(const Volume* volume, const Partition& partition); virtual ~FileSystem(); // If IsValid is false, GetRoot must not be called. CreateFileSystem @@ -120,17 +120,17 @@ public: // Returns nullptr if not found virtual std::unique_ptr FindFileInfo(u64 disc_offset) const = 0; - virtual u64 ReadFile(const FileInfo* file_info, u8* _pBuffer, u64 _MaxBufferSize, - u64 _OffsetInFile = 0) const = 0; - virtual bool ExportFile(const FileInfo* file_info, const std::string& _rExportFilename) const = 0; - virtual bool ExportApploader(const std::string& _rExportFolder) const = 0; - virtual bool ExportDOL(const std::string& _rExportFolder) const = 0; + virtual u64 ReadFile(const FileInfo* file_info, u8* buffer, u64 max_buffer_size, + u64 offset_in_file = 0) const = 0; + virtual bool ExportFile(const FileInfo* file_info, const std::string& export_filename) const = 0; + virtual bool ExportApploader(const std::string& export_folder) const = 0; + virtual bool ExportDOL(const std::string& export_folder) const = 0; virtual std::optional GetBootDOLOffset() const = 0; virtual std::optional GetBootDOLSize(u64 dol_offset) const = 0; virtual const Partition GetPartition() const { return m_partition; } protected: - const Volume* const m_rVolume; + const Volume* const m_volume; const Partition m_partition; };