diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/cheats/ui/CheatsActivity.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/cheats/ui/CheatsActivity.java index 9eff4d1c9e..238a764f3b 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/cheats/ui/CheatsActivity.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/cheats/ui/CheatsActivity.java @@ -7,7 +7,6 @@ import android.content.Intent; import android.os.Bundle; import android.view.Menu; import android.view.MenuInflater; -import android.view.MenuItem; import android.view.View; import android.view.ViewGroup; @@ -94,6 +93,9 @@ public class CheatsActivity extends AppCompatActivity onSelectedCheatChanged(mViewModel.getSelectedCheat().getValue()); mViewModel.getOpenDetailsViewEvent().observe(this, this::openDetailsView); + + // show up button + getSupportActionBar().setDisplayHomeAsUpEnabled(true); } @Override @@ -105,18 +107,6 @@ public class CheatsActivity extends AppCompatActivity return true; } - @Override - public boolean onOptionsItemSelected(MenuItem item) - { - if (item.getItemId() == R.id.menu_save_exit) - { - finish(); - return true; - } - - return false; - } - @Override protected void onStop() { @@ -179,6 +169,13 @@ public class CheatsActivity extends AppCompatActivity } } + @Override + public boolean onSupportNavigateUp() + { + onBackPressed(); + return true; + } + private void openDetailsView(boolean open) { if (open) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java index 185538032c..aa4bb6f10d 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java @@ -75,6 +75,9 @@ public final class SettingsActivity extends AppCompatActivity implements Setting mPresenter = new SettingsActivityPresenter(this, getSettings()); mPresenter.onCreate(savedInstanceState, menuTag, gameID, revision, isWii, this); + + // show up button + getSupportActionBar().setDisplayHomeAsUpEnabled(true); } @Override @@ -86,12 +89,6 @@ public final class SettingsActivity extends AppCompatActivity implements Setting return true; } - @Override - public boolean onOptionsItemSelected(MenuItem item) - { - return mPresenter.handleOptionsItem(item.getItemId()); - } - @Override protected void onSaveInstanceState(@NonNull Bundle outState) { @@ -294,6 +291,13 @@ public final class SettingsActivity extends AppCompatActivity implements Setting mPresenter.onExtensionSettingChanged(menuTag, value); } + @Override + public boolean onSupportNavigateUp() + { + onBackPressed(); + return true; + } + private SettingsFragment getFragment() { return (SettingsFragment) getSupportFragmentManager().findFragmentByTag(FRAGMENT_TAG); diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java index 478aa3ab42..8dbf415973 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java @@ -120,17 +120,6 @@ public final class SettingsActivityPresenter } } - public boolean handleOptionsItem(int itemId) - { - if (itemId == R.id.menu_save_exit) - { - mView.finish(); - return true; - } - - return false; - } - public void onSettingChanged() { mShouldSave = true; diff --git a/Source/Android/app/src/main/res/menu/menu_settings.xml b/Source/Android/app/src/main/res/menu/menu_settings.xml index b2f735c442..9988d99f99 100644 --- a/Source/Android/app/src/main/res/menu/menu_settings.xml +++ b/Source/Android/app/src/main/res/menu/menu_settings.xml @@ -1,11 +1,3 @@ - - - - \ No newline at end of file + xmlns:app="http://schemas.android.com/apk/res-auto"/>