From a19e5b3f7a87964420612dfd6e4a7f1beec292a4 Mon Sep 17 00:00:00 2001 From: spycrab Date: Fri, 25 May 2018 02:20:52 +0200 Subject: [PATCH 1/2] Qt/InfoWidget: Don't show banner details if no data is present --- Source/Core/DolphinQt2/Config/InfoWidget.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Source/Core/DolphinQt2/Config/InfoWidget.cpp b/Source/Core/DolphinQt2/Config/InfoWidget.cpp index 51374c578e..57281bf92c 100644 --- a/Source/Core/DolphinQt2/Config/InfoWidget.cpp +++ b/Source/Core/DolphinQt2/Config/InfoWidget.cpp @@ -25,7 +25,9 @@ InfoWidget::InfoWidget(const UICommon::GameFile& game) : m_game(game) QVBoxLayout* layout = new QVBoxLayout(); layout->addWidget(CreateISODetails()); - layout->addWidget(CreateBannerDetails()); + + if (!game.GetLanguages().empty()) + layout->addWidget(CreateBannerDetails()); setLayout(layout); } @@ -144,6 +146,7 @@ void InfoWidget::CreateLanguageSelector() } if (m_language_selector->count() == 1) m_language_selector->setDisabled(true); + connect(m_language_selector, static_cast(&QComboBox::currentIndexChanged), this, &InfoWidget::ChangeLanguage); From 97383645e7aeb1c316aa47cd1ea4fa294a42dcc2 Mon Sep 17 00:00:00 2001 From: spycrab Date: Fri, 25 May 2018 02:41:49 +0200 Subject: [PATCH 2/2] Qt/InfoWidget: Don't show apploader date if it's not present --- Source/Core/DolphinQt2/Config/InfoWidget.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Source/Core/DolphinQt2/Config/InfoWidget.cpp b/Source/Core/DolphinQt2/Config/InfoWidget.cpp index 57281bf92c..8d1b02e056 100644 --- a/Source/Core/DolphinQt2/Config/InfoWidget.cpp +++ b/Source/Core/DolphinQt2/Config/InfoWidget.cpp @@ -14,6 +14,7 @@ #include #include +#include "Core/ConfigManager.h" #include "DiscIO/Blob.h" #include "DiscIO/Enums.h" #include "DolphinQt2/Config/InfoWidget.h" @@ -54,7 +55,6 @@ QGroupBox* InfoWidget::CreateISODetails() QLineEdit* country = CreateValueDisplay(DiscIO::GetName(m_game.GetCountry(), true)); QLineEdit* maker = CreateValueDisplay(m_game.GetMaker() + " (0x" + m_game.GetMakerID() + ")"); - QLineEdit* apploader_date = CreateValueDisplay(m_game.GetApploaderDate()); QWidget* checksum = CreateChecksumComputer(); layout->addRow(tr("Name:"), internal_name); @@ -62,7 +62,10 @@ QGroupBox* InfoWidget::CreateISODetails() layout->addRow(tr("Game ID:"), game_id); layout->addRow(tr("Country:"), country); layout->addRow(tr("Maker:"), maker); - layout->addRow(tr("Apploader Date:"), apploader_date); + + if (!m_game.GetApploaderDate().empty()) + layout->addRow(tr("Apploader Date:"), CreateValueDisplay(m_game.GetApploaderDate())); + layout->addRow(tr("MD5 Checksum:"), checksum); group->setLayout(layout);