ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dolphin/Source/Core/VideoCommon/FramebufferManagerBase.cpp

16 lines
397 B
C++
Raw Normal View History

Add missing license headers
2015-05-24 04:32:32 +00:00
// Copyright 2010 Dolphin Emulator Project
// Licensed under GPLv2+
// Refer to the license.txt file included.
Reformat all the things. Have fun with merge conflicts.
2016-06-24 08:43:46 +00:00
#include "VideoCommon/FramebufferManagerBase.h"
FramebufferManagerBase: Return a std::pair from GetTargetSize Keeps associated data together. It also eliminates the possibility of out parameters not being initialized properly. For example, consider the following example: -- some FramebufferManager implementation -- void FBMgrImpl::GetTargetSize(u32* width, u32* height) override { // Do nothing } -- somewhere else where the function is used -- u32 width, height; framebuffer_manager_instance->GetTargetSize(&width, &height); if (texture_width != width) <-- Uninitialized variable usage { ... } It makes it much more obvious to spot any initialization issues, because it requires something to be returned, as opposed to allowing an implementation to just not do anything.
2017-02-03 17:31:20 +00:00
FramebufferManagerBase: Get rid of explicit delete and new
2015-12-21 19:11:01 +00:00
#include <memory>
FramebufferManagerBase: Return a std::pair from GetTargetSize Keeps associated data together. It also eliminates the possibility of out parameters not being initialized properly. For example, consider the following example: -- some FramebufferManager implementation -- void FBMgrImpl::GetTargetSize(u32* width, u32* height) override { // Do nothing } -- somewhere else where the function is used -- u32 width, height; framebuffer_manager_instance->GetTargetSize(&width, &height); if (texture_width != width) <-- Uninitialized variable usage { ... } It makes it much more obvious to spot any initialization issues, because it requires something to be returned, as opposed to allowing an implementation to just not do anything.
2017-02-03 17:31:20 +00:00
Convert all includes to relative paths.
2014-02-17 10:18:15 +00:00
#include "VideoCommon/RenderBase.h"
Some compiler warnings and eol-style. git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@6418 8ced0084-cf51-0410-be5f-012b33b47a6e
2010-11-14 23:56:26 +00:00
Render: Get rid of explicit new and delete
2015-12-22 23:47:20 +00:00
std::unique_ptr<FramebufferManagerBase> g_framebuffer_manager;
Some compiler warnings and eol-style. git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@6418 8ced0084-cf51-0410-be5f-012b33b47a6e
2010-11-14 23:56:26 +00:00
TextureCache: Ensure that all render target textures have as many layers as the frame buffer. Also fixes a case where the D3D code path did not initialize num_layers leading to undefined behaviour.
2014-11-06 10:41:39 +00:00
unsigned int FramebufferManagerBase::m_EFBLayers = 1;
Remove old XFB logic
2017-08-07 04:05:42 +00:00
FramebufferManagerBase::~FramebufferManagerBase() = default;