From afb63d0b2f6d9d71baf86c68172f344a7d74cf9c Mon Sep 17 00:00:00 2001
From: zeromus <zeromus@users.sf.net>
Date: Mon, 9 May 2016 22:23:54 +0000
Subject: [PATCH] fix crashes in bilinear final filter + HD prescaling (buffer
 overflows in sloppy filter code, as usual)

---
 desmume/src/filter/bilinear.cpp | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/desmume/src/filter/bilinear.cpp b/desmume/src/filter/bilinear.cpp
index 63f190073..fe0e1aff8 100644
--- a/desmume/src/filter/bilinear.cpp
+++ b/desmume/src/filter/bilinear.cpp
@@ -17,6 +17,12 @@ int systemBlueShift   = 0;
 */
 #define RGB1(r,g,b) (((r))<<systemRedShift) | (((g)) << systemGreenShift) | (((b)) << systemBlueShift)
 
+//kind of a waste of memory, it'd be nice if we could share this with other filters
+//then again, we may want to multi-thread them later, so.. we should allocate filter objects which carry their own buffers
+//the largest conceivable prescale... 32x!
+static u8 row_cur[3*(256+8)*32];
+static u8 row_next[3*(256+8)*32];
+
 static void fill_rgb_row_16(u16 *from, int src_width, u8 *row, int width)
 {
   u8 *copy_start = row + src_width*3;
@@ -66,8 +72,6 @@ static void fill_rgb_row_32(u32 *from, int src_width, u8 *row, int width)
 void Bilinear(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */,
               u8 *dstPtr, u32 dstPitch, int width, int height)
 {
-  u8 row_cur[3*322];
-  u8 row_next[3*322];
   u8 *rgb_row_cur = row_cur;
   u8 *rgb_row_next = row_next;
 
@@ -149,8 +153,6 @@ void Bilinear(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */,
 void BilinearPlus(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */,
                   u8 *dstPtr, u32 dstPitch, int width, int height)
 {
-  u8 row_cur[3*322];
-  u8 row_next[3*322];
   u8 *rgb_row_cur = row_cur;
   u8 *rgb_row_next = row_next;
 
@@ -243,8 +245,6 @@ void BilinearPlus(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */,
 void Bilinear32(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */,
                 u8 *dstPtr, u32 dstPitch, int width, int height)
 {
-  u8 row_cur[3*322];
-  u8 row_next[3*322];
   u8 *rgb_row_cur = row_cur;
   u8 *rgb_row_next = row_next;
 
@@ -331,8 +331,6 @@ void Bilinear32(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */,
 void BilinearPlus32(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */,
                     u8 *dstPtr, u32 dstPitch, int width, int height)
 {
-  u8 row_cur[3*322];
-  u8 row_next[3*322];
   u8 *rgb_row_cur = row_cur;
   u8 *rgb_row_next = row_next;