From 1055a9235f1cedc1852800460209fe36d80e412c Mon Sep 17 00:00:00 2001 From: rogerman Date: Fri, 15 Feb 2013 02:37:14 +0000 Subject: [PATCH] Cocoa Port: - Fix regression from r4533 where the UI elements in the Cheat Manager window wouldn't update in sync with ROM loading/unloading. - Do a bunch of code cleanup. --- .../translations/English.lproj/MainMenu.xib | 2107 ++++++++--------- .../userinterface/EmuControllerDelegate.mm | 269 +-- desmume/src/cocoa/userinterface/displayView.h | 1 - .../src/cocoa/userinterface/displayView.mm | 1 - .../cocoa/userinterface/emuWindowDelegate.mm | 107 +- .../preferencesWindowDelegate.mm | 108 +- 6 files changed, 1199 insertions(+), 1394 deletions(-) diff --git a/desmume/src/cocoa/translations/English.lproj/MainMenu.xib b/desmume/src/cocoa/translations/English.lproj/MainMenu.xib index db9bc0878..842fd528b 100644 --- a/desmume/src/cocoa/translations/English.lproj/MainMenu.xib +++ b/desmume/src/cocoa/translations/English.lproj/MainMenu.xib @@ -10374,7 +10374,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {1.79769e+308, 1.79769e+308} {700, 250} - + 256 YES @@ -10383,7 +10383,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 310}, {666, 34}} - YES 67239424 @@ -10404,7 +10403,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 292 {{362, 12}, {162, 32}} - 2 YES @@ -10426,7 +10424,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 292 {{200, 12}, {162, 32}} - YES 67239424 @@ -10447,7 +10444,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 274}, {666, 28}} - YES 67239424 @@ -10464,7 +10460,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 292 {{18, 21}, {182, 18}} - YES 67239424 @@ -10487,7 +10482,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 292 {{524, 12}, {162, 32}} - 1 YES @@ -10519,14 +10513,12 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 256 {700, 195} - YES 256 {700, 17} - @@ -10534,7 +10526,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA -2147483392 {{544, 0}, {16, 17}} - YES @@ -10690,7 +10681,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 17}, {700, 195}} - @@ -10701,7 +10691,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA -2147483392 {{544, 17}, {15, 180}} - _doScroller: 0.92307692307692313 @@ -10711,7 +10700,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA -2147483392 {{1, 197}, {598, 15}} - 1 _doScroller: @@ -10726,7 +10714,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 0}, {700, 17}} - @@ -10736,7 +10723,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{-1, 53}, {702, 213}} - 562 @@ -10748,8 +10734,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {700, 364} - - {{0, 0}, {1920, 1178}} {700, 272} @@ -11609,7 +11593,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA CheatWindowDelegate - + 256 YES @@ -11618,6 +11602,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 292 {{17, 4}, {294, 14}} + YES 68288064 @@ -11635,6 +11620,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{214, 220}, {16, 16}} + 28938 100 @@ -11643,6 +11629,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{133, 369}, {136, 22}} + YES -1539178944 @@ -11699,6 +11686,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{59, 374}, {60, 14}} + YES 68288064 @@ -11715,6 +11703,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{59, 398}, {72, 14}} + YES 68288064 @@ -11731,6 +11720,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{133, 393}, {136, 22}} + YES -2076049856 @@ -11787,6 +11777,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{0, 237}, {328, 134}} + NSView @@ -11794,6 +11785,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{233, 213}, {80, 28}} + YES 67239424 @@ -11814,6 +11806,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{59, 222}, {150, 14}} + YES 68288064 @@ -11831,6 +11824,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 222}, {45, 14}} + YES 68288064 @@ -11857,12 +11851,14 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 256 {286, 176} + YES 256 {286, 17} + @@ -11870,6 +11866,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA -2147483392 {{224, 0}, {16, 17}} + YES @@ -11949,6 +11946,8 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 17}, {286, 176}} + + 4 @@ -11958,6 +11957,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA -2147483392 {{224, 17}, {15, 102}} + _doScroller: 0.94863013698630139 @@ -11967,6 +11967,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA -2147483392 {{1, 294}, {338, 15}} + 1 _doScroller: @@ -11981,6 +11982,8 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 0}, {286, 17}} + + 4 @@ -11989,6 +11992,8 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{20, 20}, {288, 194}} + + 562 @@ -11999,6 +12004,8 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {328, 434} + + NSView @@ -12023,7 +12030,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {1.79769e+308, 1.79769e+308} {500, 272} - + 256 YES @@ -12042,12 +12049,14 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 256 {500, 287} + YES 256 {500, 17} + @@ -12055,6 +12064,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA -2147483392 {{224, 0}, {16, 17}} + YES @@ -12136,6 +12146,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 17}, {500, 287}} + @@ -12146,6 +12157,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA -2147483392 {{224, 17}, {15, 102}} + _doScroller: 0.94773519163763065 @@ -12155,6 +12167,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA -2147483392 {{1, 249}, {568, 15}} + 1 _doScroller: @@ -12169,6 +12182,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 0}, {500, 17}} + @@ -12178,6 +12192,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{-1, 57}, {502, 305}} + 562 @@ -12192,6 +12207,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 370}, {120, 14}} + YES 68288064 @@ -12208,6 +12224,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 392}, {63, 14}} + YES 68288064 @@ -12224,6 +12241,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 292 {{14, 12}, {114, 32}} + YES 67239424 @@ -12244,6 +12262,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 292 {{128, 12}, {114, 32}} + YES 67239424 @@ -12264,6 +12283,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 289 {{390, 12}, {96, 32}} + 1 YES @@ -12285,6 +12305,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 289 {{294, 12}, {96, 32}} + YES 67239424 @@ -12305,6 +12326,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 265 {{378, 370}, {42, 14}} + YES 68288064 @@ -12321,6 +12343,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{139, 370}, {237, 14}} + YES 68288064 @@ -12338,6 +12361,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 265 {{422, 370}, {61, 14}} + YES 68288064 @@ -12355,6 +12379,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{82, 392}, {401, 14}} + YES 68288064 @@ -12369,6 +12394,8 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {500, 416} + + {{0, 0}, {1920, 1178}} {500, 294} @@ -12503,7 +12530,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA NSView - + 268 YES @@ -12512,6 +12539,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 86}, {294, 14}} + YES 67239424 @@ -12528,6 +12556,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 100}, {294, 14}} + YES 67239424 @@ -12544,6 +12573,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{116, 47}, {96, 28}} + YES 67239424 @@ -12561,10 +12591,12 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {328, 134} + + NSView - + 268 YES @@ -12573,6 +12605,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 72}, {294, 28}} + YES 67239424 @@ -12589,6 +12622,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 100}, {294, 14}} + YES 67239424 @@ -12605,6 +12639,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{163, 13}, {150, 28}} + 1 YES @@ -12626,6 +12661,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{163, 40}, {150, 28}} + YES 67239424 @@ -12646,6 +12682,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{15, 13}, {150, 28}} + 3 YES @@ -12667,6 +12704,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{15, 40}, {150, 28}} + 2 YES @@ -12685,10 +12723,12 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {328, 134} + + NSView - + 301 YES @@ -12697,6 +12737,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{197, 191}, {109, 32}} + YES 67239424 @@ -12717,6 +12758,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 20}, {286, 42}} + YES 67239424 @@ -12733,6 +12775,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 262}, {128, 17}} + YES 68288064 @@ -12749,6 +12792,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 265 {{149, 257}, {27, 27}} + YES -2080244224 @@ -12773,6 +12817,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{79, 230}, {38, 17}} + YES 68288064 @@ -12793,6 +12838,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{67, 198}, {128, 22}} + YES -1804468671 @@ -12864,6 +12910,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 201}, {45, 17}} + YES 68288064 @@ -12880,6 +12927,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{122, 228}, {73, 22}} + YES -1804468671 @@ -12897,6 +12945,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 231}, {60, 17}} + YES 68288064 @@ -12923,6 +12972,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{18, 14}, {190, 78}} + YES 4 1 @@ -13141,10 +13191,12 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {226, 102}} + {{46, 72}, {228, 118}} + {0, 0} 67239424 @@ -13165,10 +13217,12 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {320, 290} + + NSView - + 301 YES @@ -13210,6 +13264,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{0, 125}, {278, 53}} + @@ -13281,6 +13336,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {278, 223}} + @@ -13292,6 +13348,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA -2147483392 {{231, 1}, {15, 172}} + _doScroller: 0.68253968253968256 @@ -13301,6 +13358,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA -2147483392 {{-100, -100}, {87, 18}} + 1 _doScroller: @@ -13310,6 +13368,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{20, 20}, {280, 225}} + 530 @@ -13321,6 +13380,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 253}, {138, 17}} + YES 68288064 @@ -13334,10 +13394,12 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {320, 290} + + NSView - + 301 YES @@ -13358,6 +13420,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{101, 133}, {128, 128}} + YES 130560 @@ -13378,6 +13441,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 35}, {286, 72}} + YES 67239424 @@ -13395,6 +13459,8 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {320, 290} + + NSView @@ -15428,7 +15494,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {1.79769e+308, 1.79769e+308} - + 256 YES @@ -15447,7 +15513,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{15, 77}, {206, 18}} - YES -2080244224 @@ -15470,7 +15535,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{15, 57}, {134, 18}} - YES -2080244224 @@ -15493,7 +15557,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{15, 37}, {80, 18}} - YES -2080244224 @@ -15516,7 +15579,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{185, 12}, {45, 19}} - YES -1804468671 @@ -15597,7 +15659,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{15, 14}, {165, 14}} - YES 68288064 @@ -15612,12 +15673,10 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {248, 103}} - {{17, 241}, {250, 119}} - {0, 0} 67239424 @@ -15641,7 +15700,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{65, 18}, {154, 19}} - YES -2080244224 @@ -15672,7 +15730,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{18, 14}, {107, 58}} - YES 3 1 @@ -15877,12 +15934,10 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {248, 82}} - {{17, 442}, {250, 98}} - {0, 0} 67239424 @@ -15916,7 +15971,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{18, 14}, {120, 98}} - YES 5 1 @@ -16181,12 +16235,10 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {248, 122}} - {{17, 41}, {250, 138}} - {0, 0} 67239424 @@ -16220,7 +16272,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{15, 32}, {113, 18}} - YES -2080244224 @@ -16243,7 +16294,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{15, 12}, {108, 18}} - YES -2080244224 @@ -16264,12 +16314,10 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {248, 58}} - {{17, 364}, {250, 74}} - {0, 0} 67239424 @@ -16303,7 +16351,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{16, 12}, {192, 18}} - YES 67239424 @@ -16324,12 +16371,10 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {248, 38}} - {{17, 183}, {250, 54}} - {0, 0} 67239424 @@ -16350,8 +16395,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {284, 560} - - {{0, 0}, {1920, 1178}} {1.79769e+308, 1.79769e+308} @@ -16366,7 +16409,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {1.79769e+308, 1.79769e+308} - + 256 YES @@ -16385,7 +16428,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{18, 14}, {61, 58}} - YES 3 1 @@ -16590,12 +16632,10 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {253, 82}} - {{16, 189}, {255, 98}} - {0, 0} 67239424 @@ -16629,7 +16669,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{18, 80}, {154, 38}} - YES 2 1 @@ -16823,7 +16862,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{53, 14}, {100, 58}} - YES 3 1 @@ -17028,12 +17066,10 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {253, 128}} - {{16, 41}, {255, 144}} - {0, 0} 67239424 @@ -17067,7 +17103,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{15, 12}, {129, 18}} - YES -2080244224 @@ -17088,12 +17123,10 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {253, 38}} - {{16, 291}, {255, 54}} - {0, 0} 67239424 @@ -17127,7 +17160,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{47, 13}, {136, 21}} - YES 67501824 @@ -17149,7 +17181,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{186, 17}, {52, 17}} - YES 68288064 @@ -17240,7 +17271,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{18, 14}, {20, 20}} - YES 130560 @@ -17256,12 +17286,10 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {253, 44}} - {{16, 349}, {255, 60}} - {0, 0} 67239424 @@ -17285,7 +17313,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{66, 18}, {154, 19}} - YES -2080244224 @@ -17316,7 +17343,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{18, 14}, {116, 38}} - YES 2 1 @@ -17508,12 +17534,10 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {{1, 1}, {253, 62}} - {{16, 413}, {255, 78}} - {0, 0} 67239424 @@ -17534,8 +17558,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {288, 511} - - {{0, 0}, {1920, 1178}} {1.79769e+308, 1.79769e+308} @@ -18567,7 +18589,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {1.79769e+308, 1.79769e+308} - + 256 YES @@ -18576,7 +18598,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{30, 43}, {411, 26}} - YES -2079981824 @@ -18598,7 +18619,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{17, 77}, {38, 17}} - YES 68288064 @@ -18615,7 +18635,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{412, 77}, {38, 17}} - YES 68288064 @@ -18632,7 +18651,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{97, 77}, {38, 17}} - YES 68288064 @@ -18649,7 +18667,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{176, 77}, {38, 17}} - YES 68288064 @@ -18666,7 +18683,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{254, 77}, {38, 17}} - YES 68288064 @@ -18683,7 +18699,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{335, 77}, {38, 17}} - YES 68288064 @@ -18700,7 +18715,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{32, 18}, {133, 19}} - 100 YES @@ -18722,7 +18736,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{260, 21}, {123, 17}} - YES 68288064 @@ -18739,7 +18752,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{385, 21}, {57, 17}} - YES 68288064 @@ -18820,7 +18832,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{158, 100}, {154, 18}} - YES -2080244224 @@ -18840,8 +18851,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {467, 135} - - {{0, 0}, {1920, 1178}} {1.79769e+308, 1.79769e+308} @@ -18856,7 +18865,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {1.79769e+308, 1.79769e+308} - + 256 YES @@ -18865,7 +18874,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{88, 119}, {32, 34}} - YES 67501824 @@ -18888,7 +18896,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{85, 161}, {38, 17}} - YES 68288064 @@ -18905,7 +18912,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{85, 94}, {39, 17}} - YES 68288064 @@ -18922,7 +18928,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{44, 127}, {39, 17}} - YES 68288064 @@ -18939,7 +18944,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{125, 127}, {38, 17}} - YES 68288064 @@ -18956,7 +18960,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{127, 69}, {57, 17}} - YES 68288064 @@ -19039,7 +19042,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{24, 69}, {101, 17}} - YES 68288064 @@ -19056,7 +19058,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{27, 42}, {154, 19}} - YES -2080244224 @@ -19077,7 +19078,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 268 {{27, 17}, {154, 19}} - YES -2080244224 @@ -19095,8 +19095,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA {213, 198} - - {{0, 0}, {1440, 878}} {1.79769e+308, 1.79769e+308} @@ -20689,37 +20687,16 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA YES - gpuStateMainGPU - gpuStateMainBG0 - gpuStateMainBG1 - gpuStateMainBG2 - gpuStateMainBG3 - gpuStateMainOBJ - gpuStateSubGPU - gpuStateSubBG0 - gpuStateSubBG1 - gpuStateSubBG2 - gpuStateSubBG3 - gpuStateSubOBJ displayMode displayModeString videoFilterType videoFilterTypeString - render3DRenderingEngine - render3DDepthComparisonThreshold - render3DEdgeMarking - render3DFog - render3DHighPrecisionColorInterpolation - render3DTextures - render3DThreads - render3DLineHack scale rotation useBilinearOutput useVerticalSync displayOrientation displayOrder - render3DMultisample YES @@ -20767,11 +20744,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA YES - isWorking - status - volumeIconImage - volume - isRomLoaded isShowingStatusBar YES @@ -24141,312 +24113,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 5525 - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5530 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5531 - - - - enabled2: selection.isSupportedCheatType - - - - - - enabled2: selection.isSupportedCheatType - enabled2 - selection.isSupportedCheatType - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - - - YES - - - - - - - - 2 - - - 5532 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5533 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5534 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5535 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5538 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5539 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5541 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5543 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5545 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5546 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5549 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5550 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5552 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5555 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5558 - - - - enabled: selection.isRomLoaded - - - - - - enabled: selection.isRomLoaded - enabled - selection.isRomLoaded - 2 - - - 5561 - displayView @@ -25380,108 +25046,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 5612 - - - enabled2: selection.hasSelection - - - - - - enabled2: selection.hasSelection - enabled2 - selection.hasSelection - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - - - YES - - - - - - - - 2 - - - 5613 - - - - enabled2: selection.hasSelection - - - - - - enabled2: selection.hasSelection - enabled2 - selection.hasSelection - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - - - YES - - - - - - - - 2 - - - 5616 - - - - enabled3: selection.isSupportedCheatType - - - - - - enabled3: selection.isSupportedCheatType - enabled3 - selection.isSupportedCheatType - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - - - YES - - - - - - - - 2 - - - 5617 - value: selection.cheatDBTitle @@ -25578,42 +25142,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 5623 - - - enabled2: selection.cheatSearchSearchValue - - - - - - enabled2: selection.cheatSearchSearchValue - enabled2 - selection.cheatSearchSearchValue - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - NSValueTransformerName - - - YES - - - - - NSIsNotNil - - - - 2 - - - 5624 - animate: selection.isRunningSearch @@ -25650,358 +25178,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 5627 - - - enabled3: selection.isRunningSearch - - - - - - enabled3: selection.isRunningSearch - enabled3 - selection.isRunningSearch - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - NSValueTransformerName - - - YES - - - - - NSNegateBoolean - - - - 2 - - - 5630 - - - - enabled2: selection.isRunningSearch - - - - - - enabled2: selection.isRunningSearch - enabled2 - selection.isRunningSearch - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - NSValueTransformerName - - - YES - - - - - NSNegateBoolean - - - - 2 - - - 5631 - - - - enabled2: selection.isSearchStarted - - - - - - enabled2: selection.isSearchStarted - enabled2 - selection.isSearchStarted - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - - - YES - - - - - - - - 2 - - - 5636 - - - - enabled3: selection.isRunningSearch - - - - - - enabled3: selection.isRunningSearch - enabled3 - selection.isRunningSearch - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - NSValueTransformerName - - - YES - - - - - NSNegateBoolean - - - - 2 - - - 5637 - - - - enabled2: selection.isSearchStarted - - - - - - enabled2: selection.isSearchStarted - enabled2 - selection.isSearchStarted - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - - - YES - - - - - - - - 2 - - - 5638 - - - - enabled3: selection.isRunningSearch - - - - - - enabled3: selection.isRunningSearch - enabled3 - selection.isRunningSearch - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - NSValueTransformerName - - - YES - - - - - NSNegateBoolean - - - - 2 - - - 5639 - - - - enabled2: selection.isSearchStarted - - - - - - enabled2: selection.isSearchStarted - enabled2 - selection.isSearchStarted - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - - - YES - - - - - - - - 2 - - - 5640 - - - - enabled3: selection.isRunningSearch - - - - - - enabled3: selection.isRunningSearch - enabled3 - selection.isRunningSearch - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - NSValueTransformerName - - - YES - - - - - NSNegateBoolean - - - - 2 - - - 5641 - - - - enabled2: selection.isSearchStarted - - - - - - enabled2: selection.isSearchStarted - enabled2 - selection.isSearchStarted - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - - - YES - - - - - - - - 2 - - - 5642 - - - - enabled3: selection.isRunningSearch - - - - - - enabled3: selection.isRunningSearch - enabled3 - selection.isRunningSearch - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - NSValueTransformerName - - - YES - - - - - NSNegateBoolean - - - - 2 - - - 5643 - enabled2: selection.isSearchStarted @@ -26036,40 +25212,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 5644 - - - enabled3: selection.isRomLoaded - - - - - - enabled3: selection.isRomLoaded - enabled3 - selection.isRomLoaded - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - - - YES - - - - - - - - 2 - - - 5645 - value: values.Advanscene_AutoDetectRomSaveType @@ -28202,42 +27344,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 6105 - - - enabled2: values.R4Cheat_DatabasePath - - - - - - enabled2: values.R4Cheat_DatabasePath - enabled2 - values.R4Cheat_DatabasePath - - YES - - YES - NSMultipleValuesPlaceholder - NSNoSelectionPlaceholder - NSNotApplicablePlaceholder - NSNullPlaceholder - NSValueTransformerName - - - YES - - - - - NSIsNotNil - - - - 2 - - - 6106 - selectedTag: values.Input_AudioInputMode @@ -30291,6 +29397,942 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA 6826 + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6864 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6866 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6869 + + + + enabled2: selection.hasSelection + + + + + + enabled2: selection.hasSelection + enabled2 + selection.hasSelection + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + + + YES + + + + + + + + 2 + + + 6870 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6873 + + + + enabled2: values.R4Cheat_DatabasePath + + + + + + enabled2: values.R4Cheat_DatabasePath + enabled2 + values.R4Cheat_DatabasePath + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + NSValueTransformerName + + + YES + + + + + NSIsNotNil + + + + 2 + + + 6874 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6877 + + + + enabled2: selection.isSupportedCheatType + + + + + + enabled2: selection.isSupportedCheatType + enabled2 + selection.isSupportedCheatType + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + + + YES + + + + + + + + 2 + + + 6878 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6880 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6882 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6886 + + + + enabled2: selection.hasSelection + + + + + + enabled2: selection.hasSelection + enabled2 + selection.hasSelection + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + + + YES + + + + + + + + 2 + + + 6887 + + + + enabled3: selection.isSupportedCheatType + + + + + + enabled3: selection.isSupportedCheatType + enabled3 + selection.isSupportedCheatType + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + + + YES + + + + + + + + 2 + + + 6888 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6890 + + + + enabled3: selection.currentRom + + + + + + enabled3: selection.currentRom + enabled3 + selection.currentRom + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + NSValueTransformerName + + + YES + + + + + NSIsNotNil + + + + 2 + + + 6892 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6894 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6896 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6900 + + + + enabled2: selection.cheatSearchSearchValue + + + + + + enabled2: selection.cheatSearchSearchValue + enabled2 + selection.cheatSearchSearchValue + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + NSValueTransformerName + + + YES + + + + + NSIsNotNil + + + + 2 + + + 6901 + + + + enabled3: selection.isRunningSearch + + + + + + enabled3: selection.isRunningSearch + enabled3 + selection.isRunningSearch + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + NSValueTransformerName + + + YES + + + + + NSNegateBoolean + + + + 2 + + + 6902 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6906 + + + + enabled2: selection.isSearchStarted + + + + + + enabled2: selection.isSearchStarted + enabled2 + selection.isSearchStarted + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + + + YES + + + + + + + + 2 + + + 6907 + + + + enabled3: selection.isRunningSearch + + + + + + enabled3: selection.isRunningSearch + enabled3 + selection.isRunningSearch + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + NSValueTransformerName + + + YES + + + + + NSNegateBoolean + + + + 2 + + + 6908 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6912 + + + + enabled2: selection.isSearchStarted + + + + + + enabled2: selection.isSearchStarted + enabled2 + selection.isSearchStarted + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + + + YES + + + + + + + + 2 + + + 6913 + + + + enabled3: selection.isRunningSearch + + + + + + enabled3: selection.isRunningSearch + enabled3 + selection.isRunningSearch + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + NSValueTransformerName + + + YES + + + + + NSNegateBoolean + + + + 2 + + + 6914 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6918 + + + + enabled2: selection.isSearchStarted + + + + + + enabled2: selection.isSearchStarted + enabled2 + selection.isSearchStarted + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + + + YES + + + + + + + + 2 + + + 6919 + + + + enabled3: selection.isRunningSearch + + + + + + enabled3: selection.isRunningSearch + enabled3 + selection.isRunningSearch + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + NSValueTransformerName + + + YES + + + + + NSNegateBoolean + + + + 2 + + + 6920 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6924 + + + + enabled2: selection.isSearchStarted + + + + + + enabled2: selection.isSearchStarted + enabled2 + selection.isSearchStarted + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + + + YES + + + + + + + + 2 + + + 6925 + + + + enabled3: selection.isRunningSearch + + + + + + enabled3: selection.isRunningSearch + enabled3 + selection.isRunningSearch + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + NSValueTransformerName + + + YES + + + + + NSNegateBoolean + + + + 2 + + + 6926 + + + + enabled: selection.currentRom + + + + + + enabled: selection.currentRom + enabled + selection.currentRom + + NSValueTransformerName + NSIsNotNil + + 2 + + + 6929 + + + + enabled2: selection.isRunningSearch + + + + + + enabled2: selection.isRunningSearch + enabled2 + selection.isRunningSearch + + YES + + YES + NSMultipleValuesPlaceholder + NSNoSelectionPlaceholder + NSNotApplicablePlaceholder + NSNullPlaceholder + NSValueTransformerName + + + YES + + + + + NSNegateBoolean + + + + 2 + + + 6930 + @@ -44963,9 +45005,9 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA AUGoAABDXwAAA - {{851, 193}, {640, 480}} + {{971, 87}, {640, 480}} com.apple.InterfaceBuilder.CocoaPlugin - {{851, 193}, {640, 480}} + {{971, 87}, {640, 480}} com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -45023,9 +45065,9 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - {{1343, 397}, {256, 408}} + {{1177, 511}, {256, 408}} com.apple.InterfaceBuilder.CocoaPlugin - {{1343, 397}, {256, 408}} + {{1177, 511}, {256, 408}} {{33, 99}, {480, 360}} @@ -46019,7 +46061,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA P4AAAL+AAABBkAAAw5KAAA com.apple.InterfaceBuilder.CocoaPlugin - {{652, 866}, {320, 290}} + {{1255, 229}, {320, 290}} com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -46188,7 +46230,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA P4AAAL+AAABDaQAAw18AAA com.apple.InterfaceBuilder.CocoaPlugin - {{316, 1022}, {328, 134}} + {{1017, 396}, {328, 134}} com.apple.InterfaceBuilder.CocoaPlugin {{1183, 775}, {328, 134}} com.apple.InterfaceBuilder.CocoaPlugin @@ -46243,7 +46285,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - {{322, 680}, {328, 134}} + {{1208, 384}, {328, 134}} com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -46263,7 +46305,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - AQAAAABDXQAAA + AQAAAABDbQAAA com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -46362,9 +46404,9 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA P4AAAL+AAABDRQAAw10AAA com.apple.InterfaceBuilder.CocoaPlugin - {{330, 277}, {500, 416}} + {{1063, 215}, {500, 416}} com.apple.InterfaceBuilder.CocoaPlugin - {{330, 277}, {500, 416}} + {{1063, 215}, {500, 416}} {500, 272} @@ -47521,7 +47563,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA AUMaAABC4AAAA - {{1047, 530}, {616, 0}} + {{975, 901}, {616, 0}} com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -47684,7 +47726,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - {{1191, 651}, {328, 434}} + {{1271, 124}, {328, 434}} com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -48033,7 +48075,7 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA - 6826 + 6930 @@ -48574,15 +48616,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA YES YES - change3DRenderDepthComparisonThreshold: - change3DRenderEdgeMarking: - change3DRenderFog: - change3DRenderHighPrecisionColorInterpolation: - change3DRenderLineHack: - change3DRenderMethod: - change3DRenderMultisample: - change3DRenderTextures: - change3DRenderThreads: changeAudioEngine: changeCoreEmuFlags: changeCoreSpeed: @@ -48650,30 +48683,12 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA id id id - id - id - id - id - id - id - id - id - id YES YES - change3DRenderDepthComparisonThreshold: - change3DRenderEdgeMarking: - change3DRenderFog: - change3DRenderHighPrecisionColorInterpolation: - change3DRenderLineHack: - change3DRenderMethod: - change3DRenderMultisample: - change3DRenderTextures: - change3DRenderThreads: changeAudioEngine: changeCoreEmuFlags: changeCoreSpeed: @@ -48709,42 +48724,6 @@ AAMAAAABAAEAAAFTAAMAAAAEAAAFwgAAAAAACAAIAAgACAABAAEAAQABA YES - - change3DRenderDepthComparisonThreshold: - id - - - change3DRenderEdgeMarking: - id - - - change3DRenderFog: - id - - - change3DRenderHighPrecisionColorInterpolation: - id - - - change3DRenderLineHack: - id - - - change3DRenderMethod: - id - - - change3DRenderMultisample: - id - - - change3DRenderTextures: - id - - - change3DRenderThreads: - id - changeAudioEngine: id diff --git a/desmume/src/cocoa/userinterface/EmuControllerDelegate.mm b/desmume/src/cocoa/userinterface/EmuControllerDelegate.mm index 1ea2932b0..7e2ff04bc 100644 --- a/desmume/src/cocoa/userinterface/EmuControllerDelegate.mm +++ b/desmume/src/cocoa/userinterface/EmuControllerDelegate.mm @@ -243,9 +243,8 @@ } NSURL *selectedFile = nil; - NSInteger buttonClicked = NSFileHandlingPanelCancelButton; - NSOpenPanel *panel = [NSOpenPanel openPanel]; + NSOpenPanel *panel = [NSOpenPanel openPanel]; [panel setCanChooseDirectories:NO]; [panel setCanChooseFiles:YES]; [panel setResolvesAliases:YES]; @@ -257,9 +256,9 @@ // is deprecated in Mac OS X v10.6. #if MAC_OS_X_VERSION_MAX_ALLOWED > MAC_OS_X_VERSION_10_5 [panel setAllowedFileTypes:fileTypes]; - buttonClicked = [panel runModal]; + const NSInteger buttonClicked = [panel runModal]; #else - buttonClicked = [panel runModalForDirectory:nil file:nil types:fileTypes]; + const NSInteger buttonClicked = [panel runModalForDirectory:nil file:nil types:fileTypes]; #endif if (buttonClicked == NSFileHandlingPanelOKButton) @@ -269,13 +268,9 @@ { return; } + + [self handleLoadRom:selectedFile]; } - else - { - return; - } - - [self handleLoadRom:selectedFile]; } - (IBAction) closeRom:(id)sender @@ -285,11 +280,9 @@ - (IBAction) openEmuSaveState:(id)sender { - BOOL result = NO; NSURL *selectedFile = nil; - NSInteger buttonClicked = NSFileHandlingPanelCancelButton; - NSOpenPanel *panel = [NSOpenPanel openPanel]; + NSOpenPanel *panel = [NSOpenPanel openPanel]; [panel setCanChooseDirectories:NO]; [panel setCanChooseFiles:YES]; [panel setResolvesAliases:YES]; @@ -301,9 +294,9 @@ // is deprecated in Mac OS X v10.6. #if MAC_OS_X_VERSION_MAX_ALLOWED > MAC_OS_X_VERSION_10_5 [panel setAllowedFileTypes:fileTypes]; - buttonClicked = [panel runModal]; + const NSInteger buttonClicked = [panel runModal]; #else - buttonClicked = [panel runModalForDirectory:nil file:nil types:fileTypes]; + const NSInteger buttonClicked = [panel runModalForDirectory:nil file:nil types:fileTypes]; #endif if (buttonClicked == NSFileHandlingPanelOKButton) @@ -321,35 +314,34 @@ [self pauseCore]; - result = [CocoaDSFile loadState:selectedFile]; - if (result == NO) + const BOOL isStateLoaded = [CocoaDSFile loadState:selectedFile]; + if (!isStateLoaded) { [self setStatusText:NSSTRING_STATUS_SAVESTATE_LOADING_FAILED]; [self restoreCoreState]; return; } - [self setCurrentSaveStateURL:selectedFile]; - [self restoreCoreState]; - [self setStatusText:NSSTRING_STATUS_SAVESTATE_LOADED]; - isSaveStateEdited = YES; for (NSWindow *theWindow in windowList) { [theWindow setDocumentEdited:isSaveStateEdited]; } + + [self setStatusText:NSSTRING_STATUS_SAVESTATE_LOADED]; + [self restoreCoreState]; + + [self setCurrentSaveStateURL:selectedFile]; } - (IBAction) saveEmuSaveState:(id)sender { - BOOL result = NO; - if (isSaveStateEdited && [self currentSaveStateURL] != nil) { [self pauseCore]; - result = [CocoaDSFile saveState:[self currentSaveStateURL]]; - if (result == NO) + const BOOL isStateSaved = [CocoaDSFile saveState:[self currentSaveStateURL]]; + if (!isStateSaved) { [self setStatusText:NSSTRING_STATUS_SAVESTATE_SAVING_FAILED]; return; @@ -361,8 +353,8 @@ [theWindow setDocumentEdited:isSaveStateEdited]; } - [self restoreCoreState]; [self setStatusText:NSSTRING_STATUS_SAVESTATE_SAVED]; + [self restoreCoreState]; } else { @@ -372,10 +364,7 @@ - (IBAction) saveEmuSaveStateAs:(id)sender { - BOOL result = NO; - NSInteger buttonClicked = NSFileHandlingPanelCancelButton; NSSavePanel *panel = [NSSavePanel savePanel]; - [panel setCanCreateDirectories:YES]; [panel setTitle:NSSTRING_TITLE_SAVE_STATE_FILE_PANEL]; @@ -388,63 +377,61 @@ [panel setRequiredFileType:@FILE_EXT_SAVE_STATE]; #endif - buttonClicked = [panel runModal]; + const NSInteger buttonClicked = [panel runModal]; if(buttonClicked == NSOKButton) { - [self pauseCore]; - NSURL *saveFileURL = [panel URL]; - result = [CocoaDSFile saveState:saveFileURL]; - if (result == NO) + [self pauseCore]; + + const BOOL isStateSaved = [CocoaDSFile saveState:saveFileURL]; + if (!isStateSaved) { [self setStatusText:NSSTRING_STATUS_SAVESTATE_SAVING_FAILED]; return; } - [self setCurrentSaveStateURL:saveFileURL]; - [self restoreCoreState]; - [self setStatusText:NSSTRING_STATUS_SAVESTATE_SAVED]; - isSaveStateEdited = YES; for (NSWindow *theWindow in windowList) { [theWindow setDocumentEdited:isSaveStateEdited]; } + + [self setStatusText:NSSTRING_STATUS_SAVESTATE_SAVED]; + [self restoreCoreState]; + + [self setCurrentSaveStateURL:saveFileURL]; } } - (IBAction) revertEmuSaveState:(id)sender { - BOOL result = NO; - - if (isSaveStateEdited && [self currentSaveStateURL] != nil) + if (!isSaveStateEdited || [self currentSaveStateURL] == nil) { - [self pauseCore]; - - result = [CocoaDSFile loadState:[self currentSaveStateURL]]; - if (result == NO) - { - [self setStatusText:NSSTRING_STATUS_SAVESTATE_REVERTING_FAILED]; - return; - } - - isSaveStateEdited = YES; - for (NSWindow *theWindow in windowList) - { - [theWindow setDocumentEdited:isSaveStateEdited]; - } - - [self restoreCoreState]; - [self setStatusText:NSSTRING_STATUS_SAVESTATE_REVERTED]; + return; } + + [self pauseCore]; + + const BOOL isStateLoaded = [CocoaDSFile loadState:[self currentSaveStateURL]]; + if (!isStateLoaded) + { + [self setStatusText:NSSTRING_STATUS_SAVESTATE_REVERTING_FAILED]; + return; + } + + isSaveStateEdited = YES; + for (NSWindow *theWindow in windowList) + { + [theWindow setDocumentEdited:isSaveStateEdited]; + } + + [self setStatusText:NSSTRING_STATUS_SAVESTATE_REVERTED]; + [self restoreCoreState]; } - (IBAction) loadEmuSaveStateSlot:(id)sender { - BOOL result = NO; - NSInteger i = [CocoaDSUtil getIBActionSenderTag:sender]; - NSString *saveStatePath = [[CocoaDSFile saveStateURL] path]; if (saveStatePath == nil) { @@ -452,13 +439,14 @@ return; } - if (i < 0 || i > MAX_SAVESTATE_SLOTS) + const NSInteger slotNumber = [CocoaDSUtil getIBActionSenderTag:sender]; + if (slotNumber < 0 || slotNumber > MAX_SAVESTATE_SLOTS) { return; } NSURL *currentRomURL = [[self currentRom] fileURL]; - NSString *fileName = [CocoaDSFile saveSlotFileName:currentRomURL slotNumber:(NSUInteger)(i + 1)]; + NSString *fileName = [CocoaDSFile saveSlotFileName:currentRomURL slotNumber:(NSUInteger)(slotNumber + 1)]; if (fileName == nil) { return; @@ -466,21 +454,14 @@ [self pauseCore]; - result = [CocoaDSFile loadState:[NSURL fileURLWithPath:[saveStatePath stringByAppendingPathComponent:fileName]]]; - if (result == NO) - { - [self setStatusText:NSSTRING_STATUS_SAVESTATE_LOADING_FAILED]; - } + const BOOL isStateLoaded = [CocoaDSFile loadState:[NSURL fileURLWithPath:[saveStatePath stringByAppendingPathComponent:fileName]]]; + [self setStatusText:(isStateLoaded) ? NSSTRING_STATUS_SAVESTATE_LOADED : NSSTRING_STATUS_SAVESTATE_LOADING_FAILED]; [self restoreCoreState]; - [self setStatusText:NSSTRING_STATUS_SAVESTATE_LOADED]; } - (IBAction) saveEmuSaveStateSlot:(id)sender { - BOOL result = NO; - NSInteger i = [CocoaDSUtil getIBActionSenderTag:sender]; - NSString *saveStatePath = [[CocoaDSFile saveStateURL] path]; if (saveStatePath == nil) { @@ -488,20 +469,21 @@ return; } - result = [CocoaDSFile createUserAppSupportDirectory:@"States"]; - if (result == NO) + const BOOL isDirectoryCreated = [CocoaDSFile createUserAppSupportDirectory:@"States"]; + if (!isDirectoryCreated) { [self setStatusText:NSSTRING_STATUS_CANNOT_CREATE_SAVE_DIRECTORY]; return; } - if (i < 0 || i > MAX_SAVESTATE_SLOTS) + const NSInteger slotNumber = [CocoaDSUtil getIBActionSenderTag:sender]; + if (slotNumber < 0 || slotNumber > MAX_SAVESTATE_SLOTS) { return; } NSURL *currentRomURL = [[self currentRom] fileURL]; - NSString *fileName = [CocoaDSFile saveSlotFileName:currentRomURL slotNumber:(NSUInteger)(i + 1)]; + NSString *fileName = [CocoaDSFile saveSlotFileName:currentRomURL slotNumber:(NSUInteger)(slotNumber + 1)]; if (fileName == nil) { return; @@ -509,23 +491,17 @@ [self pauseCore]; - result = [CocoaDSFile saveState:[NSURL fileURLWithPath:[saveStatePath stringByAppendingPathComponent:fileName]]]; - if (result == NO) - { - [self setStatusText:NSSTRING_STATUS_SAVESTATE_SAVING_FAILED]; - return; - } + const BOOL isStateSaved = [CocoaDSFile saveState:[NSURL fileURLWithPath:[saveStatePath stringByAppendingPathComponent:fileName]]]; + [self setStatusText:(isStateSaved) ? NSSTRING_STATUS_SAVESTATE_SAVED : NSSTRING_STATUS_SAVESTATE_SAVING_FAILED]; [self restoreCoreState]; - [self setStatusText:NSSTRING_STATUS_SAVESTATE_SAVED]; } - (IBAction) importRomSave:(id)sender { NSURL *selectedFile = nil; - NSInteger buttonClicked = NSFileHandlingPanelCancelButton; - NSOpenPanel *panel = [NSOpenPanel openPanel]; + NSOpenPanel *panel = [NSOpenPanel openPanel]; [panel setCanChooseDirectories:NO]; [panel setCanChooseFiles:YES]; [panel setResolvesAliases:YES]; @@ -537,9 +513,9 @@ // is deprecated in Mac OS X v10.6. #if MAC_OS_X_VERSION_MAX_ALLOWED > MAC_OS_X_VERSION_10_5 [panel setAllowedFileTypes:fileTypes]; - buttonClicked = [panel runModal]; + const NSInteger buttonClicked = [panel runModal]; #else - buttonClicked = [panel runModalForDirectory:nil file:nil types:fileTypes]; + const NSInteger buttonClicked = [panel runModalForDirectory:nil file:nil types:fileTypes]; #endif if (buttonClicked == NSFileHandlingPanelOKButton) @@ -549,47 +525,29 @@ { return; } + + const BOOL isRomSaveImported = [CocoaDSFile importRomSave:selectedFile]; + [self setStatusText:(isRomSaveImported) ? NSSTRING_STATUS_ROM_SAVE_IMPORTED : NSSTRING_STATUS_ROM_SAVE_IMPORT_FAILED]; } - else - { - return; - } - - BOOL result = [CocoaDSFile importRomSave:selectedFile]; - if (!result) - { - [self setStatusText:NSSTRING_STATUS_ROM_SAVE_IMPORT_FAILED]; - return; - } - - [self setStatusText:NSSTRING_STATUS_ROM_SAVE_IMPORTED]; } - (IBAction) exportRomSave:(id)sender { [self pauseCore]; - BOOL result = NO; - NSInteger buttonClicked; NSSavePanel *panel = [NSSavePanel savePanel]; [panel setTitle:NSSTRING_TITLE_EXPORT_ROM_SAVE_PANEL]; [panel setCanCreateDirectories:YES]; [panel setAccessoryView:exportRomSavePanelAccessoryView]; - buttonClicked = [panel runModal]; + const NSInteger buttonClicked = [panel runModal]; if(buttonClicked == NSOKButton) { NSURL *romSaveURL = [CocoaDSFile fileURLFromRomURL:[[self currentRom] fileURL] toKind:@"ROM Save"]; if (romSaveURL != nil) { - result = [CocoaDSFile exportRomSaveToURL:[panel URL] romSaveURL:romSaveURL fileType:selectedExportRomSaveID]; - if (result == NO) - { - [self setStatusText:NSSTRING_STATUS_ROM_SAVE_EXPORT_FAILED]; - return; - } - - [self setStatusText:NSSTRING_STATUS_ROM_SAVE_EXPORTED]; + const BOOL isRomSaveExported = [CocoaDSFile exportRomSaveToURL:[panel URL] romSaveURL:romSaveURL fileType:selectedExportRomSaveID]; + [self setStatusText:(isRomSaveExported) ? NSSTRING_STATUS_ROM_SAVE_EXPORTED : NSSTRING_STATUS_ROM_SAVE_EXPORT_FAILED]; } } @@ -620,35 +578,37 @@ - (IBAction) resetCore:(id)sender { + if ([self currentRom] == nil) + { + return; + } + CocoaDSCore *cdsCore = (CocoaDSCore *)[cdsCoreController content]; - if ([self currentRom] != nil) + [self setStatusText:NSSTRING_STATUS_EMULATOR_RESETTING]; + [self setIsWorking:YES]; + + for (NSWindow *theWindow in windowList) + { + [theWindow displayIfNeeded]; + } + + [cdsCore reset]; + if ([cdsCore coreState] == CORESTATE_PAUSE) { - [self setStatusText:NSSTRING_STATUS_EMULATOR_RESETTING]; - [self setIsWorking:YES]; - for (NSWindow *theWindow in windowList) { - [theWindow displayIfNeeded]; - } - - [cdsCore reset]; - if ([cdsCore coreState] == CORESTATE_PAUSE) - { - for (NSWindow *theWindow in windowList) - { - [[(EmuWindowDelegate *)[theWindow delegate] dispViewDelegate] setViewToWhite]; - } - } - - [self setStatusText:NSSTRING_STATUS_EMULATOR_RESET]; - [self setIsWorking:NO]; - - for (NSWindow *theWindow in windowList) - { - [theWindow displayIfNeeded]; + [[(EmuWindowDelegate *)[theWindow delegate] dispViewDelegate] setViewToWhite]; } } + + [self setStatusText:NSSTRING_STATUS_EMULATOR_RESET]; + [self setIsWorking:NO]; + + for (NSWindow *theWindow in windowList) + { + [theWindow displayIfNeeded]; + } } - (IBAction) speedLimitDisable:(id)sender @@ -711,7 +671,6 @@ - (IBAction) changeCoreSpeed:(id)sender { CocoaDSCore *cdsCore = (CocoaDSCore *)[cdsCoreController content]; - [cdsCore setSpeedScalar:(CGFloat)[CocoaDSUtil getIBActionSenderTag:sender] / 100.0f]; } @@ -750,7 +709,7 @@ - (IBAction) changeVolume:(id)sender { - float vol = [self currentVolumeValue]; + const float vol = [self currentVolumeValue]; [self setCurrentVolumeValue:vol]; [self setStatusText:[NSString stringWithFormat:NSSTRING_STATUS_VOLUME, vol]]; [CocoaDSUtil messageSendOneWayWithFloat:[cdsSpeaker receivePort] msgID:MESSAGE_SET_VOLUME floatValue:vol]; @@ -924,13 +883,13 @@ if ([self currentRom] != nil) { - BOOL closeResult = [self handleUnloadRom:REASONFORCLOSE_OPEN romToLoad:fileURL]; + const BOOL closeResult = [self handleUnloadRom:REASONFORCLOSE_OPEN romToLoad:fileURL]; if ([self isShowingSaveStateDialog]) { return result; } - if (![self isShowingFileMigrationDialog] && closeResult == NO) + if (![self isShowingFileMigrationDialog] && !closeResult) { return result; } @@ -987,7 +946,6 @@ break; } - [currentSaveStateURL retain]; [self setIsUserInterfaceBlockingExecution:YES]; [self setIsShowingSaveStateDialog:YES]; @@ -1047,7 +1005,7 @@ { CocoaDSRom *theRom = [aNotification object]; NSDictionary *userInfo = [aNotification userInfo]; - BOOL didLoad = [(NSNumber *)[userInfo valueForKey:@"DidLoad"] boolValue]; + const BOOL didLoad = [(NSNumber *)[userInfo valueForKey:@"DidLoad"] boolValue]; if (theRom == nil || ![theRom isDataLoaded] || !didLoad) { @@ -1174,8 +1132,7 @@ { BOOL result = NO; - [currentSaveStateURL release]; - currentSaveStateURL = nil; + [self setCurrentSaveStateURL:nil]; isSaveStateEdited = NO; for (NSWindow *theWindow in windowList) @@ -1341,7 +1298,7 @@ - (IBAction) closeSheet:(id)sender { NSWindow *sheet = [(NSControl *)sender window]; - NSInteger code = [(NSControl *)sender tag]; + const NSInteger code = [(NSControl *)sender tag]; [NSApp endSheet:sheet returnCode:code]; } @@ -1373,8 +1330,6 @@ - (void) didEndSaveStateSheet:(NSWindow *)sheet returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo { - BOOL result = NO; - [sheet orderOut:self]; switch (returnCode) @@ -1387,13 +1342,16 @@ break; case COCOA_DIALOG_DEFAULT: // Save - result = [CocoaDSFile saveState:[self currentSaveStateURL]]; - if (result == NO) + { + const BOOL isStateSaved = [CocoaDSFile saveState:[self currentSaveStateURL]]; + if (!isStateSaved) { // Throw an error here... + [self setStatusText:NSSTRING_STATUS_SAVESTATE_SAVING_FAILED]; return; } break; + } case COCOA_DIALOG_OPTION: // Don't Save break; @@ -1405,9 +1363,6 @@ [self unloadRom]; [self setIsUserInterfaceBlockingExecution:NO]; [self setIsShowingSaveStateDialog:NO]; - - // We retained this when we initially put up the sheet, so we need to release it now. - [self setCurrentSaveStateURL:nil]; } - (void) didEndSaveStateSheetOpen:(NSWindow *)sheet returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo @@ -1439,7 +1394,7 @@ - (BOOL)validateUserInterfaceItem:(id )theItem { BOOL enable = YES; - SEL theAction = [theItem action]; + const SEL theAction = [theItem action]; CocoaDSCore *cdsCore = (CocoaDSCore *)[cdsCoreController content]; if (theAction == @selector(importRomSave:) || @@ -1452,8 +1407,8 @@ } else if (theAction == @selector(executeCoreToggle:)) { - if ([self currentRom] == nil || - ![cdsCore masterExecute] || + if (![cdsCore masterExecute] || + [self currentRom] == nil || [self isUserInterfaceBlockingExecution]) { enable = NO; @@ -1487,8 +1442,8 @@ else if (theAction == @selector(executeCore) || theAction == @selector(pauseCore)) { - if ([self currentRom] == nil || - ![cdsCore masterExecute] || + if (![cdsCore masterExecute] || + [self currentRom] == nil || [self isShowingSaveStateDialog]) { enable = NO; @@ -1524,11 +1479,7 @@ } else if (theAction == @selector(loadEmuSaveStateSlot:)) { - if ([self currentRom] == nil || [self isShowingSaveStateDialog]) - { - enable = NO; - } - else if (![CocoaDSFile saveStateExistsForSlot:[[self currentRom] fileURL] slotNumber:[theItem tag] + 1]) + if ([self currentRom] == nil || [self isShowingSaveStateDialog] || ![CocoaDSFile saveStateExistsForSlot:[[self currentRom] fileURL] slotNumber:[theItem tag] + 1]) { enable = NO; } diff --git a/desmume/src/cocoa/userinterface/displayView.h b/desmume/src/cocoa/userinterface/displayView.h index dc51c87d0..934970ef6 100644 --- a/desmume/src/cocoa/userinterface/displayView.h +++ b/desmume/src/cocoa/userinterface/displayView.h @@ -68,7 +68,6 @@ enum OGLVertexAttributeID NSMutableDictionary *bindings; OSSpinLock spinlockNormalSize; - OSSpinLock spinlockGpuStateFlags; OSSpinLock spinlockScale; OSSpinLock spinlockRotation; OSSpinLock spinlockUseBilinearOutput; diff --git a/desmume/src/cocoa/userinterface/displayView.mm b/desmume/src/cocoa/userinterface/displayView.mm index 4fca9721f..c3c70b43c 100644 --- a/desmume/src/cocoa/userinterface/displayView.mm +++ b/desmume/src/cocoa/userinterface/displayView.mm @@ -107,7 +107,6 @@ const char *fragmentProgram_100 = {"\ view = nil; spinlockNormalSize = OS_SPINLOCK_INIT; - spinlockGpuStateFlags = OS_SPINLOCK_INIT; spinlockScale = OS_SPINLOCK_INIT; spinlockRotation = OS_SPINLOCK_INIT; spinlockUseBilinearOutput = OS_SPINLOCK_INIT; diff --git a/desmume/src/cocoa/userinterface/emuWindowDelegate.mm b/desmume/src/cocoa/userinterface/emuWindowDelegate.mm index 437dc9d14..538713cb1 100644 --- a/desmume/src/cocoa/userinterface/emuWindowDelegate.mm +++ b/desmume/src/cocoa/userinterface/emuWindowDelegate.mm @@ -234,7 +234,7 @@ - (IBAction) changeRotationRelative:(id)sender { - double angleDegrees = [dispViewDelegate rotation] + (double)[CocoaDSUtil getIBActionSenderTag:sender]; + const double angleDegrees = [dispViewDelegate rotation] + (double)[CocoaDSUtil getIBActionSenderTag:sender]; [self setContentRotation:angleDegrees]; } @@ -250,7 +250,7 @@ - (IBAction) changeDisplayMode:(id)sender { - NSInteger newDisplayModeID = [CocoaDSUtil getIBActionSenderTag:sender]; + const NSInteger newDisplayModeID = [CocoaDSUtil getIBActionSenderTag:sender]; if (newDisplayModeID == [dispViewDelegate displayMode]) { @@ -263,7 +263,7 @@ - (IBAction) changeDisplayOrientation:(id)sender { - NSInteger newDisplayOrientation = [CocoaDSUtil getIBActionSenderTag:sender]; + const NSInteger newDisplayOrientation = [CocoaDSUtil getIBActionSenderTag:sender]; if (newDisplayOrientation == [dispViewDelegate displayOrientation]) { @@ -336,14 +336,7 @@ - (IBAction) toggleStatusBar:(id)sender { - if (isShowingStatusBar) - { - [self setShowStatusBar:NO]; - } - else - { - [self setShowStatusBar:YES]; - } + [self setShowStatusBar:(isShowingStatusBar) ? NO : YES]; } - (void) setShowStatusBar:(BOOL)showStatusBar @@ -395,14 +388,12 @@ [emuControl pauseCore]; - NSInteger buttonClicked = NSFileHandlingPanelCancelButton; NSSavePanel *panel = [NSSavePanel savePanel]; - [panel setCanCreateDirectories:YES]; [panel setTitle:NSSTRING_TITLE_SAVE_SCREENSHOT_PANEL]; [panel setAccessoryView:saveScreenshotPanelAccessoryView]; - buttonClicked = [panel runModal]; + const NSInteger buttonClicked = [panel runModal]; if(buttonClicked == NSOKButton) { [dispViewDelegate requestScreenshot:[panel URL] fileType:screenshotFileFormat]; @@ -420,7 +411,7 @@ NSBitmapImageFileType fileType = (NSBitmapImageFileType)[(NSNumber *)[[aNotification userInfo] valueForKey:@"fileType"] integerValue]; NSImage *screenshotImage = (NSImage *)[[aNotification userInfo] valueForKey:@"screenshotImage"]; - BOOL fileSaved = [CocoaDSFile saveScreenshot:fileURL bitmapData:[[screenshotImage representations] objectAtIndex:0] fileType:fileType]; + const BOOL fileSaved = [CocoaDSFile saveScreenshot:fileURL bitmapData:[[screenshotImage representations] objectAtIndex:0] fileType:fileType]; if (!fileSaved) { [CocoaDSUtil quickDialogUsingTitle:NSSTRING_ERROR_TITLE_LEGACY message:NSSTRING_ERROR_SCREENSHOT_FAILED_LEGACY]; @@ -432,22 +423,15 @@ - (BOOL)validateUserInterfaceItem:(id )theItem { BOOL enable = YES; - SEL theAction = [theItem action]; + const SEL theAction = [theItem action]; if (theAction == @selector(changeScale:)) { - NSInteger viewScale = (NSInteger)([dispViewDelegate scale] * 100.0); + const NSInteger viewScale = (NSInteger)([dispViewDelegate scale] * 100.0); if ([(id)theItem isMemberOfClass:[NSMenuItem class]]) { - if (viewScale == [theItem tag]) - { - [(NSMenuItem*)theItem setState:NSOnState]; - } - else - { - [(NSMenuItem*)theItem setState:NSOffState]; - } + [(NSMenuItem*)theItem setState:(viewScale == [theItem tag]) ? NSOnState : NSOffState]; } } else if (theAction == @selector(changeRotation:)) @@ -484,84 +468,42 @@ { if ([(id)theItem isMemberOfClass:[NSMenuItem class]]) { - if ([dispViewDelegate displayMode] == [theItem tag]) - { - [(NSMenuItem*)theItem setState:NSOnState]; - } - else - { - [(NSMenuItem*)theItem setState:NSOffState]; - } + [(NSMenuItem*)theItem setState:([dispViewDelegate displayMode] == [theItem tag]) ? NSOnState : NSOffState]; } } else if (theAction == @selector(changeDisplayOrientation:)) { if ([(id)theItem isMemberOfClass:[NSMenuItem class]]) { - if ([dispViewDelegate displayOrientation] == [theItem tag]) - { - [(NSMenuItem*)theItem setState:NSOnState]; - } - else - { - [(NSMenuItem*)theItem setState:NSOffState]; - } + [(NSMenuItem*)theItem setState:([dispViewDelegate displayOrientation] == [theItem tag]) ? NSOnState : NSOffState]; } } else if (theAction == @selector(changeDisplayOrder:)) { if ([(id)theItem isMemberOfClass:[NSMenuItem class]]) { - if ([dispViewDelegate displayOrder] == [theItem tag]) - { - [(NSMenuItem*)theItem setState:NSOnState]; - } - else - { - [(NSMenuItem*)theItem setState:NSOffState]; - } + [(NSMenuItem*)theItem setState:([dispViewDelegate displayOrder] == [theItem tag]) ? NSOnState : NSOffState]; } } else if (theAction == @selector(hudDisable:)) { if ([(id)theItem isMemberOfClass:[NSMenuItem class]]) { - if ([dispViewDelegate isHudEnabled]) - { - [(NSMenuItem*)theItem setTitle:NSSTRING_TITLE_DISABLE_HUD]; - } - else - { - [(NSMenuItem*)theItem setTitle:NSSTRING_TITLE_ENABLE_HUD]; - } + [(NSMenuItem*)theItem setTitle:([dispViewDelegate isHudEnabled]) ? NSSTRING_TITLE_DISABLE_HUD : NSSTRING_TITLE_ENABLE_HUD]; } } else if (theAction == @selector(toggleStatusBar:)) { if ([(id)theItem isMemberOfClass:[NSMenuItem class]]) { - if (isShowingStatusBar) - { - [(NSMenuItem*)theItem setTitle:NSSTRING_TITLE_HIDE_STATUS_BAR]; - } - else - { - [(NSMenuItem*)theItem setTitle:NSSTRING_TITLE_SHOW_STATUS_BAR]; - } + [(NSMenuItem*)theItem setTitle:(isShowingStatusBar) ? NSSTRING_TITLE_HIDE_STATUS_BAR : NSSTRING_TITLE_SHOW_STATUS_BAR]; } } else if (theAction == @selector(toggleKeepMinDisplaySizeAtNormal:)) { if ([(id)theItem isMemberOfClass:[NSMenuItem class]]) { - if (isMinSizeNormal) - { - [(NSMenuItem*)theItem setState:NSOnState]; - } - else - { - [(NSMenuItem*)theItem setState:NSOffState]; - } + [(NSMenuItem*)theItem setState:(isMinSizeNormal) ? NSOnState : NSOffState]; } } @@ -576,9 +518,6 @@ - (NSSize)windowWillResize:(NSWindow *)sender toSize:(NSSize)frameSize { - NSSize finalSize = frameSize; - const NSSize normalBounds = [dispViewDelegate normalSize]; - // Get a content Rect so that we can make our comparison. // This will be based on the proposed frameSize. const NSRect frameRect = NSMakeRect(0.0f, 0.0f, frameSize.width, frameSize.height); @@ -586,17 +525,16 @@ // Find the maximum scalar we can use for the display view, bounded by the // content Rect. - const NSSize checkSize = GetTransformedBounds(normalBounds, 1.0, [dispViewDelegate rotation]); + const NSSize checkSize = GetTransformedBounds([dispViewDelegate normalSize], 1.0, [dispViewDelegate rotation]); const NSSize contentBounds = NSMakeSize(contentRect.size.width, contentRect.size.height - statusBarHeight); const double maxS = GetMaxScalarInBounds(checkSize.width, checkSize.height, contentBounds.width, contentBounds.height); // Make a new content Rect with our max scalar, and convert it back to a frame Rect. const NSRect finalContentRect = NSMakeRect(0.0f, 0.0f, checkSize.width * maxS, (checkSize.height * maxS) + statusBarHeight); - NSRect finalFrameRect = [sender frameRectForContentRect:finalContentRect]; + const NSRect finalFrameRect = [sender frameRectForContentRect:finalContentRect]; // Set the final size based on our new frame Rect. - finalSize.width = finalFrameRect.size.width; - finalSize.height = finalFrameRect.size.height; + const NSSize finalSize = {finalFrameRect.size.width, finalFrameRect.size.height}; return finalSize; } @@ -608,11 +546,8 @@ return; } - const NSSize normalBounds = [dispViewDelegate normalSize]; - const double r = [dispViewDelegate rotation]; - // Get the max scalar within the window's current content bounds. - const NSSize checkSize = GetTransformedBounds(normalBounds, 1.0, r); + const NSSize checkSize = GetTransformedBounds([dispViewDelegate normalSize], 1.0, [dispViewDelegate rotation]); NSSize contentBounds = [[window contentView] bounds].size; contentBounds.height -= statusBarHeight; const double maxS = GetMaxScalarInBounds(checkSize.width, checkSize.height, contentBounds.width, contentBounds.height); @@ -653,8 +588,8 @@ [self setShowStatusBar:[[NSUserDefaults standardUserDefaults] boolForKey:@"DisplayView_ShowStatusBar"]]; // Set the display settings per user preferences. - double displayScalar = (double)([[NSUserDefaults standardUserDefaults] floatForKey:@"DisplayView_Size"] / 100.0); - double displayRotation = (double)[[NSUserDefaults standardUserDefaults] floatForKey:@"DisplayView_Rotation"]; + const double displayScalar = (double)([[NSUserDefaults standardUserDefaults] floatForKey:@"DisplayView_Size"] / 100.0); + const double displayRotation = (double)[[NSUserDefaults standardUserDefaults] floatForKey:@"DisplayView_Rotation"]; [dispViewDelegate setDisplayMode:[[NSUserDefaults standardUserDefaults] integerForKey:@"DisplayView_Mode"]]; [dispViewDelegate setDisplayOrientation:[[NSUserDefaults standardUserDefaults] integerForKey:@"DisplayViewCombo_Orientation"]]; [dispViewDelegate setDisplayOrder:[[NSUserDefaults standardUserDefaults] integerForKey:@"DisplayViewCombo_Order"]]; diff --git a/desmume/src/cocoa/userinterface/preferencesWindowDelegate.mm b/desmume/src/cocoa/userinterface/preferencesWindowDelegate.mm index 6051684d8..19a1ef2c0 100644 --- a/desmume/src/cocoa/userinterface/preferencesWindowDelegate.mm +++ b/desmume/src/cocoa/userinterface/preferencesWindowDelegate.mm @@ -93,14 +93,7 @@ vfWidth = (NSUInteger)vfDestSize.width; vfHeight = (NSUInteger)vfDestSize.height; - if (useBilinear) - { - bilinearVideoFilter = [[CocoaVideoFilter alloc] initWithSize:vfDestSize typeID:VideoFilterTypeID_Bilinear]; - } - else - { - bilinearVideoFilter = [[CocoaVideoFilter alloc] initWithSize:vfDestSize typeID:VideoFilterTypeID_Nearest2X]; - } + bilinearVideoFilter = [[CocoaVideoFilter alloc] initWithSize:vfDestSize typeID:(useBilinear) ? VideoFilterTypeID_Bilinear : VideoFilterTypeID_Nearest2X]; } else if (vfWidth >= 256 || vfHeight >= 256) { @@ -108,14 +101,7 @@ } else { - if (useBilinear) - { - bilinearVideoFilter = [[CocoaVideoFilter alloc] initWithSize:vfDestSize typeID:VideoFilterTypeID_Bilinear]; - } - else - { - bilinearVideoFilter = [[CocoaVideoFilter alloc] initWithSize:vfDestSize typeID:VideoFilterTypeID_Nearest2X]; - } + bilinearVideoFilter = [[CocoaVideoFilter alloc] initWithSize:vfDestSize typeID:(useBilinear) ? VideoFilterTypeID_Bilinear : VideoFilterTypeID_Nearest2X]; } RGBA8888ForceOpaqueBuffer((const uint32_t *)[videoFilter runFilter], (uint32_t *)[bilinearVideoFilter srcBufferPtr], (vfWidth * vfHeight)); @@ -171,7 +157,7 @@ - (IBAction) selectAutoloadRomOption:(id)sender { - NSInteger option = [(NSMenuItem *)sender tag]; + const NSInteger option = [(NSMenuItem *)sender tag]; [[NSUserDefaults standardUserDefaults] setInteger:option forKey:@"General_AutoloadROMOption"]; @@ -334,7 +320,7 @@ [[NSUserDefaults standardUserDefaults] setObject:selectedFile forKey:@"R4Cheat_DatabasePath"]; [bindings setValue:[selectedFile lastPathComponent] forKey:@"R4CheatDatabaseName"]; - BOOL isRomLoaded = [(NSNumber *)[(NSMutableDictionary *)[emuWindowController content] valueForKey:@"isRomLoaded"] boolValue]; + const BOOL isRomLoaded = [(NSNumber *)[(NSMutableDictionary *)[emuWindowController content] valueForKey:@"isRomLoaded"] boolValue]; NSMutableDictionary *cheatWindowBindings = (NSMutableDictionary *)[cheatWindowController content]; CocoaDSCheatManager *cdsCheats = (CocoaDSCheatManager *)[cheatWindowBindings valueForKey:@"cheatList"]; @@ -394,30 +380,24 @@ - (IBAction) selectSoundInputMode:(id)sender { CocoaDSCore *cdsCore = (CocoaDSCore *)[cdsCoreController content]; - if (cdsCore != nil) - { - [cdsCore.cdsController setSoundInputMode:[[NSUserDefaults standardUserDefaults] integerForKey:@"Input_AudioInputMode"]]; - } + [cdsCore.cdsController setSoundInputMode:[[NSUserDefaults standardUserDefaults] integerForKey:@"Input_AudioInputMode"]]; } - (IBAction) selectDisplayMode:(id)sender { - NSInteger displayMode = [(NSMenuItem *)sender tag]; - + const NSInteger displayMode = [(NSMenuItem *)sender tag]; [[NSUserDefaults standardUserDefaults] setInteger:displayMode forKey:@"DisplayView_Mode"]; } - (IBAction) selectDisplaySize:(id)sender { - NSInteger displaySize = [(NSMenuItem *)sender tag]; - + const NSInteger displaySize = [(NSMenuItem *)sender tag]; [[NSUserDefaults standardUserDefaults] setInteger:displaySize forKey:@"DisplayView_Size"]; } - (IBAction) selectDisplayRotation:(id)sender { - NSInteger displayRotation = [(NSMenuItem *)sender tag]; - + const NSInteger displayRotation = [(NSMenuItem *)sender tag]; if (displayRotation != -1) { [[NSUserDefaults standardUserDefaults] setDouble:displayRotation forKey:@"DisplayView_Rotation"]; @@ -426,20 +406,13 @@ - (IBAction) setUseBilinear:(id)sender { - BOOL useBilinear = [CocoaDSUtil getIBActionSenderButtonStateBool:sender]; - NSUInteger previewSrcWidth = (NSUInteger)[bilinearVideoFilter srcSize].width; - NSUInteger previewSrcHeight = (NSUInteger)[bilinearVideoFilter srcSize].height; + const BOOL useBilinear = [CocoaDSUtil getIBActionSenderButtonStateBool:sender]; + const NSUInteger previewSrcWidth = (NSUInteger)[bilinearVideoFilter srcSize].width; + const NSUInteger previewSrcHeight = (NSUInteger)[bilinearVideoFilter srcSize].height; if (previewSrcWidth <= 128 || previewSrcHeight <= 128) { - if (useBilinear) - { - [bilinearVideoFilter changeFilter:VideoFilterTypeID_Bilinear]; - } - else - { - [bilinearVideoFilter changeFilter:VideoFilterTypeID_Nearest2X]; - } + [bilinearVideoFilter changeFilter:(useBilinear) ? VideoFilterTypeID_Bilinear : VideoFilterTypeID_Nearest2X]; } NSBitmapImageRep *newPreviewImageRep = [bilinearVideoFilter bitmapImageRep]; @@ -455,8 +428,8 @@ - (IBAction) selectVideoFilterType:(id)sender { - VideoFilterTypeID vfType = (VideoFilterTypeID)[CocoaDSUtil getIBActionSenderTag:sender]; - BOOL useBilinear = [[NSUserDefaults standardUserDefaults] boolForKey:@"DisplayView_UseBilinearOutput"]; + const VideoFilterTypeID vfType = (VideoFilterTypeID)[CocoaDSUtil getIBActionSenderTag:sender]; + const BOOL useBilinear = [[NSUserDefaults standardUserDefaults] boolForKey:@"DisplayView_UseBilinearOutput"]; [[NSUserDefaults standardUserDefaults] setInteger:vfType forKey:@"DisplayView_VideoFilter"]; @@ -471,16 +444,9 @@ vfDestSize = [videoFilter destSize]; vfWidth = (NSUInteger)vfDestSize.width; vfHeight = (NSUInteger)vfDestSize.height; - [bilinearVideoFilter setSourceSize:vfDestSize]; - if (useBilinear) - { - [bilinearVideoFilter changeFilter:VideoFilterTypeID_Bilinear]; - } - else - { - [bilinearVideoFilter changeFilter:VideoFilterTypeID_Nearest2X]; - } + [bilinearVideoFilter setSourceSize:vfDestSize]; + [bilinearVideoFilter changeFilter:(useBilinear) ? VideoFilterTypeID_Bilinear : VideoFilterTypeID_Nearest2X]; } else if (vfWidth >= 256 || vfHeight >= 256) { @@ -490,15 +456,7 @@ else { [bilinearVideoFilter setSourceSize:vfDestSize]; - - if (useBilinear) - { - [bilinearVideoFilter changeFilter:VideoFilterTypeID_Bilinear]; - } - else - { - [bilinearVideoFilter changeFilter:VideoFilterTypeID_Nearest2X]; - } + [bilinearVideoFilter changeFilter:(useBilinear) ? VideoFilterTypeID_Bilinear : VideoFilterTypeID_Nearest2X]; } RGBA8888ForceOpaqueBuffer((const uint32_t *)[videoFilter runFilter], (uint32_t *)[bilinearVideoFilter srcBufferPtr], (vfWidth * vfHeight)); @@ -516,7 +474,7 @@ - (IBAction) updateVolumeIcon:(id)sender { NSImage *iconImage = (NSImage *)[bindings objectForKey:@"volumeIconImage"]; - float vol = [[NSUserDefaults standardUserDefaults] floatForKey:@"Sound_Volume"]; + const float vol = [[NSUserDefaults standardUserDefaults] floatForKey:@"Sound_Volume"]; if (vol <= 0.0f) { @@ -560,20 +518,13 @@ - (IBAction) selectSPUSyncMode:(id)sender { - NSInteger spuSyncMode = [[NSUserDefaults standardUserDefaults] integerForKey:@"SPU_SyncMode"]; - if (spuSyncMode == SPU_SYNC_MODE_DUAL_SYNC_ASYNC) - { - [spuSyncMethodMenu setEnabled:NO]; - } - else - { - [spuSyncMethodMenu setEnabled:YES]; - } + const NSInteger spuSyncMode = [[NSUserDefaults standardUserDefaults] integerForKey:@"SPU_SyncMode"]; + [spuSyncMethodMenu setEnabled:(spuSyncMode == SPU_SYNC_MODE_DUAL_SYNC_ASYNC) ? NO : YES]; } - (IBAction) selectSPUSyncMethod:(id)sender { - NSInteger spuSyncMethod = [(NSMenuItem *)sender tag]; + const NSInteger spuSyncMethod = [(NSMenuItem *)sender tag]; [[NSUserDefaults standardUserDefaults] setInteger:spuSyncMethod forKey:@"SPU_SyncMethod"]; } @@ -706,10 +657,7 @@ [bindings setValue:[selectedFile lastPathComponent] forKey:@"Arm9BiosImageName"]; CocoaDSCore *cdsCore = (CocoaDSCore *)[cdsCoreController content]; - if (cdsCore != nil) - { - [cdsCore setArm9ImageURL:selectedFileURL]; - } + [cdsCore setArm9ImageURL:selectedFileURL]; } - (void) chooseArm7BiosImageDidEnd:(NSOpenPanel *)sheet returnCode:(int)returnCode contextInfo:(void *)contextInfo @@ -733,10 +681,7 @@ [bindings setValue:[selectedFile lastPathComponent] forKey:@"Arm7BiosImageName"]; CocoaDSCore *cdsCore = (CocoaDSCore *)[cdsCoreController content]; - if (cdsCore != nil) - { - [cdsCore setArm7ImageURL:selectedFileURL]; - } + [cdsCore setArm7ImageURL:selectedFileURL]; } - (void) chooseFirmwareImageDidEnd:(NSOpenPanel *)sheet returnCode:(int)returnCode contextInfo:(void *)contextInfo @@ -760,10 +705,7 @@ [bindings setValue:[selectedFile lastPathComponent] forKey:@"FirmwareImageName"]; CocoaDSCore *cdsCore = (CocoaDSCore *)[cdsCoreController content]; - if (cdsCore != nil) - { - [cdsCore setFirmwareImageURL:selectedFileURL]; - } + [cdsCore setFirmwareImageURL:selectedFileURL]; } - (IBAction) configureInternalFirmware:(id)sender @@ -778,7 +720,7 @@ - (IBAction) closeFirmwareConfigSheet:(id)sender { NSWindow *sheet = [(NSControl *)sender window]; - NSInteger code = [CocoaDSUtil getIBActionSenderTag:sender]; + const NSInteger code = [CocoaDSUtil getIBActionSenderTag:sender]; // Force end of editing of any text fields. [sheet makeFirstResponder:nil];