ShuriZma
/
bsnes
mirror of https://github.com/bsnes-emu/bsnes.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

target-bsnes: Patch up broken recent-game entries. 

In f09c45f, we fixed native file picker dialogs, so they would correctly set the
"option" field to Auto when loading games, instead of leaving it set to an empty
string which effectively forced NTSC mode. However, this wouldn't fix up the old
entries in the Recent Games menu, so we also need to patch those entries when we
read them.
This commit is contained in:
Tim Allen 2020-11-02 22:25:10 +11:00
parent 6b38388a67
commit f062c83cf7
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
bsnes/target-bsnes/program/platform.cpp
View File

@ -102,7 +102,14 @@ auto Program::load(uint id, string name, string type, vector<string> options) ->
if(id == 1 && name == "Super Famicom" && type == "sfc") {
if(gameQueue) {
auto game = gameQueue.takeLeft().split(";", 1L);
superFamicom.option = game(0);
// In bsnes v115 and earlier, opening a game with the native file picker
// would set the option to "" (an empty string), effectively forcing the
// region to NTSC, rather than the default of "Auto". This didn't matter
// for actual NTSC games, but caused problems for PAL games. The problem
// with the file-picker has been fixed, but broken entries will still be
// present in "Recent Game" lists, so if we get a game with whose option
// field is empty, assume it should be "Auto".
superFamicom.option = game(0) ? game(0) : "Auto";
superFamicom.location = game(1);
} else {
dialog.setTitle("Load SNES ROM");