From b4709fd66bd986a5c32b423b317e74ab7a96470d Mon Sep 17 00:00:00 2001 From: Lior Halphon Date: Fri, 18 Jun 2021 01:36:29 +0300 Subject: [PATCH] Disabled an accuracy-improvement-attempt that caused audio regressions until the proper behavior is well understood, fixes #390 --- Core/sm83_cpu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Core/sm83_cpu.c b/Core/sm83_cpu.c index 377f519f..0d4ab72a 100644 --- a/Core/sm83_cpu.c +++ b/Core/sm83_cpu.c @@ -288,7 +288,10 @@ static void cycle_write(GB_gameboy_t *gb, uint16_t addr, uint8_t value) gb->apu.square_sweep_calculate_countdown -= 2; } gb->apu.enable_zombie_calculate_stepping = true; - GB_write_memory(gb, addr, 0xFF); + /* TODO: this causes audio regressions in the Donkey Kong Land series. + The exact behavior of this quirk should be further investigated, as it seems + more complicated than a single FF pseudo-write. */ + // GB_write_memory(gb, addr, 0xFF); } GB_write_memory(gb, addr, value); gb->pending_cycles = 4;