ShuriZma
/
bsnes
mirror of https://github.com/bsnes-emu/bsnes.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Force-enable coprocessor delayed-sync while creating a save-state. 

When making a save state, all the system components are "fast forwarded" to a
safe state that can be serialised. If delayedSync (called "Coprocessor Fast
Sync" in the UI) is enabled, this works perfectly. If it is disabled, the
accurate coprocessor synching interferes with the save-state creation, leading
to the game crashing or (worse) the emulator freezing.

Star Fox is a good test case - repeatedly saving state and loading it will very
quickly cause the game to run super-slowly, hang, or crash.

Ideally, somebody should dig into exactly what coprocessor syncing is doing
that breaks the assumptions of the state-saving code, but given how complex
the whole thing is, and given that it doesn't affect hardware emulation
accuracy (real hardware can't save states at all), it's easiest to just force-
enable delayedSync while a save-state is in progress.

Fix from the jgemu bsnes fork:
8b4d1b8ae5
This commit is contained in:
Tim Allen 2024-09-17 23:42:09 +10:00 committed by Screwtapello
parent 9fbbea23d3
commit 710d92cbdd
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
bsnes/sfc/system/system.cpp
View File

@ -15,6 +15,12 @@ auto System::run() -> void {
} }
auto System::runToSave() -> void { auto System::runToSave() -> void {
// Enable coprocessor delayed sync if it is off - this is extremely important
// for coprocessor games, as many will not sync correctly for states when the
// option is off.
bool delay_sync_prev = configuration.hacks.coprocessor.delayedSync;
configuration.hacks.coprocessor.delayedSync = true;
auto method = configuration.system.serialization.method; auto method = configuration.system.serialization.method;
//these games will periodically deadlock when using "Fast" synchronization //these games will periodically deadlock when using "Fast" synchronization
@ -30,6 +36,9 @@ auto System::runToSave() -> void {
scheduler.mode = Scheduler::Mode::Run; scheduler.mode = Scheduler::Mode::Run;
scheduler.active = cpu.thread; scheduler.active = cpu.thread;
// Restore coprocessor delayed sync to whatever it was previous to the state save operation
configuration.hacks.coprocessor.delayedSync = delay_sync_prev;
} }
auto System::runToSaveFast() -> void { auto System::runToSaveFast() -> void {