ShuriZma
/
bsnes
mirror of https://github.com/bsnes-emu/bsnes.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix PWM performence issue

This commit is contained in:
Lior Halphon 2020-04-29 19:53:47 +03:00
parent 5c9d50e25f
commit 66112af37e
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
JoyKit/JOYController.m
View File

@ -115,6 +115,7 @@ typedef struct __attribute__((packed)) {
volatile double _rumblePWMRatio; volatile double _rumblePWMRatio;
bool _physicallyConnected; bool _physicallyConnected;
bool _logicallyConnected; bool _logicallyConnected;
bool _rumblePWMThreadRunning;
} }
- (instancetype)initWithDevice:(IOHIDDeviceRef) device - (instancetype)initWithDevice:(IOHIDDeviceRef) device
@ -609,7 +610,7 @@ typedef struct __attribute__((packed)) {
[NSThread sleepForTimeInterval:(1 - _rumblePWMRatio) / 10]; [NSThread sleepForTimeInterval:(1 - _rumblePWMRatio) / 10];
} }
[_rumblePWMThreadLock lock]; [_rumblePWMThreadLock lock];
[_rumblePWMThreadLock signal]; _rumblePWMThreadRunning = false;
[_rumblePWMThreadLock unlock]; [_rumblePWMThreadLock unlock];
} }
@ -657,23 +658,23 @@ typedef struct __attribute__((packed)) {
} }
else { else {
if (_rumbleElement.max == 1 && _rumbleElement.min == 0) { if (_rumbleElement.max == 1 && _rumbleElement.min == 0) {
if (_rumblePWMRatio == 0) { // PWM thread not running, start it. [_rumblePWMThreadLock lock];
if (!_rumblePWMThreadRunning) { // PWM thread not running, start it.
if (amp != 0) { if (amp != 0) {
_rumblePWMRatio = amp; _rumblePWMRatio = amp;
_rumblePWMThreadRunning = true;
[self performSelectorInBackground:@selector(pwmThread) withObject:nil]; [self performSelectorInBackground:@selector(pwmThread) withObject:nil];
} }
} }
else { else {
if (amp == 0) { // Thread is running, signal it to stop if (amp == 0) { // Thread is running, signal it to stop
[_rumblePWMThreadLock lock];
_rumblePWMRatio = 0; _rumblePWMRatio = 0;
[_rumblePWMThreadLock wait];
[_rumblePWMThreadLock unlock];
} }
else { else {
_rumblePWMRatio = amp; _rumblePWMRatio = amp;
} }
} }
[_rumblePWMThreadLock unlock];
} }
else { else {
[_rumbleElement setValue:amp * (_rumbleElement.max - _rumbleElement.min) + _rumbleElement.min]; [_rumbleElement setValue:amp * (_rumbleElement.max - _rumbleElement.min) + _rumbleElement.min];