ShuriZma
/
bsnes
mirror of https://github.com/bsnes-emu/bsnes.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update io.cpp 

This corrects the reporting bit of HVBJOY to be set during the auto joypad polling sequence.
This change will fix SpellCraft - Aspects of Valor (#86). SpellCraft works by polling JOY1 nonstop once menus are entered on every scanline, so with incorrect HVBJOY bit 0 reporting, the game was thinking it was safe to read JOY1 during the auto joypad polling sequence, so partially shifted in results were being read back as valid. With this patch, you'll find that the game stops polling between V:225 H:130 and V:228 H:256, which is the auto polling time range. Before, it was polling during that time. As a result of this fix, the password menu can be accessed safely without it closing immediately.
This commit is contained in:
Asura 2020-11-02 03:46:17 +09:00 committed by GitHub
parent 6b38388a67
commit 22066b9a24
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bsnes/sfc/cpu/io.cpp
View File

@ -38,7 +38,7 @@ auto CPU::readCPU(uint addr, uint8 data) -> uint8 {
case 0x4212: //HVBJOY
data &= 0x3e;
data |= (status.autoJoypadActive) << 0;
data |= io.autoJoypadPoll && status.autoJoypadCounter < 33;
data |= (hcounter() <= 2 || hcounter() >= 1096) << 6; //hblank
data |= (vcounter() >= ppu.vdisp()) << 7; //vblank
return data;